Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1502361 > unrolled thread

[PATCH 0/2] power: supply: Fix module autoload for some platform drivers

Back to article view | Back to linux.kernel

Contents

  [PATCH 0/2] power: supply: Fix module autoload for some platform drivers Javier Martinez Canillas <javier@osg.samsung.com> - 2016-10-17 21:20 +0200
    [PATCH 2/2] power: supply: axp288_fuel_gauge: Fix module autoload Javier Martinez Canillas <javier@osg.samsung.com> - 2016-10-17 21:20 +0200
    Re: [PATCH 0/2] power: supply: Fix module autoload for some platform  drivers Sebastian Reichel <sre@kernel.org> - 2016-10-19 05:40 +0200

#1502361 — [PATCH 0/2] power: supply: Fix module autoload for some platform drivers

Hello Sebastian,

I noticed that module autoload won't be working for some of the power
supply platform drivers. This patch series contains fixes for these.

Best regards,
Javier


Javier Martinez Canillas (2):
  power: supply: max8997_charger: Fix module autoload
  power: supply: axp288_fuel_gauge: Fix module autoload

 drivers/power/supply/axp288_fuel_gauge.c | 1 +
 drivers/power/supply/max8997_charger.c   | 1 +
 2 files changed, 2 insertions(+)

-- 
2.7.4

[toc] | [next] | [standalone]

#1502362 — [PATCH 2/2] power: supply: axp288_fuel_gauge: Fix module autoload

If the driver is built as a module, autoload won't work because the module
alias information is not filled. So user-space can't match the registered
device with the corresponding module.

Export the module alias information using the MODULE_DEVICE_TABLE() macro.

Before this patch:

$ modinfo drivers/power/supply/axp288_fuel_gauge.ko | grep alias
$

After this patch:

$ modinfo drivers/power/supply/axp288_fuel_gauge.ko | grep alias
alias:          platform:axp288_fuel_gauge

Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>

---

 drivers/power/supply/axp288_fuel_gauge.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/power/supply/axp288_fuel_gauge.c b/drivers/power/supply/axp288_fuel_gauge.c
index 5bdde692f724..539eb41504bb 100644
--- a/drivers/power/supply/axp288_fuel_gauge.c
+++ b/drivers/power/supply/axp288_fuel_gauge.c
@@ -1120,6 +1120,7 @@ static const struct platform_device_id axp288_fg_id_table[] = {
 	{ .name = DEV_NAME },
 	{},
 };
+MODULE_DEVICE_TABLE(platform, axp288_fg_id_table);
 
 static int axp288_fuel_gauge_remove(struct platform_device *pdev)
 {
-- 
2.7.4

[toc] | [prev] | [next] | [standalone]

#1503544 — Re: [PATCH 0/2] power: supply: Fix module autoload for some platform drivers

[Multipart message — attachments visible in raw view] — view raw

Hi Javier,

On Mon, Oct 17, 2016 at 04:13:34PM -0300, Javier Martinez Canillas wrote:
> Hello Sebastian,
> 
> I noticed that module autoload won't be working for some of the power
> supply platform drivers. This patch series contains fixes for these.
> 
> Best regards,
> Javier
> 
> 
> Javier Martinez Canillas (2):
>   power: supply: max8997_charger: Fix module autoload
>   power: supply: axp288_fuel_gauge: Fix module autoload
> 
>  drivers/power/supply/axp288_fuel_gauge.c | 1 +
>  drivers/power/supply/max8997_charger.c   | 1 +
>  2 files changed, 2 insertions(+)

Thanks, queued.

-- Sebastian

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web