Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1502337 > unrolled thread

[PATCH 0/4] power: reset: Fix module autoload for some platform drivers

Back to article view | Back to linux.kernel

Contents

  [PATCH 0/4] power: reset: Fix module autoload for some platform drivers Javier Martinez Canillas <javier@osg.samsung.com> - 2016-10-17 20:40 +0200
    [PATCH 4/4] power: reset: zx-reboot: Fix module autoload Javier Martinez Canillas <javier@osg.samsung.com> - 2016-10-17 20:40 +0200
    [PATCH 1/4] power: reset: at91-reset: Fix module autoload Javier Martinez Canillas <javier@osg.samsung.com> - 2016-10-17 20:40 +0200
    Re: [PATCH 0/4] power: reset: Fix module autoload for some platform  drivers Sebastian Reichel <sre@kernel.org> - 2016-10-19 05:40 +0200

#1502337 — [PATCH 0/4] power: reset: Fix module autoload for some platform drivers

Hello Sebastian,

I noticed that module autoload won't be working in a some of the reset
platform drivers This patch series contains the fixes for these.

Best regards,
Javier


Javier Martinez Canillas (4):
  power: reset: at91-reset: Fix module autoload
  power: reset: at91-poweroff: Fix module autoload
  power: reset: syscon-reboot-mode: Fix module autoload
  power: reset: zx-reboot: Fix module autoload

 drivers/power/reset/at91-poweroff.c      | 1 +
 drivers/power/reset/at91-reset.c         | 2 ++
 drivers/power/reset/syscon-reboot-mode.c | 1 +
 drivers/power/reset/zx-reboot.c          | 1 +
 4 files changed, 5 insertions(+)

-- 
2.7.4

[toc] | [next] | [standalone]

#1502338 — [PATCH 4/4] power: reset: zx-reboot: Fix module autoload

If the driver is built as a module, autoload won't work because the module
alias information is not filled. So user-space can't match the registered
device with the corresponding module.

Export the module alias information using the MODULE_DEVICE_TABLE() macro.

Before this patch:

$ modinfo drivers/power/reset/zx-reboot.ko | grep alias
$

After this patch:

$ modinfo drivers/power/reset/zx-reboot.ko | grep alias
alias:          of:N*T*Czte,sysctrlC*
alias:          of:N*T*Czte,sysctrl

Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>

---

 drivers/power/reset/zx-reboot.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/power/reset/zx-reboot.c b/drivers/power/reset/zx-reboot.c
index b0b1eb3a78c2..7549c7f74a3c 100644
--- a/drivers/power/reset/zx-reboot.c
+++ b/drivers/power/reset/zx-reboot.c
@@ -72,6 +72,7 @@ static const struct of_device_id zx_reboot_of_match[] = {
 	{ .compatible = "zte,sysctrl" },
 	{}
 };
+MODULE_DEVICE_TABLE(of, zx_reboot_of_match);
 
 static struct platform_driver zx_reboot_driver = {
 	.probe = zx_reboot_probe,
-- 
2.7.4

[toc] | [prev] | [next] | [standalone]

#1502339 — [PATCH 1/4] power: reset: at91-reset: Fix module autoload

If the driver is built as a module, autoload won't work because the module
alias information is not filled. So user-space can't match the registered
device with the corresponding module.

Export the module alias information using the MODULE_DEVICE_TABLE() macro.

Before this patch:

$ modinfo drivers/power/reset/at91-reset.ko | grep alias
$

After this patch:

$ modinfo drivers/power/reset/at91-reset.ko | grep alias
alias:          of:N*T*Catmel,sama5d3-rstcC*
alias:          of:N*T*Catmel,sama5d3-rstc
alias:          of:N*T*Catmel,at91sam9g45-rstcC*
alias:          of:N*T*Catmel,at91sam9g45-rstc
alias:          of:N*T*Catmel,at91sam9260-rstcC*
alias:          of:N*T*Catmel,at91sam9260-rstc
alias:          platform:at91-sam9g45-reset
alias:          platform:at91-sam9260-reset

Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
---

 drivers/power/reset/at91-reset.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/power/reset/at91-reset.c b/drivers/power/reset/at91-reset.c
index 1b5d450586d1..568580cf0655 100644
--- a/drivers/power/reset/at91-reset.c
+++ b/drivers/power/reset/at91-reset.c
@@ -175,6 +175,7 @@ static const struct of_device_id at91_reset_of_match[] = {
 	{ .compatible = "atmel,sama5d3-rstc", .data = sama5d3_restart },
 	{ /* sentinel */ }
 };
+MODULE_DEVICE_TABLE(of, at91_reset_of_match);
 
 static struct notifier_block at91_restart_nb = {
 	.priority = 192,
@@ -242,6 +243,7 @@ static const struct platform_device_id at91_reset_plat_match[] = {
 	{ "at91-sam9g45-reset", (unsigned long)at91sam9g45_restart },
 	{ /* sentinel */ }
 };
+MODULE_DEVICE_TABLE(platform, at91_reset_plat_match);
 
 static struct platform_driver at91_reset_driver = {
 	.remove = __exit_p(at91_reset_remove),
-- 
2.7.4

[toc] | [prev] | [next] | [standalone]

#1503543 — Re: [PATCH 0/4] power: reset: Fix module autoload for some platform drivers

[Multipart message — attachments visible in raw view] — view raw

Hi Javier,

On Mon, Oct 17, 2016 at 03:36:11PM -0300, Javier Martinez Canillas wrote:
> I noticed that module autoload won't be working in a some of the reset
> platform drivers This patch series contains the fixes for these.
> 
> Best regards,
> Javier
> 
> 
> Javier Martinez Canillas (4):
>   power: reset: at91-reset: Fix module autoload
>   power: reset: at91-poweroff: Fix module autoload
>   power: reset: syscon-reboot-mode: Fix module autoload
>   power: reset: zx-reboot: Fix module autoload
> 
>  drivers/power/reset/at91-poweroff.c      | 1 +
>  drivers/power/reset/at91-reset.c         | 2 ++
>  drivers/power/reset/syscon-reboot-mode.c | 1 +
>  drivers/power/reset/zx-reboot.c          | 1 +
>  4 files changed, 5 insertions(+)

Thanks, queued.

-- Sebastian

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web