Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1502306 > unrolled thread

Re: [PATCH] xfs: remove redundant assignment of ifp

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH] xfs: remove redundant assignment of ifp "Darrick J. Wong" <darrick.wong@oracle.com> - 2016-10-17 19:40 +0200

#1502306 — Re: [PATCH] xfs: remove redundant assignment of ifp

On Mon, Oct 17, 2016 at 06:32:40PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> Remove redundant ifp = ifp statement, it does nothing. Found with
> static analysis by CoverityScan.
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>

> ---
>  fs/xfs/libxfs/xfs_bmap.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/xfs/libxfs/xfs_bmap.c b/fs/xfs/libxfs/xfs_bmap.c
> index c27344c..0283b7e 100644
> --- a/fs/xfs/libxfs/xfs_bmap.c
> +++ b/fs/xfs/libxfs/xfs_bmap.c
> @@ -5204,7 +5204,7 @@ xfs_bunmapi_cow(
>  	ep = xfs_bmap_search_extents(ip, del->br_startoff, XFS_COW_FORK, &eof,
>  			&eidx, &got, &new);
>  
> -	ifp = XFS_IFORK_PTR(ip, XFS_COW_FORK); ifp = ifp;
> +	ifp = XFS_IFORK_PTR(ip, XFS_COW_FORK);
>  	ASSERT((eidx >= 0) && (eidx < ifp->if_bytes /
>  		(uint)sizeof(xfs_bmbt_rec_t)));
>  	ASSERT(del->br_blockcount > 0);
> -- 
> 2.9.3
> 

[toc] | [standalone]

Back to top | Article view | linux.kernel

csiph-web