Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1502113 > unrolled thread
| Started by | Javier Martinez Canillas <javier@osg.samsung.com> |
|---|---|
| First post | 2016-10-17 17:50 +0200 |
| Last post | 2016-10-17 18:50 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH 3/5] [media] rc: meson-ir: Fix module autoload Javier Martinez Canillas <javier@osg.samsung.com> - 2016-10-17 17:50 +0200
Re: [PATCH 3/5] [media] rc: meson-ir: Fix module autoload Kevin Hilman <khilman@baylibre.com> - 2016-10-17 18:50 +0200
| From | Javier Martinez Canillas <javier@osg.samsung.com> |
|---|---|
| Date | 2016-10-17 17:50 +0200 |
| Subject | [PATCH 3/5] [media] rc: meson-ir: Fix module autoload |
| Message-ID | <stikO-5jI-17@gated-at.bofh.it> |
If the driver is built as a module, autoload won't work because the module
alias information is not filled. So user-space can't match the registered
device with the corresponding module.
Export the module alias information using the MODULE_DEVICE_TABLE() macro.
Before this patch:
$ modinfo drivers/media/rc/meson-ir.ko | grep alias
$
After this patch:
$ modinfo drivers/media/rc/meson-ir.ko | grep alias
alias: of:N*T*Camlogic,meson-gxbb-irC*
alias: of:N*T*Camlogic,meson-gxbb-ir
alias: of:N*T*Camlogic,meson8b-irC*
alias: of:N*T*Camlogic,meson8b-ir
alias: of:N*T*Camlogic,meson6-irC*
alias: of:N*T*Camlogic,meson6-ir
Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
---
drivers/media/rc/meson-ir.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/media/rc/meson-ir.c b/drivers/media/rc/meson-ir.c
index 003fff07ade2..7eb3f4f1ddcd 100644
--- a/drivers/media/rc/meson-ir.c
+++ b/drivers/media/rc/meson-ir.c
@@ -218,6 +218,7 @@ static const struct of_device_id meson_ir_match[] = {
{ .compatible = "amlogic,meson-gxbb-ir" },
{ },
};
+MODULE_DEVICE_TABLE(of, meson_ir_match);
static struct platform_driver meson_ir_driver = {
.probe = meson_ir_probe,
--
2.7.4
[toc] | [next] | [standalone]
| From | Kevin Hilman <khilman@baylibre.com> |
|---|---|
| Date | 2016-10-17 18:50 +0200 |
| Message-ID | <stjgR-5Xu-7@gated-at.bofh.it> |
| In reply to | #1502113 |
On Mon, Oct 17, 2016 at 8:44 AM, Javier Martinez Canillas <javier@osg.samsung.com> wrote: > If the driver is built as a module, autoload won't work because the module > alias information is not filled. So user-space can't match the registered > device with the corresponding module. > > Export the module alias information using the MODULE_DEVICE_TABLE() macro. > > Before this patch: > > $ modinfo drivers/media/rc/meson-ir.ko | grep alias > $ > > After this patch: > > $ modinfo drivers/media/rc/meson-ir.ko | grep alias > alias: of:N*T*Camlogic,meson-gxbb-irC* > alias: of:N*T*Camlogic,meson-gxbb-ir > alias: of:N*T*Camlogic,meson8b-irC* > alias: of:N*T*Camlogic,meson8b-ir > alias: of:N*T*Camlogic,meson6-irC* > alias: of:N*T*Camlogic,meson6-ir > > Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com> Acked-by: Kevin Hilman <khilman@baylibre.com>
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web