Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1502082 > unrolled thread

[PATCH] irqchip: gic-v3-its: fix entry size mask for GITS_BASER

Started byVladimir Murzin <vladimir.murzin@arm.com>
First post2016-10-17 17:10 +0200
Last post2016-10-17 17:20 +0200
Articles 2 — 2 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH] irqchip: gic-v3-its: fix entry size mask for GITS_BASER Vladimir Murzin <vladimir.murzin@arm.com> - 2016-10-17 17:10 +0200
    Re: [PATCH] irqchip: gic-v3-its: fix entry size mask for GITS_BASER Fabio Estevam <festevam@gmail.com> - 2016-10-17 17:20 +0200

#1502082 — [PATCH] irqchip: gic-v3-its: fix entry size mask for GITS_BASER

FromVladimir Murzin <vladimir.murzin@arm.com>
Date2016-10-17 17:10 +0200
Subject[PATCH] irqchip: gic-v3-its: fix entry size mask for GITS_BASER
Message-ID<sthI5-55T-3@gated-at.bofh.it>
Entry Size in GITS_BASER<n> occupies 5 bits [52:48], but we mask out 8
bits.

Fixes: cc2d3216f53c ("irqchip: GICv3: ITS command queue")

Signed-off-by: Vladimir Murzin <vladimir.murzin@arm.com>
---
 include/linux/irqchip/arm-gic-v3.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/irqchip/arm-gic-v3.h b/include/linux/irqchip/arm-gic-v3.h
index 7dec96f..5118d3a 100644
--- a/include/linux/irqchip/arm-gic-v3.h
+++ b/include/linux/irqchip/arm-gic-v3.h
@@ -290,7 +290,7 @@
 #define GITS_BASER_TYPE_SHIFT			(56)
 #define GITS_BASER_TYPE(r)		(((r) >> GITS_BASER_TYPE_SHIFT) & 7)
 #define GITS_BASER_ENTRY_SIZE_SHIFT		(48)
-#define GITS_BASER_ENTRY_SIZE(r)	((((r) >> GITS_BASER_ENTRY_SIZE_SHIFT) & 0xff) + 1)
+#define GITS_BASER_ENTRY_SIZE(r)	((((r) >> GITS_BASER_ENTRY_SIZE_SHIFT) & 0x1f) + 1)
 #define GITS_BASER_SHAREABILITY_SHIFT	(10)
 #define GITS_BASER_InnerShareable					\
 	GIC_BASER_SHAREABILITY(GITS_BASER, InnerShareable)
-- 
1.7.9.5

[toc] | [next] | [standalone]


#1502088

FromFabio Estevam <festevam@gmail.com>
Date2016-10-17 17:20 +0200
Message-ID<sthRL-59n-3@gated-at.bofh.it>
In reply to#1502082
On Mon, Oct 17, 2016 at 1:00 PM, Vladimir Murzin
<vladimir.murzin@arm.com> wrote:
> Entry Size in GITS_BASER<n> occupies 5 bits [52:48], but we mask out 8
> bits.
>
> Fixes: cc2d3216f53c ("irqchip: GICv3: ITS command queue")

Looks like it needs the following tag then:

Cc: <stable@vger.kernel.org> # 3.19+

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web