Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1502733 > unrolled thread

Re: [PATCH 5/6] clk: pxa: transfer CPU clock setting from pxa2xx-cpufreq

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH 5/6] clk: pxa: transfer CPU clock setting from pxa2xx-cpufreq Robert Jarzmik <robert.jarzmik@free.fr> - 2016-10-18 09:10 +0200
    Re: [PATCH 5/6] clk: pxa: transfer CPU clock setting from  pxa2xx-cpufreq Stephen Boyd <sboyd@codeaurora.org> - 2016-10-19 01:50 +0200
      Re: [PATCH 5/6] clk: pxa: transfer CPU clock setting from pxa2xx-cpufreq Robert Jarzmik <robert.jarzmik@free.fr> - 2016-10-19 22:20 +0200
        Re: [PATCH 5/6] clk: pxa: transfer CPU clock setting from  pxa2xx-cpufreq Stephen Boyd <sboyd@codeaurora.org> - 2016-10-19 23:00 +0200
          Re: [PATCH 5/6] clk: pxa: transfer CPU clock setting from  pxa2xx-cpufreq Viresh Kumar <viresh.kumar@linaro.org> - 2016-10-20 05:50 +0200

#1502733 — Re: [PATCH 5/6] clk: pxa: transfer CPU clock setting from pxa2xx-cpufreq

Robert Jarzmik <robert.jarzmik@free.fr> writes:

> This is the initial stage to transfer the pxa25x and pxa27x CPU clocks
> handling from cpufreq to the clock API. More precisely, the clocks
> transferred are :
>  - cpll : core pll, known also as the CPU core turbo frequency
>  - core : core, known also as the CPU actual frequency, being either the
>           CPU core turbo frequency or the CPU core run frequency
>
> This transfer is a prequel to shrink the code in pxa2xx-cpufreq.c, so
> that it can become, at least in devicetree builds, the casual cpufreq-dt
> driver.

Hi Michael and Stephen,

I'm planing on sending a v2 next week with minor corrections, mostly in the data
tables (pxa25x_freqs and pxa27x_freqs), as testing prooved some values were wrong.

If you want me modify this serie, will you have time to review for next week or
should I delay the v2 posting ?

Cheers.

--
Robert

[toc] | [next] | [standalone]

#1503452 — Re: [PATCH 5/6] clk: pxa: transfer CPU clock setting from pxa2xx-cpufreq

On 10/18, Robert Jarzmik wrote:
> Robert Jarzmik <robert.jarzmik@free.fr> writes:
> 
> > This is the initial stage to transfer the pxa25x and pxa27x CPU clocks
> > handling from cpufreq to the clock API. More precisely, the clocks
> > transferred are :
> >  - cpll : core pll, known also as the CPU core turbo frequency
> >  - core : core, known also as the CPU actual frequency, being either the
> >           CPU core turbo frequency or the CPU core run frequency
> >
> > This transfer is a prequel to shrink the code in pxa2xx-cpufreq.c, so
> > that it can become, at least in devicetree builds, the casual cpufreq-dt
> > driver.
> 
> Hi Michael and Stephen,
> 
> I'm planing on sending a v2 next week with minor corrections, mostly in the data
> tables (pxa25x_freqs and pxa27x_freqs), as testing prooved some values were wrong.
> 
> If you want me modify this serie, will you have time to review for next week or
> should I delay the v2 posting ?
> 

No need to delay. clk patches look fine with a quick glance. It
would be really neat if we could make cpufreq-dt work without DT.
What's blocking that? OPP tables?

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

[toc] | [prev] | [next] | [standalone]

#1504314

Stephen Boyd <sboyd@codeaurora.org> writes:

> On 10/18, Robert Jarzmik wrote:
>> Robert Jarzmik <robert.jarzmik@free.fr> writes:
>> Hi Michael and Stephen,
>> 
>> I'm planing on sending a v2 next week with minor corrections, mostly in the data
>> tables (pxa25x_freqs and pxa27x_freqs), as testing prooved some values were wrong.
>> 
>> If you want me modify this serie, will you have time to review for next week or
>> should I delay the v2 posting ?
>> 
>
> No need to delay. clk patches look fine with a quick glance. It
> would be really neat if we could make cpufreq-dt work without DT.
> What's blocking that? OPP tables?

Heu I'm not the author of cpufreq-dt, so I'm not the best to answer.
To answer the question "without DT", it depends if you mean "with ACPI" or "with
platform_data" or something else.

From what I've seen so far, the missing/blocking points are :
 - the OPP points definition as you said
 - probably same thing for the input power supply / regulator
 - the cooling parts probably
 - and more generaly all the cpufreq-dt is built around device-tree
 - last point, the name from KConfig, "Generic DT based cpufreq driver"
   => that strongly suggest it's device-tree only

I'm deeply convinced that Viresh being one of the authors will shed more light
on this.

Cheers.

-- 
Robert

[toc] | [prev] | [next] | [standalone]

#1504338 — Re: [PATCH 5/6] clk: pxa: transfer CPU clock setting from pxa2xx-cpufreq

On 10/19, Robert Jarzmik wrote:
> Stephen Boyd <sboyd@codeaurora.org> writes:
> 
> > On 10/18, Robert Jarzmik wrote:
> >> Robert Jarzmik <robert.jarzmik@free.fr> writes:
> >> Hi Michael and Stephen,
> >> 
> >> I'm planing on sending a v2 next week with minor corrections, mostly in the data
> >> tables (pxa25x_freqs and pxa27x_freqs), as testing prooved some values were wrong.
> >> 
> >> If you want me modify this serie, will you have time to review for next week or
> >> should I delay the v2 posting ?
> >> 
> >
> > No need to delay. clk patches look fine with a quick glance. It
> > would be really neat if we could make cpufreq-dt work without DT.
> > What's blocking that? OPP tables?
> 
> Heu I'm not the author of cpufreq-dt, so I'm not the best to answer.
> To answer the question "without DT", it depends if you mean "with ACPI" or "with
> platform_data" or something else.

I mean platform_data mostly. Do you use ACPI with the clk driver?

> 
> From what I've seen so far, the missing/blocking points are :
>  - the OPP points definition as you said

Hm.. I thought cpufreq-dt worked with OPP tables populated by
other code (i.e. platform code).

>  - probably same thing for the input power supply / regulator

Regulators should be optional I hope. Do you use regulators in
your design that has platform_data?

>  - the cooling parts probably
>  - and more generaly all the cpufreq-dt is built around device-tree
>  - last point, the name from KConfig, "Generic DT based cpufreq driver"
>    => that strongly suggest it's device-tree only
> 
> I'm deeply convinced that Viresh being one of the authors will shed more light
> on this.

Sure, thanks for the notes.

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

[toc] | [prev] | [next] | [standalone]

#1504505 — Re: [PATCH 5/6] clk: pxa: transfer CPU clock setting from pxa2xx-cpufreq

On 19-10-16, 13:51, Stephen Boyd wrote:
> On 10/19, Robert Jarzmik wrote:
> > Stephen Boyd <sboyd@codeaurora.org> writes:
> > 
> > > On 10/18, Robert Jarzmik wrote:
> > >> Robert Jarzmik <robert.jarzmik@free.fr> writes:
> > >> Hi Michael and Stephen,
> > >> 
> > >> I'm planing on sending a v2 next week with minor corrections, mostly in the data
> > >> tables (pxa25x_freqs and pxa27x_freqs), as testing prooved some values were wrong.
> > >> 
> > >> If you want me modify this serie, will you have time to review for next week or
> > >> should I delay the v2 posting ?
> > >> 
> > >
> > > No need to delay. clk patches look fine with a quick glance. It
> > > would be really neat if we could make cpufreq-dt work without DT.
> > > What's blocking that? OPP tables?
> > 
> > Heu I'm not the author of cpufreq-dt, so I'm not the best to answer.
> > To answer the question "without DT", it depends if you mean "with ACPI" or "with
> > platform_data" or something else.
> 
> I mean platform_data mostly. Do you use ACPI with the clk driver?

I would like to see sample code for that, as I am not sure what all changes
would be required in cpufreq-dt in that case. Yes it is more dependent on the
OPP framework than DT right now.

My first impression is that it should be doable..

-- 
viresh

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web