Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1503335 > unrolled thread
| Started by | Javier Martinez Canillas <javier@osg.samsung.com> |
|---|---|
| First post | 2016-10-18 22:50 +0200 |
| Last post | 2016-10-24 00:30 +0200 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH 1/2] gpio: ath79: Fix module autoload Javier Martinez Canillas <javier@osg.samsung.com> - 2016-10-18 22:50 +0200
Re: [PATCH 1/2] gpio: ath79: Fix module autoload Alban <albeu@free.fr> - 2016-10-19 19:20 +0200
Re: [PATCH 1/2] gpio: ath79: Fix module autoload Linus Walleij <linus.walleij@linaro.org> - 2016-10-24 00:30 +0200
| From | Javier Martinez Canillas <javier@osg.samsung.com> |
|---|---|
| Date | 2016-10-18 22:50 +0200 |
| Subject | [PATCH 1/2] gpio: ath79: Fix module autoload |
| Message-ID | <stJuF-759-5@gated-at.bofh.it> |
If the driver is built as a module, autoload won't work because the module
alias information is not filled. So user-space can't match the registered
device with the corresponding module.
Export the module alias information using the MODULE_DEVICE_TABLE() macro.
Before this patch:
$ modinfo drivers/gpio/gpio-ath79.ko | grep alias
$
After this patch:
$ modinfo drivers/gpio/gpio-ath79.ko | grep alias
alias: of:N*T*Cqca,ar9340-gpioC*
alias: of:N*T*Cqca,ar9340-gpio
alias: of:N*T*Cqca,ar7100-gpioC*
alias: of:N*T*Cqca,ar7100-gpio
Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
---
drivers/gpio/gpio-ath79.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpio/gpio-ath79.c b/drivers/gpio/gpio-ath79.c
index 9457e2022bf6..dc37dbe4b46d 100644
--- a/drivers/gpio/gpio-ath79.c
+++ b/drivers/gpio/gpio-ath79.c
@@ -219,6 +219,7 @@ static const struct of_device_id ath79_gpio_of_match[] = {
{ .compatible = "qca,ar9340-gpio" },
{},
};
+MODULE_DEVICE_TABLE(of, ath79_gpio_of_match);
static int ath79_gpio_probe(struct platform_device *pdev)
{
--
2.7.4
[toc] | [next] | [standalone]
| From | Alban <albeu@free.fr> |
|---|---|
| Date | 2016-10-19 19:20 +0200 |
| Message-ID | <su2GZ-4ip-5@gated-at.bofh.it> |
| In reply to | #1503335 |
[Multipart message — attachments visible in raw view] — view raw
On Tue, 18 Oct 2016 17:44:01 -0300 Javier Martinez Canillas <javier@osg.samsung.com> wrote: > If the driver is built as a module, autoload won't work because the module > alias information is not filled. So user-space can't match the registered > device with the corresponding module. > > Export the module alias information using the MODULE_DEVICE_TABLE() macro. > > Before this patch: > > $ modinfo drivers/gpio/gpio-ath79.ko | grep alias > $ > > After this patch: > > $ modinfo drivers/gpio/gpio-ath79.ko | grep alias > alias: of:N*T*Cqca,ar9340-gpioC* > alias: of:N*T*Cqca,ar9340-gpio > alias: of:N*T*Cqca,ar7100-gpioC* > alias: of:N*T*Cqca,ar7100-gpio > > Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com> Acked-by: Aban Bedel <albeu@free.fr> Alban
[toc] | [prev] | [next] | [standalone]
| From | Linus Walleij <linus.walleij@linaro.org> |
|---|---|
| Date | 2016-10-24 00:30 +0200 |
| Message-ID | <svzrc-6XD-5@gated-at.bofh.it> |
| In reply to | #1503335 |
On Tue, Oct 18, 2016 at 10:44 PM, Javier Martinez Canillas <javier@osg.samsung.com> wrote: > If the driver is built as a module, autoload won't work because the module > alias information is not filled. So user-space can't match the registered > device with the corresponding module. > > Export the module alias information using the MODULE_DEVICE_TABLE() macro. > > Before this patch: > > $ modinfo drivers/gpio/gpio-ath79.ko | grep alias > $ > > After this patch: > > $ modinfo drivers/gpio/gpio-ath79.ko | grep alias > alias: of:N*T*Cqca,ar9340-gpioC* > alias: of:N*T*Cqca,ar9340-gpio > alias: of:N*T*Cqca,ar7100-gpioC* > alias: of:N*T*Cqca,ar7100-gpio > > Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com> Patch applied with Alban's ACK. Yours, Linus Walleij
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web