Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1501319 > unrolled thread
| Started by | Colin King <colin.king@canonical.com> |
|---|---|
| First post | 2016-10-15 18:10 +0200 |
| Last post | 2016-10-18 21:30 +0200 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH][V2] ubi: fix swapped arguments to call to ubi_alloc_aeb Colin King <colin.king@canonical.com> - 2016-10-15 18:10 +0200
Re: [PATCH][V2] ubi: fix swapped arguments to call to ubi_alloc_aeb Boris Brezillon <boris.brezillon@free-electrons.com> - 2016-10-16 17:40 +0200
Re: [PATCH][V2] ubi: fix swapped arguments to call to ubi_alloc_aeb Richard Weinberger <richard@nod.at> - 2016-10-18 21:30 +0200
| From | Colin King <colin.king@canonical.com> |
|---|---|
| Date | 2016-10-15 18:10 +0200 |
| Subject | [PATCH][V2] ubi: fix swapped arguments to call to ubi_alloc_aeb |
| Message-ID | <sszH3-1tj-1@gated-at.bofh.it> |
From: Colin Ian King <colin.king@canonical.com>
Static analysis by CoverityScan detected the ec and pnum
arguments are in the wrong order on a call to ubi_alloc_aeb.
Swap the order to fix this.
Fixes: 91f4285fe389a27 ("UBI: provide helpers to allocate and free aeb elements")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/mtd/ubi/fastmap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mtd/ubi/fastmap.c b/drivers/mtd/ubi/fastmap.c
index d6384d9..4eed546 100644
--- a/drivers/mtd/ubi/fastmap.c
+++ b/drivers/mtd/ubi/fastmap.c
@@ -287,7 +287,7 @@ static int update_vol(struct ubi_device *ubi, struct ubi_attach_info *ai,
/* new_aeb is newer */
if (cmp_res & 1) {
- victim = ubi_alloc_aeb(ai, aeb->ec, aeb->pnum);
+ victim = ubi_alloc_aeb(ai, aeb->pnum, aeb->ec);
if (!victim)
return -ENOMEM;
--
2.9.3
[toc] | [next] | [standalone]
| From | Boris Brezillon <boris.brezillon@free-electrons.com> |
|---|---|
| Date | 2016-10-16 17:40 +0200 |
| Message-ID | <ssVHA-7AY-5@gated-at.bofh.it> |
| In reply to | #1501319 |
On Sat, 15 Oct 2016 17:00:11 +0100
Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Static analysis by CoverityScan detected the ec and pnum
> arguments are in the wrong order on a call to ubi_alloc_aeb.
> Swap the order to fix this.
>
> Fixes: 91f4285fe389a27 ("UBI: provide helpers to allocate and free aeb elements")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Boris Brezillon <boris.brezillon@free-electrons.com>
> ---
> drivers/mtd/ubi/fastmap.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/ubi/fastmap.c b/drivers/mtd/ubi/fastmap.c
> index d6384d9..4eed546 100644
> --- a/drivers/mtd/ubi/fastmap.c
> +++ b/drivers/mtd/ubi/fastmap.c
> @@ -287,7 +287,7 @@ static int update_vol(struct ubi_device *ubi, struct ubi_attach_info *ai,
>
> /* new_aeb is newer */
> if (cmp_res & 1) {
> - victim = ubi_alloc_aeb(ai, aeb->ec, aeb->pnum);
> + victim = ubi_alloc_aeb(ai, aeb->pnum, aeb->ec);
> if (!victim)
> return -ENOMEM;
>
[toc] | [prev] | [next] | [standalone]
| From | Richard Weinberger <richard@nod.at> |
|---|---|
| Date | 2016-10-18 21:30 +0200 |
| Message-ID | <stIff-6f2-1@gated-at.bofh.it> |
| In reply to | #1501484 |
On 16.10.2016 17:38, Boris Brezillon wrote:
> On Sat, 15 Oct 2016 17:00:11 +0100
> Colin King <colin.king@canonical.com> wrote:
>
>> From: Colin Ian King <colin.king@canonical.com>
>>
>> Static analysis by CoverityScan detected the ec and pnum
>> arguments are in the wrong order on a call to ubi_alloc_aeb.
>> Swap the order to fix this.
>>
>> Fixes: 91f4285fe389a27 ("UBI: provide helpers to allocate and free aeb elements")
>> Signed-off-by: Colin Ian King <colin.king@canonical.com>
>
> Reviewed-by: Boris Brezillon <boris.brezillon@free-electrons.com>
Applied. :)
Thanks,
//richard
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web