Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1503084 > unrolled thread

[PATCH 2/2] scripts/gdb: fixup some pep8 errors in proc.py

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  [PATCH 2/2] scripts/gdb: fixup some pep8 errors in proc.py Peter Griffin <peter.griffin@linaro.org> - 2016-10-18 17:10 +0200
    Re: [PATCH 2/2] scripts/gdb: fixup some pep8 errors in proc.py Kieran Bingham <kieran@ksquared.org.uk> - 2016-10-18 17:30 +0200
      Re: [PATCH 2/2] scripts/gdb: fixup some pep8 errors in proc.py Peter Griffin <peter.griffin@linaro.org> - 2016-10-18 18:00 +0200

#1503084 — [PATCH 2/2] scripts/gdb: fixup some pep8 errors in proc.py

proc.py:22:1: E302 expected 2 blank lines, found 1
proc.py:200:1: E302 expected 2 blank lines, found 1

Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
---
 scripts/gdb/linux/proc.py | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/scripts/gdb/linux/proc.py b/scripts/gdb/linux/proc.py
index f20fcfa..2d6f74e 100644
--- a/scripts/gdb/linux/proc.py
+++ b/scripts/gdb/linux/proc.py
@@ -18,6 +18,7 @@ from linux import tasks
 from linux import lists
 from struct import *
 
+
 class LxCmdLine(gdb.Command):
     """ Report the Linux Commandline used in the current kernel.
         Equivalent to cat /proc/cmdline on a running target"""
@@ -196,6 +197,7 @@ values of that process namespace"""
 
 LxMounts()
 
+
 class LxFdtDump(gdb.Command):
     """Output Flattened Device Tree header and dump FDT blob to a file
        Equivalent to 'cat /proc/fdt > fdtdump.dtb' on a running target"""
-- 
1.9.1

[toc] | [next] | [standalone]

#1503101

Hi Pete,

On 18/10/16 16:07, Peter Griffin wrote:
> proc.py:22:1: E302 expected 2 blank lines, found 1
> proc.py:200:1: E302 expected 2 blank lines, found 1
> 
> Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
> ---
>  scripts/gdb/linux/proc.py | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/scripts/gdb/linux/proc.py b/scripts/gdb/linux/proc.py
> index f20fcfa..2d6f74e 100644
> --- a/scripts/gdb/linux/proc.py
> +++ b/scripts/gdb/linux/proc.py
> @@ -18,6 +18,7 @@ from linux import tasks
>  from linux import lists
>  from struct import *
>  
> +

This was added by patch 1, and can be squashed there.

>  class LxCmdLine(gdb.Command):
>      """ Report the Linux Commandline used in the current kernel.
>          Equivalent to cat /proc/cmdline on a running target"""
> @@ -196,6 +197,7 @@ values of that process namespace"""
>  
>  LxMounts()
>  
> +

Likewise...

>  class LxFdtDump(gdb.Command):
>      """Output Flattened Device Tree header and dump FDT blob to a file
>         Equivalent to 'cat /proc/fdt > fdtdump.dtb' on a running target"""
> 

-- 
Regards

Kieran Bingham

[toc] | [prev] | [next] | [standalone]

#1503166

Hi Kieran,

On Tue, 18 Oct 2016, Kieran Bingham wrote:

> Hi Pete,
> 
> On 18/10/16 16:07, Peter Griffin wrote:
> > proc.py:22:1: E302 expected 2 blank lines, found 1
> > proc.py:200:1: E302 expected 2 blank lines, found 1
> > 
> > Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
> > ---
> >  scripts/gdb/linux/proc.py | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/scripts/gdb/linux/proc.py b/scripts/gdb/linux/proc.py
> > index f20fcfa..2d6f74e 100644
> > --- a/scripts/gdb/linux/proc.py
> > +++ b/scripts/gdb/linux/proc.py
> > @@ -18,6 +18,7 @@ from linux import tasks
> >  from linux import lists
> >  from struct import *
> >  
> > +
> 
> This was added by patch 1, and can be squashed there.

Doh, I had deliberately done it as a separate commit, as I thought it was
a pre-existing pep8 error.

Will squash in v2.

regards,

Peter.

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web