Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1503139 > unrolled thread

[RFC][PATCHv3 1/6] printk: use vprintk_func in vprintk()

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  [RFC][PATCHv3 1/6] printk: use vprintk_func in vprintk() Sergey Senozhatsky <sergey.senozhatsky@gmail.com> - 2016-10-18 17:50 +0200
    Re: [RFC][PATCHv3 1/6] printk: use vprintk_func in vprintk() Steven Rostedt <rostedt@goodmis.org> - 2016-10-18 18:50 +0200
      Re: [RFC][PATCHv3 1/6] printk: use vprintk_func in vprintk() Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2016-10-19 04:00 +0200

#1503139 — [RFC][PATCHv3 1/6] printk: use vprintk_func in vprintk()

vprintk(), just like printk(), better be using per-cpu printk_func
instead of direct vprintk_emit() call. Just in case if vprintk()
will ever be called from NMI, or from any other context that can
deadlock in printk().

Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
---
 kernel/printk/printk.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c
index d5e3973..be7f60b 100644
--- a/kernel/printk/printk.c
+++ b/kernel/printk/printk.c
@@ -1917,7 +1917,7 @@ EXPORT_SYMBOL(vprintk_emit);
 
 asmlinkage int vprintk(const char *fmt, va_list args)
 {
-	return vprintk_emit(0, LOGLEVEL_DEFAULT, NULL, 0, fmt, args);
+	return vprintk_func(fmt, args);
 }
 EXPORT_SYMBOL(vprintk);
 
-- 
2.10.1.382.ga23ca1b

[toc] | [next] | [standalone]

#1503221

On Wed, 19 Oct 2016 00:40:40 +0900
Sergey Senozhatsky <sergey.senozhatsky@gmail.com> wrote:

> vprintk(), just like printk(), better be using per-cpu printk_func
> instead of direct vprintk_emit() call. Just in case if vprintk()
> will ever be called from NMI, or from any other context that can
> deadlock in printk().
> 
> Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>

Reviewed-by: Steven Rostedt <rostedt@goodmis.org>

-- Steve

> ---
>  kernel/printk/printk.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c
> index d5e3973..be7f60b 100644
> --- a/kernel/printk/printk.c
> +++ b/kernel/printk/printk.c
> @@ -1917,7 +1917,7 @@ EXPORT_SYMBOL(vprintk_emit);
>  
>  asmlinkage int vprintk(const char *fmt, va_list args)
>  {
> -	return vprintk_emit(0, LOGLEVEL_DEFAULT, NULL, 0, fmt, args);
> +	return vprintk_func(fmt, args);
>  }
>  EXPORT_SYMBOL(vprintk);
>  

[toc] | [prev] | [next] | [standalone]

#1503496

On (10/18/16 12:49), Steven Rostedt wrote:
> On Wed, 19 Oct 2016 00:40:40 +0900
> Sergey Senozhatsky <sergey.senozhatsky@gmail.com> wrote:
> 
> > vprintk(), just like printk(), better be using per-cpu printk_func
> > instead of direct vprintk_emit() call. Just in case if vprintk()
> > will ever be called from NMI, or from any other context that can
> > deadlock in printk().
> > 
> > Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
> 
> Reviewed-by: Steven Rostedt <rostedt@goodmis.org>

Thanks.

	-ss

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web