Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1501566 > unrolled thread

[PATCH 0/4] AVR32-AT32AP: Fine-tuning for three function implementations

Started bySF Markus Elfring <elfring@users.sourceforge.net>
First post2016-10-16 22:40 +0200
Last post2016-10-16 22:40 +0200
Articles 2 — 1 participant

Back to article view | Back to linux.kernel


Contents

  [PATCH 0/4] AVR32-AT32AP: Fine-tuning for three function  implementations SF Markus Elfring <elfring@users.sourceforge.net> - 2016-10-16 22:40 +0200
    [PATCH 3/4] AVR32-pio: Use seq_putc() in pio_bank_show() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-10-16 22:40 +0200

#1501566 — [PATCH 0/4] AVR32-AT32AP: Fine-tuning for three function implementations

FromSF Markus Elfring <elfring@users.sourceforge.net>
Date2016-10-16 22:40 +0200
Subject[PATCH 0/4] AVR32-AT32AP: Fine-tuning for three function implementations
Message-ID<st0nT-2dB-7@gated-at.bofh.it>
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sun, 16 Oct 2016 22:30:22 +0200

A few update suggestions were taken into account
from static source code analysis.

Markus Elfring (4):
  clock: Use seq_putc() in two functions
  clock: Combine nine seq_printf() calls into one call in clk_show()
  pio: Use seq_putc() in pio_bank_show()
  pio: Replace two seq_printf() calls by seq_puts() in pio_bank_show()

 arch/avr32/mach-at32ap/clock.c | 33 +++++++++++++++++++++------------
 arch/avr32/mach-at32ap/pio.c   |  6 +++---
 2 files changed, 24 insertions(+), 15 deletions(-)

-- 
2.10.1

[toc] | [next] | [standalone]


#1501567 — [PATCH 3/4] AVR32-pio: Use seq_putc() in pio_bank_show()

FromSF Markus Elfring <elfring@users.sourceforge.net>
Date2016-10-16 22:40 +0200
Subject[PATCH 3/4] AVR32-pio: Use seq_putc() in pio_bank_show()
Message-ID<st0nT-2dB-15@gated-at.bofh.it>
In reply to#1501566
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sun, 16 Oct 2016 22:13:19 +0200

A single character (line break) should be put into a sequence.
Thus use the corresponding function "seq_putc".

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 arch/avr32/mach-at32ap/pio.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/avr32/mach-at32ap/pio.c b/arch/avr32/mach-at32ap/pio.c
index 13d3fc4..abbe1b5 100644
--- a/arch/avr32/mach-at32ap/pio.c
+++ b/arch/avr32/mach-at32ap/pio.c
@@ -373,7 +373,7 @@ static void pio_bank_show(struct seq_file *s, struct gpio_chip *chip)
 		if (imr & mask)
 			seq_printf(s, " irq-%d edge-both",
 				gpio_to_irq(chip->base + i));
-		seq_printf(s, "\n");
+		seq_putc(s, '\n');
 	}
 }
 
-- 
2.10.1

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web