Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1501565 > unrolled thread

[PATCH 4/4] AVR32-pio: Replace two seq_printf() calls by seq_puts() in pio_bank_show()

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  [PATCH 4/4] AVR32-pio: Replace two seq_printf() calls by seq_puts()  in pio_bank_show() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-10-16 22:40 +0200
    Re: [PATCH 4/4] AVR32-pio: Replace two seq_printf() calls by  seq_puts() in pio_bank_show() Hans-Christian Noren Egtvedt <egtvedt@samfundet.no> - 2016-10-23 14:00 +0200

#1501565 — [PATCH 4/4] AVR32-pio: Replace two seq_printf() calls by seq_puts() in pio_bank_show()

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sun, 16 Oct 2016 22:18:31 +0200

Strings which did not contain data format specifications should be put
into a sequence. Thus use the corresponding function "seq_puts".

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 arch/avr32/mach-at32ap/pio.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/avr32/mach-at32ap/pio.c b/arch/avr32/mach-at32ap/pio.c
index abbe1b5..7fae6ec 100644
--- a/arch/avr32/mach-at32ap/pio.c
+++ b/arch/avr32/mach-at32ap/pio.c
@@ -367,9 +367,9 @@ static void pio_bank_show(struct seq_file *s, struct gpio_chip *chip)
 			(mask & pdsr) ? "hi" : "lo",
 			(mask & pusr) ? "  " : "up");
 		if (ifsr & mask)
-			seq_printf(s, " deglitch");
+			seq_puts(s, " deglitch");
 		if ((osr & mdsr) & mask)
-			seq_printf(s, " open-drain");
+			seq_puts(s, " open-drain");
 		if (imr & mask)
 			seq_printf(s, " irq-%d edge-both",
 				gpio_to_irq(chip->base + i));
-- 
2.10.1

[toc] | [next] | [standalone]

#1506681 — Re: [PATCH 4/4] AVR32-pio: Replace two seq_printf() calls by seq_puts() in pio_bank_show()

Around Sun 16 Oct 2016 22:36:24 +0200 or thereabout, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Sun, 16 Oct 2016 22:18:31 +0200
> 
> Strings which did not contain data format specifications should be put
> into a sequence. Thus use the corresponding function "seq_puts".
> 
> This issue was detected by using the Coccinelle software.
> 
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>

This series of four patches look good to me, I will append them to for-linus
and push them for next merge window.

Thanks.

Acked-by: Hans-Christian Noren Egtvedt <egtvedt@samfundet.no>

> ---
>  arch/avr32/mach-at32ap/pio.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

<snipp diff>

-- 
mvh
Hans-Christian Noren Egtvedt

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web