Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1501190 > unrolled thread

Re: [RESEND PATCH] scsi: ufs: fix race between clock gating and devfreq scaling work

Started by"Martin K. Petersen" <martin.petersen@oracle.com>
First post2016-10-14 22:50 +0200
Last post2016-10-18 02:20 +0200
Articles 2 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [RESEND PATCH] scsi: ufs: fix race between clock gating and devfreq scaling work "Martin K. Petersen" <martin.petersen@oracle.com> - 2016-10-14 22:50 +0200
    Re: [RESEND PATCH] scsi: ufs: fix race between clock gating and  devfreq scaling work Subhash Jadavani <subhashj@codeaurora.org> - 2016-10-18 02:20 +0200

#1501190 — Re: [RESEND PATCH] scsi: ufs: fix race between clock gating and devfreq scaling work

From"Martin K. Petersen" <martin.petersen@oracle.com>
Date2016-10-14 22:50 +0200
SubjectRe: [RESEND PATCH] scsi: ufs: fix race between clock gating and devfreq scaling work
Message-ID<sshAt-6iL-7@gated-at.bofh.it>
>>>>> "Subhash" == Subhash Jadavani <subhashj@codeaurora.org> writes:

Subhash> UFS devfreq clock scaling work may require clocks to be ON if
Subhash> it need to execute some UFS commands hence it may request for
Subhash> clock hold before issuing the command. But if UFS clock gating
Subhash> work is already running in parallel, ungate work would end up
Subhash> waiting for the clock gating work to finish and as clock gating
Subhash> work would also wait for the clock scaling work to finish, we
Subhash> would enter in deadlock state. Here is the call trace during
Subhash> this deadlock state:

Somebody from the UFS camp, please review!

-- 
Martin K. Petersen	Oracle Linux Engineering

[toc] | [next] | [standalone]


#1502606 — Re: [RESEND PATCH] scsi: ufs: fix race between clock gating and devfreq scaling work

FromSubhash Jadavani <subhashj@codeaurora.org>
Date2016-10-18 02:20 +0200
SubjectRe: [RESEND PATCH] scsi: ufs: fix race between clock gating and devfreq scaling work
Message-ID<stqil-2Hw-5@gated-at.bofh.it>
In reply to#1501190
On 2016-10-14 13:47, Martin K. Petersen wrote:
>>>>>> "Subhash" == Subhash Jadavani <subhashj@codeaurora.org> writes:
> 
> Subhash> UFS devfreq clock scaling work may require clocks to be ON if
> Subhash> it need to execute some UFS commands hence it may request for
> Subhash> clock hold before issuing the command. But if UFS clock gating
> Subhash> work is already running in parallel, ungate work would end up
> Subhash> waiting for the clock gating work to finish and as clock 
> gating
> Subhash> work would also wait for the clock scaling work to finish, we
> Subhash> would enter in deadlock state. Here is the call trace during
> Subhash> this deadlock state:
> 
> Somebody from the UFS camp, please review!

As there was no review so far, i have moved this patch as first patch in 
the new UFS bug fixes patch series ([PATCH v1 00/11] scsi: ufs: bug 
fixes patch series #1) sent by me today.

Thanks,
Subhash

-- 
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web