Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1501068 > unrolled thread
| Started by | Javier Martinez Canillas <javier@osg.samsung.com> |
|---|---|
| First post | 2016-10-14 17:50 +0200 |
| Last post | 2016-10-26 14:50 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH 1/2] mfd: fsl-imx25-tsadc: Fix module autoload when registered via OF Javier Martinez Canillas <javier@osg.samsung.com> - 2016-10-14 17:50 +0200
Re: [PATCH 1/2] mfd: fsl-imx25-tsadc: Fix module autoload when registered via OF Lee Jones <lee.jones@linaro.org> - 2016-10-26 14:50 +0200
| From | Javier Martinez Canillas <javier@osg.samsung.com> |
|---|---|
| Date | 2016-10-14 17:50 +0200 |
| Subject | [PATCH 1/2] mfd: fsl-imx25-tsadc: Fix module autoload when registered via OF |
| Message-ID | <sscU9-3ay-3@gated-at.bofh.it> |
If the driver is built as a module, autoload won't work because the module
alias information is not filled. So user-space can't match the registered
device with the corresponding module.
Export the module alias information using the MODULE_DEVICE_TABLE() macro.
Before this patch:
$ modinfo drivers/mfd/fsl-imx25-tsadc.ko | grep alias
alias: platform:mx25-tsadc
After this patch:
$ modinfo drivers/mfd/fsl-imx25-tsadc.ko | grep alias
alias: platform:mx25-tsadc
alias: of:N*T*Cfsl,imx25-tsadcC*
alias: of:N*T*Cfsl,imx25-tsadc
Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
---
drivers/mfd/fsl-imx25-tsadc.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/mfd/fsl-imx25-tsadc.c b/drivers/mfd/fsl-imx25-tsadc.c
index 77b2675cf8f5..ac430a396a89 100644
--- a/drivers/mfd/fsl-imx25-tsadc.c
+++ b/drivers/mfd/fsl-imx25-tsadc.c
@@ -187,6 +187,7 @@ static const struct of_device_id mx25_tsadc_ids[] = {
{ .compatible = "fsl,imx25-tsadc" },
{ /* Sentinel */ }
};
+MODULE_DEVICE_TABLE(of, mx25_tsadc_ids);
static struct platform_driver mx25_tsadc_driver = {
.driver = {
--
2.7.4
[toc] | [next] | [standalone]
| From | Lee Jones <lee.jones@linaro.org> |
|---|---|
| Date | 2016-10-26 14:50 +0200 |
| Subject | Re: [PATCH 1/2] mfd: fsl-imx25-tsadc: Fix module autoload when registered via OF |
| Message-ID | <swvOx-3Ml-9@gated-at.bofh.it> |
| In reply to | #1501068 |
On Fri, 14 Oct 2016, Javier Martinez Canillas wrote:
> If the driver is built as a module, autoload won't work because the module
> alias information is not filled. So user-space can't match the registered
> device with the corresponding module.
>
> Export the module alias information using the MODULE_DEVICE_TABLE() macro.
>
> Before this patch:
>
> $ modinfo drivers/mfd/fsl-imx25-tsadc.ko | grep alias
> alias: platform:mx25-tsadc
>
> After this patch:
>
> $ modinfo drivers/mfd/fsl-imx25-tsadc.ko | grep alias
> alias: platform:mx25-tsadc
> alias: of:N*T*Cfsl,imx25-tsadcC*
> alias: of:N*T*Cfsl,imx25-tsadc
>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
> ---
>
> drivers/mfd/fsl-imx25-tsadc.c | 1 +
> 1 file changed, 1 insertion(+)
Applied, thanks.
> diff --git a/drivers/mfd/fsl-imx25-tsadc.c b/drivers/mfd/fsl-imx25-tsadc.c
> index 77b2675cf8f5..ac430a396a89 100644
> --- a/drivers/mfd/fsl-imx25-tsadc.c
> +++ b/drivers/mfd/fsl-imx25-tsadc.c
> @@ -187,6 +187,7 @@ static const struct of_device_id mx25_tsadc_ids[] = {
> { .compatible = "fsl,imx25-tsadc" },
> { /* Sentinel */ }
> };
> +MODULE_DEVICE_TABLE(of, mx25_tsadc_ids);
>
> static struct platform_driver mx25_tsadc_driver = {
> .driver = {
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web