Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1500983 > unrolled thread

[PATCH] rtc: asm9260: fix module autoload

Back to article view | Back to linux.kernel

Contents

  [PATCH] rtc: asm9260: fix module autoload Javier Martinez Canillas <javier@osg.samsung.com> - 2016-10-14 15:30 +0200
    Re: [PATCH] rtc: asm9260: fix module autoload Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2016-10-19 08:50 +0200

#1500983 — [PATCH] rtc: asm9260: fix module autoload

If the driver is built as a module, autoload won't work because the module
alias information is not filled so user-space can't match the registered
device with the corresponding module.

Export the module alias information using the MODULE_DEVICE_TABLE() macro.

Before this patch:

$ modinfo drivers/rtc/rtc-asm9260.ko | grep alias
$

After this patch:

$ modinfo drivers/rtc/rtc-asm9260.ko | grep alias
alias:          of:N*T*Calphascale,asm9260-rtcC*
alias:          of:N*T*Calphascale,asm9260-rtc

Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
---

 drivers/rtc/rtc-asm9260.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/rtc/rtc-asm9260.c b/drivers/rtc/rtc-asm9260.c
index 18a93d3e3f93..d36534965635 100644
--- a/drivers/rtc/rtc-asm9260.c
+++ b/drivers/rtc/rtc-asm9260.c
@@ -327,6 +327,7 @@ static const struct of_device_id asm9260_dt_ids[] = {
 	{ .compatible = "alphascale,asm9260-rtc", },
 	{}
 };
+MODULE_DEVICE_TABLE(of, asm9260_dt_ids);
 
 static struct platform_driver asm9260_rtc_driver = {
 	.probe		= asm9260_rtc_probe,
-- 
2.7.4

[toc] | [next] | [standalone]

#1503585

On 14/10/2016 at 10:15:35 -0300, Javier Martinez Canillas wrote :
> If the driver is built as a module, autoload won't work because the module
> alias information is not filled so user-space can't match the registered
> device with the corresponding module.
> 
> Export the module alias information using the MODULE_DEVICE_TABLE() macro.
> 
> Before this patch:
> 
> $ modinfo drivers/rtc/rtc-asm9260.ko | grep alias
> $
> 
> After this patch:
> 
> $ modinfo drivers/rtc/rtc-asm9260.ko | grep alias
> alias:          of:N*T*Calphascale,asm9260-rtcC*
> alias:          of:N*T*Calphascale,asm9260-rtc
> 
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
> ---
> 
>  drivers/rtc/rtc-asm9260.c | 1 +
>  1 file changed, 1 insertion(+)
> 
Applied, thanks.

-- 
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web