Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1501427 > unrolled thread
| Started by | Peter Rosin <peda@lysator.liu.se> |
|---|---|
| First post | 2016-10-16 13:10 +0200 |
| Last post | 2016-10-16 19:20 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH] ARM: at91/dt: pullup dbgu rx instead of tx Peter Rosin <peda@lysator.liu.se> - 2016-10-16 13:10 +0200
Re: [PATCH] ARM: at91/dt: pullup dbgu rx instead of tx Sylvain Rochet <sylvain.rochet@finsecur.com> - 2016-10-16 19:20 +0200
| From | Peter Rosin <peda@lysator.liu.se> |
|---|---|
| Date | 2016-10-16 13:10 +0200 |
| Subject | Re: [PATCH] ARM: at91/dt: pullup dbgu rx instead of tx |
| Message-ID | <ssRui-531-19@gated-at.bofh.it> |
Hi again,
I forgot about this, and it's been a year. But isn't it time to
upstream those pull-up fixes that Sylvain provided?
Cheers,
Peter
On 2015-09-24 16:47, Alexandre Belloni wrote:
> Hi Peter,
>
> Thanks for the patch but you actually got beaten by Sylvain:
> http://lists.infradead.org/pipermail/linux-arm-kernel/2015-September/368426.html
>
> On 24/09/2015 at 16:44:15 +0200, Peter Rosin wrote :
>> From: Peter Rosin <peda@axentia.se>
>>
>> It seems pointless to pullup the tx line, but there is value in pulling
>> up the rx line.
>>
>> Cc: stable@vger.kernel.org
>> Signed-off-by: Peter Rosin <peda@axentia.se>
>> ---
>> arch/arm/boot/dts/sama5d3.dtsi | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/sama5d3.dtsi b/arch/arm/boot/dts/sama5d3.dtsi
>> index 9e2444b07bce..304a40c5552a 100644
>> --- a/arch/arm/boot/dts/sama5d3.dtsi
>> +++ b/arch/arm/boot/dts/sama5d3.dtsi
>> @@ -545,8 +545,8 @@
>> dbgu {
>> pinctrl_dbgu: dbgu-0 {
>> atmel,pins =
>> - <AT91_PIOB 30 AT91_PERIPH_A AT91_PINCTRL_NONE /* PB30 periph A */
>> - AT91_PIOB 31 AT91_PERIPH_A AT91_PINCTRL_PULL_UP>; /* PB31 periph A with pullup */
>> + <AT91_PIOB 30 AT91_PERIPH_A AT91_PINCTRL_PULL_UP /* PB30 periph A with pullup */
>> + AT91_PIOB 31 AT91_PERIPH_A AT91_PINCTRL_NONE>; /* PB31 periph A */
>> };
>> };
>>
>> --
>> 1.7.10.4
>>
>
[toc] | [next] | [standalone]
| From | Sylvain Rochet <sylvain.rochet@finsecur.com> |
|---|---|
| Date | 2016-10-16 19:20 +0200 |
| Message-ID | <ssXgl-h3-7@gated-at.bofh.it> |
| In reply to | #1501427 |
Hi Peter, On Sun, Oct 16, 2016 at 12:57:09PM +0200, Peter Rosin wrote: > Hi again, > > I forgot about this, and it's been a year. But isn't it time to > upstream those pull-up fixes that Sylvain provided? Thank you for your reminder, actually I waited an answer on this nice subject: http://lists.infradead.org/pipermail/linux-arm-kernel/2015-September/368643.html But this is not relevant for this change anyway, if we should set a pull-(up|down) on all push-pull pads to reduce power consumption it should be enforced in the pinctrl driver, the dt must stay logical. I just sent a v2 with all useless comments removed as suggested by Alexandre and without the explanation about the removed extra power consumption when removing a pull-(up|down) on a push-pull output because it does even seem to be the contrary on Atmel SoCs. Sylvain
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web