Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1497555 > unrolled thread

[PATCH] arm64: defconfig: enable EEPROM_AT25 config option

Started byScott Branden <scott.branden@broadcom.com>
First post2016-10-07 23:30 +0200
Last post2016-10-12 00:40 +0200
Articles 4 — 3 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH] arm64: defconfig: enable EEPROM_AT25 config option Scott Branden <scott.branden@broadcom.com> - 2016-10-07 23:30 +0200
    Re: [PATCH] arm64: defconfig: enable EEPROM_AT25 config option Florian Fainelli <f.fainelli@gmail.com> - 2016-10-10 11:10 +0200
      Re: [PATCH] arm64: defconfig: enable EEPROM_AT25 config option Arnd Bergmann <arnd@arndb.de> - 2016-10-10 11:30 +0200
        Re: [PATCH] arm64: defconfig: enable EEPROM_AT25 config option Scott Branden <scott.branden@broadcom.com> - 2016-10-12 00:40 +0200

#1497555 — [PATCH] arm64: defconfig: enable EEPROM_AT25 config option

FromScott Branden <scott.branden@broadcom.com>
Date2016-10-07 23:30 +0200
Subject[PATCH] arm64: defconfig: enable EEPROM_AT25 config option
Message-ID<spKSl-6de-3@gated-at.bofh.it>
Enable support for on board SPI EEPROM by turning on
CONFIG_EEPROM_AT25.

Signed-off-by: Scott Branden <scott.branden@broadcom.com>
---
 arch/arm64/configs/defconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index eadf485..9955ee1 100644
--- a/arch/arm64/configs/defconfig
+++ b/arch/arm64/configs/defconfig
@@ -136,6 +136,7 @@ CONFIG_MTD_SPI_NOR=y
 CONFIG_BLK_DEV_LOOP=y
 CONFIG_BLK_DEV_NBD=m
 CONFIG_VIRTIO_BLK=y
+CONFIG_EEPROM_AT25=y
 CONFIG_SRAM=y
 # CONFIG_SCSI_PROC_FS is not set
 CONFIG_BLK_DEV_SD=y
-- 
2.5.0

[toc] | [next] | [standalone]


#1498183

FromFlorian Fainelli <f.fainelli@gmail.com>
Date2016-10-10 11:10 +0200
Message-ID<sqEKR-7N2-3@gated-at.bofh.it>
In reply to#1497555

On 10/07/2016 02:23 PM, Scott Branden wrote:
> Enable support for on board SPI EEPROM by turning on
> CONFIG_EEPROM_AT25.
> 
> Signed-off-by: Scott Branden <scott.branden@broadcom.com>

Looks fine to me, unless this needs to be a module, Arnd, what do you think?

> ---
>  arch/arm64/configs/defconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> index eadf485..9955ee1 100644
> --- a/arch/arm64/configs/defconfig
> +++ b/arch/arm64/configs/defconfig
> @@ -136,6 +136,7 @@ CONFIG_MTD_SPI_NOR=y
>  CONFIG_BLK_DEV_LOOP=y
>  CONFIG_BLK_DEV_NBD=m
>  CONFIG_VIRTIO_BLK=y
> +CONFIG_EEPROM_AT25=y
>  CONFIG_SRAM=y
>  # CONFIG_SCSI_PROC_FS is not set
>  CONFIG_BLK_DEV_SD=y
> 

-- 
Florian

[toc] | [prev] | [next] | [standalone]


#1498194

FromArnd Bergmann <arnd@arndb.de>
Date2016-10-10 11:30 +0200
Message-ID<sqF4e-7T9-13@gated-at.bofh.it>
In reply to#1498183
On Monday, October 10, 2016 2:08:05 AM CEST Florian Fainelli wrote:
> On 10/07/2016 02:23 PM, Scott Branden wrote:
> > Enable support for on board SPI EEPROM by turning on
> > CONFIG_EEPROM_AT25.
> > 
> > Signed-off-by: Scott Branden <scott.branden@broadcom.com>
> 
> Looks fine to me, unless this needs to be a module, Arnd, what do you think?

Please either make it a module or explain in the patch description
why it should be built-in.

	Arnd

[toc] | [prev] | [next] | [standalone]


#1499277

FromScott Branden <scott.branden@broadcom.com>
Date2016-10-12 00:40 +0200
Message-ID<srdSh-47Y-9@gated-at.bofh.it>
In reply to#1498194
Hi Arnd,

On 16-10-10 02:20 AM, Arnd Bergmann wrote:
> On Monday, October 10, 2016 2:08:05 AM CEST Florian Fainelli wrote:
>> On 10/07/2016 02:23 PM, Scott Branden wrote:
>>> Enable support for on board SPI EEPROM by turning on
>>> CONFIG_EEPROM_AT25.
>>>
>>> Signed-off-by: Scott Branden <scott.branden@broadcom.com>
>>
>> Looks fine to me, unless this needs to be a module, Arnd, what do you think?
>
> Please either make it a module or explain in the patch description
> why it should be built-in.

We use a fixed rootfs image to test the kernel.  For simplicity we don't 
construct a rootfs or load any modules.  We just test the kernel image. 
So for us every defconfig we use needs to be set to y to use the 
upstreamed kernel.

>
> 	Arnd
>

Regards,
  Scott

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web