Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1500539 > unrolled thread

[PATCH v2] Staging:ks7010:eap_packet: fixed 80 character line limit coding style issue

Back to article view | Back to linux.kernel

Contents

  [PATCH v2] Staging:ks7010:eap_packet: fixed 80 character line limit  coding style issue Nadim Almas <nadim.902@gmail.com> - 2016-10-13 22:20 +0200
    Re: [PATCH v2] Staging:ks7010:eap_packet: fixed 80 character line  limit coding style issue Greg KH <gregkh@linuxfoundation.org> - 2016-10-14 08:50 +0200
      Re: [PATCH v2] Staging:ks7010:eap_packet: fixed 80 character line  limit coding style issue Greg KH <gregkh@linuxfoundation.org> - 2016-10-15 13:40 +0200

#1500539 — [PATCH v2] Staging:ks7010:eap_packet: fixed 80 character line limit coding style issue

	Fixed coding style issue

Signed-off-by: Nadim Almas <nadim.902@gmail.com>
---
Changes in v2:
  -Comment is taken from below line.

 drivers/staging/ks7010/eap_packet.h | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/ks7010/eap_packet.h b/drivers/staging/ks7010/eap_packet.h
index df7f760..90432ff 100644
--- a/drivers/staging/ks7010/eap_packet.h
+++ b/drivers/staging/ks7010/eap_packet.h
@@ -58,11 +58,13 @@ struct ieee802_1x_eapol_key {
 	 * encrypt the Key field; 64-bit NTP timestamp MAY be used here
 	 */
 	unsigned char replay_counter[IEEE8021X_REPLAY_COUNTER_LEN];
-	unsigned char key_iv[IEEE8021X_KEY_IV_LEN];	/* cryptographically random number */
+	unsigned char key_iv[IEEE8021X_KEY_IV_LEN];
+			/* cryptographically random number */
 	unsigned char key_index;	/*
 					 * key flag in the most significant bit:
 					 * 0 = broadcast (default key),
-					 * 1 = unicast (key mapping key); key index is in the
+					 * 1 = unicast (key mapping key); key
+					 * index is in the
 					 * 7 least significant bits
 					 */
 	/*
--
2.7.4

[toc] | [next] | [standalone]

#1500716 — Re: [PATCH v2] Staging:ks7010:eap_packet: fixed 80 character line limit coding style issue

On Fri, Oct 14, 2016 at 01:25:17AM +0530, Nadim Almas wrote:
> 	Fixed coding style issue

Why the indentation?

> 
> Signed-off-by: Nadim Almas <nadim.902@gmail.com>
> ---
> Changes in v2:
>   -Comment is taken from below line.

Huh?

> 
>  drivers/staging/ks7010/eap_packet.h | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/ks7010/eap_packet.h b/drivers/staging/ks7010/eap_packet.h
> index df7f760..90432ff 100644
> --- a/drivers/staging/ks7010/eap_packet.h
> +++ b/drivers/staging/ks7010/eap_packet.h
> @@ -58,11 +58,13 @@ struct ieee802_1x_eapol_key {
>  	 * encrypt the Key field; 64-bit NTP timestamp MAY be used here
>  	 */
>  	unsigned char replay_counter[IEEE8021X_REPLAY_COUNTER_LEN];
> -	unsigned char key_iv[IEEE8021X_KEY_IV_LEN];	/* cryptographically random number */
> +	unsigned char key_iv[IEEE8021X_KEY_IV_LEN];
> +			/* cryptographically random number */

Again, you put this below the line, which is not ok at all.  Does this
seem to be the way you would normally read code?

greg k-h

[toc] | [prev] | [next] | [standalone]

#1501274 — Re: [PATCH v2] Staging:ks7010:eap_packet: fixed 80 character line limit coding style issue

On Sat, Oct 15, 2016 at 12:49:31AM +0530, Nadim Almas wrote:
> So please tall me how to do?

I have already done so, but you seem to be ignoring my suggestions for
some reason.

Also please do not post with html, the mailing lists reject it.

I recommend going and learning C better and getting experience on other
projects before working on kernel code.

best of luck!

greg k-h

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web