Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1500427 > unrolled thread
| Started by | David Howells <dhowells@redhat.com> |
|---|---|
| First post | 2016-10-13 18:30 +0200 |
| Last post | 2016-10-14 16:50 +0200 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH net-next 0/4] rxrpc: Fixes David Howells <dhowells@redhat.com> - 2016-10-13 18:30 +0200
[PATCH net 3/4] rxrpc: Fix checking of error from ip6_route_output() David Howells <dhowells@redhat.com> - 2016-10-13 18:40 +0200
Re: [PATCH net-next 0/4] rxrpc: Fixes David Miller <davem@davemloft.net> - 2016-10-14 16:50 +0200
| From | David Howells <dhowells@redhat.com> |
|---|---|
| Date | 2016-10-13 18:30 +0200 |
| Subject | [PATCH net-next 0/4] rxrpc: Fixes |
| Message-ID | <srR3j-5Qh-11@gated-at.bofh.it> |
This set of patches contains a bunch of fixes:
(1) Fix use of kunmap() after change from kunmap_atomic() within AFS.
(2) Don't use of ERR_PTR() with an always zero value.
(3) Check the right error when using ip6_route_output().
(4) Be consistent about whether call->operation_ID is BE or CPU-E within
AFS.
The patches can be found here also:
http://git.kernel.org/cgit/linux/kernel/git/dhowells/linux-fs.git/log/?h=rxrpc-rewrite
Tagged thusly:
git://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git
rxrpc-rewrite-20161013
David
---
Dan Carpenter (1):
afs: unmapping the wrong buffer
David Howells (3):
rxrpc: Fix checker warning by not passing always-zero value to ERR_PTR()
rxrpc: Fix checking of error from ip6_route_output()
afs: call->operation_ID sometimes used as __be32 sometimes as u32
fs/afs/cmservice.c | 6 ++----
fs/afs/fsclient.c | 4 ++--
fs/afs/internal.h | 2 +-
fs/afs/rxrpc.c | 3 ++-
net/rxrpc/call_object.c | 2 +-
net/rxrpc/peer_object.c | 4 ++--
6 files changed, 10 insertions(+), 11 deletions(-)
[toc] | [next] | [standalone]
| From | David Howells <dhowells@redhat.com> |
|---|---|
| Date | 2016-10-13 18:40 +0200 |
| Subject | [PATCH net 3/4] rxrpc: Fix checking of error from ip6_route_output() |
| Message-ID | <srRcZ-5TH-21@gated-at.bofh.it> |
| In reply to | #1500427 |
ip6_route_output() doesn't return a negative error when it fails, rather
the ->error field of the returned dst_entry struct needs to be checked.
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Fixes: 75b54cb57ca3 ("rxrpc: Add IPv6 support")
Signed-off-by: David Howells <dhowells@redhat.com>
---
net/rxrpc/peer_object.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/rxrpc/peer_object.c b/net/rxrpc/peer_object.c
index 941b724d523b..862eea6b266c 100644
--- a/net/rxrpc/peer_object.c
+++ b/net/rxrpc/peer_object.c
@@ -193,8 +193,8 @@ static void rxrpc_assess_MTU_size(struct rxrpc_peer *peer)
fl6->fl6_dport = htons(7001);
fl6->fl6_sport = htons(7000);
dst = ip6_route_output(&init_net, NULL, fl6);
- if (IS_ERR(dst)) {
- _leave(" [route err %ld]", PTR_ERR(dst));
+ if (dst->error) {
+ _leave(" [route err %d]", dst->error);
return;
}
break;
[toc] | [prev] | [next] | [standalone]
| From | David Miller <davem@davemloft.net> |
|---|---|
| Date | 2016-10-14 16:50 +0200 |
| Message-ID | <ssbY6-2B4-11@gated-at.bofh.it> |
| In reply to | #1500427 |
From: David Howells <dhowells@redhat.com> Date: Thu, 13 Oct 2016 17:12:09 +0100 > > This set of patches contains a bunch of fixes: > > (1) Fix use of kunmap() after change from kunmap_atomic() within AFS. > > (2) Don't use of ERR_PTR() with an always zero value. > > (3) Check the right error when using ip6_route_output(). > > (4) Be consistent about whether call->operation_ID is BE or CPU-E within > AFS. > > The patches can be found here also: > > http://git.kernel.org/cgit/linux/kernel/git/dhowells/linux-fs.git/log/?h=rxrpc-rewrite > > Tagged thusly: > > git://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git > rxrpc-rewrite-20161013 Pulled, thanks David.
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web