Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1498148 > unrolled thread

[PATCH] iwlwifi: pcie: reduce "unsupported splx" to a warning

Back to article view | Back to linux.kernel

Contents

  [PATCH] iwlwifi: pcie: reduce "unsupported splx" to a warning Chris Rorvick <chris@rorvick.com> - 2016-10-10 09:20 +0200
    Re: [PATCH] iwlwifi: pcie: reduce "unsupported splx" to a warning Luca Coelho <luca@coelho.fi> - 2016-10-10 16:10 +0200
      Re: [PATCH] iwlwifi: pcie: reduce "unsupported splx" to a warning Paul Bolle <pebolle@tiscali.nl> - 2016-10-11 12:20 +0200
        Re: [PATCH] iwlwifi: pcie: reduce "unsupported splx" to a warning Chris Rorvick <chris@rorvick.com> - 2016-10-11 16:20 +0200
          Re: [PATCH] iwlwifi: pcie: reduce "unsupported splx" to a warning Chris Rorvick <chris@rorvick.com> - 2016-10-11 16:30 +0200
          Re: [PATCH] iwlwifi: pcie: reduce "unsupported splx" to a warning Luca Coelho <luca@coelho.fi> - 2016-10-12 09:00 +0200
        Re: [PATCH] iwlwifi: pcie: reduce "unsupported splx" to a warning Chris Rorvick <chris@rorvick.com> - 2016-10-12 06:40 +0200
          Re: [PATCH] iwlwifi: pcie: reduce "unsupported splx" to a warning Luca Coelho <luca@coelho.fi> - 2016-10-12 14:30 +0200
            Re: [PATCH] iwlwifi: pcie: reduce "unsupported splx" to a warning Paul Bolle <pebolle@tiscali.nl> - 2016-10-12 14:50 +0200
              Re: [PATCH] iwlwifi: pcie: reduce "unsupported splx" to a warning Luca Coelho <luca@coelho.fi> - 2016-10-12 15:30 +0200
        Re: [PATCH] iwlwifi: pcie: reduce "unsupported splx" to a warning Luca Coelho <luca@coelho.fi> - 2016-10-12 08:20 +0200
          Re: [PATCH] iwlwifi: pcie: reduce "unsupported splx" to a warning Paul Bolle <pebolle@tiscali.nl> - 2016-10-12 09:00 +0200
            Re: [PATCH] iwlwifi: pcie: reduce "unsupported splx" to a warning Chris Rorvick <chris@rorvick.com> - 2016-10-12 20:00 +0200
              Re: [PATCH] iwlwifi: pcie: reduce "unsupported splx" to a warning Paul Bolle <pebolle@tiscali.nl> - 2016-10-12 20:10 +0200
                Re: [PATCH] iwlwifi: pcie: reduce "unsupported splx" to a warning Chris Rorvick <chris@rorvick.com> - 2016-10-12 20:40 +0200
              Re: [PATCH] iwlwifi: pcie: reduce "unsupported splx" to a warning Luca Coelho <luca@coelho.fi> - 2016-10-13 11:30 +0200
                [PATCH] iwlwifi: pcie: fix SPLC structure parsing Luca Coelho <luca@coelho.fi> - 2016-10-13 12:30 +0200
                  Re: [PATCH] iwlwifi: pcie: fix SPLC structure parsing Paul Bolle <pebolle@tiscali.nl> - 2016-10-13 13:30 +0200
                    Re: [PATCH] iwlwifi: pcie: fix SPLC structure parsing Luca Coelho <luca@coelho.fi> - 2016-10-13 14:00 +0200
                      Re: [PATCH] iwlwifi: pcie: fix SPLC structure parsing Paul Bolle <pebolle@tiscali.nl> - 2016-10-13 14:40 +0200
                        Re: [PATCH] iwlwifi: pcie: fix SPLC structure parsing Luca Coelho <luca@coelho.fi> - 2016-10-13 14:50 +0200
                          Re: [PATCH] iwlwifi: pcie: fix SPLC structure parsing Paul Bolle <pebolle@tiscali.nl> - 2016-10-13 15:00 +0200
                            Re: [PATCH] iwlwifi: pcie: fix SPLC structure parsing Luca Coelho <luca@coelho.fi> - 2016-10-13 20:00 +0200
                    Re: [PATCH] iwlwifi: pcie: fix SPLC structure parsing Chris Rorvick <chris@rorvick.com> - 2016-10-13 16:00 +0200
                      Re: [PATCH] iwlwifi: pcie: fix SPLC structure parsing Luca Coelho <luca@coelho.fi> - 2016-10-13 17:00 +0200

Page 2 of 2 — ← Prev page 1 [2]

#1500248 — Re: [PATCH] iwlwifi: pcie: fix SPLC structure parsing

On Thu, 2016-10-13 at 14:36 +0200, Paul Bolle wrote:
> On Thu, 2016-10-13 at 14:30 +0300, Luca Coelho wrote:
> > I forgot to say... could you load the iwlwifi module with debug=0x01
> > (module parameter), so we can see the messages the driver is printing
> > when it doesn't find a proper structure?
> 
> 
> That makes a lot of noise! Here's the first 100 lines or so, that
> apparently are generated directly after modprobing iwlwifi.
> 
> After these 100 lines there's a ten second gap (I guess it took me ten
> seconds to actually use the wifi). I assume you don't care about that
> part of the debug messages.
> 
> Have fun!

Thanks, Paul!

Yeah, this is the "INFO" debugging level and it is a sort of fallback
bucket when there is nothing more specific.  Sorry for that.


> <7>[  767.691342] iwlwifi 0000:3a:00.0: U iwl_pcie_prepare_card_hw iwl_trans_prepare_card_hw enter
> <7>[  767.691362] iwlwifi 0000:3a:00.0: U iwl_pcie_set_hw_ready hardware ready
> <7>[  767.692127] iwlwifi 0000:3a:00.0: U iwl_request_firmware attempting to load firmware 'iwlwifi-8000C-24.ucode'
> <7>[  767.692322] iwlwifi 0000:3a:00.0: U splc_get_pwr_limit No element for the WiFi domain returned by the SPLC method.

This is the line I was looking for. :) So everything looks fine now.
 Even though there is apparently something wrong with this part of the
ACPI table on you laptop, since it doesn't match our specifications.
 In any case, it's mostly harmless.

Thanks for the help!

--
Cheers,
Luca.

[toc] | [prev] | [next] | [standalone]

#1500256 — Re: [PATCH] iwlwifi: pcie: fix SPLC structure parsing

On Thu, 2016-10-13 at 15:44 +0300, Luca Coelho wrote:
>  Even though there is apparently something wrong with this part of the
> ACPI table on you laptop, since it doesn't match our specifications.
>  In any case, it's mostly harmless.

Would a correct implementation by Dell have any benefits for the users
of these laptops? In other words: should I bother somehow contacting
Dell and point them to this discussion in order to have them fix this?


Paul Bolle

[toc] | [prev] | [next] | [standalone]

#1500481 — Re: [PATCH] iwlwifi: pcie: fix SPLC structure parsing

On Thu, 2016-10-13 at 14:55 +0200, Paul Bolle wrote:
> On Thu, 2016-10-13 at 15:44 +0300, Luca Coelho wrote:
> >  Even though there is apparently something wrong with this part of the
> > ACPI table on you laptop, since it doesn't match our specifications.
> >  In any case, it's mostly harmless.
> 
> 
> Would a correct implementation by Dell have any benefits for the users
> of these laptops? In other words: should I bother somehow contacting
> Dell and point them to this discussion in order to have them fix this?

This value provides a way for the OEM to fine tune the power budget of
the device.  This is (usually) used to prevent parts of the platform
from getting too hot.  We have a certain default that is good enough
for most cases.  If Dell didn't want to set proper limits for this
device, it probably means that it is not a concern.  Dell does set
these values correctly for other platforms.

So, I guess it's up to you if you want to clarify this with them.  This
could be some default "blank" values when they don't want to change
them.

--
Luca.

[toc] | [prev] | [next] | [standalone]

#1500279 — Re: [PATCH] iwlwifi: pcie: fix SPLC structure parsing

Hi Luca,

> On Thu, 2016-10-13 at 13:21 +0300, Luca Coelho wrote:
> Could you please give this a spin? I have tested it with some handmade
> ACPI tables in QEMU and it seems to work fine now.

Tested-by: Chris Rorvick <chris@rorvick.com>

I think the debug output looks as expected, see below for the first 20
lines or so.  And, more importantly, everything seems to be working!
:-)

Thanks!

Chris

==========

iwlwifi 0000:3a:00.0: L1 Enabled - LTR Disabled
iwlwifi: module verification failed: signature and/or required key
missing - tainting kernel
Intel(R) Wireless WiFi driver for Linux
Copyright(c) 2003- 2015 Intel Corporation
iwlwifi 0000:3a:00.0: U iwl_pcie_prepare_card_hw iwl_trans_prepare_card_hw enter
iwlwifi 0000:3a:00.0: U iwl_pcie_set_hw_ready hardware ready
iwlwifi 0000:3a:00.0: U iwl_request_firmware attempting to load
firmware 'iwlwifi-8000C-24.ucode'
iwlwifi 0000:3a:00.0: Direct firmware load for iwlwifi-8000C-24.ucode
failed with error -2
iwlwifi 0000:3a:00.0: U iwl_request_firmware attempting to load
firmware 'iwlwifi-8000C-23.ucode'
iwlwifi 0000:3a:00.0: Direct firmware load for iwlwifi-8000C-23.ucode
failed with error -2
iwlwifi 0000:3a:00.0: U iwl_request_firmware attempting to load
firmware 'iwlwifi-8000C-22.ucode'
iwlwifi 0000:3a:00.0: Direct firmware load for iwlwifi-8000C-22.ucode
failed with error -2
iwlwifi 0000:3a:00.0: U iwl_request_firmware attempting to load
firmware 'iwlwifi-8000C-21.ucode'
iwlwifi 0000:3a:00.0: U iwl_req_fw_callback Loaded firmware file
'iwlwifi-8000C-21.ucode' (2394060 bytes).
iwlwifi 0000:3a:00.0: U iwl_parse_tlv_firmware unknown TLV: 48
iwlwifi 0000:3a:00.0: U iwl_parse_tlv_firmware GSCAN is supported but
capabilities TLV is unavailable
iwlwifi 0000:3a:00.0: U splc_get_pwr_limit No element for the WiFi
domain returned by the SPLC method.
iwlwifi 0000:3a:00.0: U set_dflt_pwr_limit Default power limit set to 0
iwlwifi 0000:3a:00.0: loaded firmware version 21.302800.0 op_mode iwlmvm
iwlwifi 0000:3a:00.0: Detected Intel(R) Dual Band Wireless AC 8260, REV=0x208

[toc] | [prev] | [next] | [standalone]

#1500318 — Re: [PATCH] iwlwifi: pcie: fix SPLC structure parsing

On Thu, 2016-10-13 at 08:56 -0500, Chris Rorvick wrote:
> Hi Luca,
> 
> > On Thu, 2016-10-13 at 13:21 +0300, Luca Coelho wrote:
> > Could you please give this a spin? I have tested it with some handmade
> > ACPI tables in QEMU and it seems to work fine now.
> 
> 
> Tested-by: Chris Rorvick <chris@rorvick.com>
> 
> I think the debug output looks as expected, see below for the first 20
> lines or so.  And, more importantly, everything seems to be working!
> :-)

Yes, you got exactly what was expected.  Thanks for testing!

--
Luca.

[toc] | [prev] | [standalone]

Page 2 of 2 — ← Prev page 1 [2]

Back to top | Article view | linux.kernel

csiph-web