Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1498384 > unrolled thread
| Started by | Ming Lei <tom.leiming@gmail.com> |
|---|---|
| First post | 2016-10-10 17:30 +0200 |
| Last post | 2016-10-12 01:30 +0200 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] SCSI: remove one useless stack variable Ming Lei <tom.leiming@gmail.com> - 2016-10-10 17:30 +0200
Re: [PATCH] SCSI: remove one useless stack variable Christoph Hellwig <hch@lst.de> - 2016-10-10 19:00 +0200
Re: [PATCH] SCSI: remove one useless stack variable "Martin K. Petersen" <martin.petersen@oracle.com> - 2016-10-12 01:30 +0200
| From | Ming Lei <tom.leiming@gmail.com> |
|---|---|
| Date | 2016-10-10 17:30 +0200 |
| Subject | [PATCH] SCSI: remove one useless stack variable |
| Message-ID | <sqKGC-2TG-5@gated-at.bofh.it> |
The local variable of 'devname' in scsi_report_lun_scan()
isn't used any more, so remove it.
Cc: Christoph Hellwig <hch@lst.de>
Signed-off-by: Ming Lei <tom.leiming@gmail.com>
---
drivers/scsi/scsi_scan.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/scsi/scsi_scan.c b/drivers/scsi/scsi_scan.c
index bb9b58e21d95..6f7128f49c30 100644
--- a/drivers/scsi/scsi_scan.c
+++ b/drivers/scsi/scsi_scan.c
@@ -1307,7 +1307,6 @@ static void scsi_sequential_lun_scan(struct scsi_target *starget,
static int scsi_report_lun_scan(struct scsi_target *starget, int bflags,
enum scsi_scan_mode rescan)
{
- char devname[64];
unsigned char scsi_cmd[MAX_COMMAND_SIZE];
unsigned int length;
u64 lun;
@@ -1349,9 +1348,6 @@ static int scsi_report_lun_scan(struct scsi_target *starget, int bflags,
}
}
- sprintf(devname, "host %d channel %d id %d",
- shost->host_no, sdev->channel, sdev->id);
-
/*
* Allocate enough to hold the header (the same size as one scsi_lun)
* plus the number of luns we are requesting. 511 was the default
--
2.7.4
[toc] | [next] | [standalone]
| From | Christoph Hellwig <hch@lst.de> |
|---|---|
| Date | 2016-10-10 19:00 +0200 |
| Message-ID | <sqM5H-3BM-3@gated-at.bofh.it> |
| In reply to | #1498384 |
On Mon, Oct 10, 2016 at 11:25:33PM +0800, Ming Lei wrote: > The local variable of 'devname' in scsi_report_lun_scan() > isn't used any more, so remove it. Looks fine, Reviewed-by: Christoph Hellwig <hch@lst.de>
[toc] | [prev] | [next] | [standalone]
| From | "Martin K. Petersen" <martin.petersen@oracle.com> |
|---|---|
| Date | 2016-10-12 01:30 +0200 |
| Message-ID | <sreEF-4Dp-5@gated-at.bofh.it> |
| In reply to | #1498384 |
>>>>> "Ming" == Ming Lei <tom.leiming@gmail.com> writes: Ming> The local variable of 'devname' in scsi_report_lun_scan() isn't Ming> used any more, so remove it. Applied to 4.9/scsi-fixes. -- Martin K. Petersen Oracle Linux Engineering
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web