Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1490081 > unrolled thread

Re: [PATCH 4.4 000/118] 4.4.22-stable review

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH 4.4 000/118] 4.4.22-stable review Guenter Roeck <linux@roeck-us.net> - 2016-09-23 15:30 +0200
    Re: [PATCH 4.4 000/118] 4.4.22-stable review Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-09-23 17:20 +0200
      Re: [PATCH 4.4 000/118] 4.4.22-stable review Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-09-23 17:40 +0200
        Re: [PATCH 4.4 000/118] 4.4.22-stable review Andrew Donnellan <andrew.donnellan@au1.ibm.com> - 2016-09-28 10:50 +0200
          Re: [PATCH 4.4 000/118] 4.4.22-stable review Mauricio Faria de Oliveira <mauricfo@linux.vnet.ibm.com> - 2016-09-28 15:30 +0200
            Re: [PATCH 4.4 000/118] 4.4.22-stable review Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-10-10 10:50 +0200

#1490081 — Re: [PATCH 4.4 000/118] 4.4.22-stable review

On 09/23/2016 01:08 AM, Greg Kroah-Hartman wrote:
> On Thu, Sep 22, 2016 at 08:01:35PM -0700, Guenter Roeck wrote:
>> e5767a13d7cb ("cxl: use pcibios_free_controller_deferred() when removing vPHBs")
>> 	does not apply to v4.4 nor to v4.7 (and isn't marked stable ???).
>
> I don't understand what you mean here.  It did apply, and it was marked
> for stable inclusion.  It is commit
> 6f38a8b9a45833495dc878c335c5431cd98a16ed in Linus's tree.  Does it break
> the build?
>

drivers/misc/cxl/vphb.c: In function 'cxl_pci_vphb_add':
drivers/misc/cxl/vphb.c:263:9: error: 'pcibios_free_controller_deferred' undeclared

Yes, it does break the build, by calling a function which does not exist in 4.4 or 4.7.

Sorry, the Cc: stable was dropped in the 4.4/4.7 versions, so I didn't see it.
I meant to say "it doesn't build".

You will either have to drop e5767a13d7cb. or you'll also need commit 2dd9c11b9d4
("powerpc/pseries: use pci_host_bridge.release_fn() to kfree(phb)") from upstream.
I didn't check though if that applies (or works) with the older kernels.

Guenter

[toc] | [next] | [standalone]

#1490243

On Fri, Sep 23, 2016 at 06:25:33AM -0700, Guenter Roeck wrote:
> On 09/23/2016 01:08 AM, Greg Kroah-Hartman wrote:
> > On Thu, Sep 22, 2016 at 08:01:35PM -0700, Guenter Roeck wrote:
> > > e5767a13d7cb ("cxl: use pcibios_free_controller_deferred() when removing vPHBs")
> > > 	does not apply to v4.4 nor to v4.7 (and isn't marked stable ???).
> > 
> > I don't understand what you mean here.  It did apply, and it was marked
> > for stable inclusion.  It is commit
> > 6f38a8b9a45833495dc878c335c5431cd98a16ed in Linus's tree.  Does it break
> > the build?
> > 
> 
> drivers/misc/cxl/vphb.c: In function 'cxl_pci_vphb_add':
> drivers/misc/cxl/vphb.c:263:9: error: 'pcibios_free_controller_deferred' undeclared
> 
> Yes, it does break the build, by calling a function which does not exist in 4.4 or 4.7.
> 
> Sorry, the Cc: stable was dropped in the 4.4/4.7 versions, so I didn't see it.
> I meant to say "it doesn't build".
> 
> You will either have to drop e5767a13d7cb. or you'll also need commit 2dd9c11b9d4
> ("powerpc/pseries: use pci_host_bridge.release_fn() to kfree(phb)") from upstream.
> I didn't check though if that applies (or works) with the older kernels.

I'm going to drop it, thanks for pointing this out, I should have caught
it earlier too...

greg k-h

[toc] | [prev] | [next] | [standalone]

#1490272

On Fri, Sep 23, 2016 at 05:11:48PM +0200, Greg Kroah-Hartman wrote:
> On Fri, Sep 23, 2016 at 06:25:33AM -0700, Guenter Roeck wrote:
> > On 09/23/2016 01:08 AM, Greg Kroah-Hartman wrote:
> > > On Thu, Sep 22, 2016 at 08:01:35PM -0700, Guenter Roeck wrote:
> > > > e5767a13d7cb ("cxl: use pcibios_free_controller_deferred() when removing vPHBs")
> > > > 	does not apply to v4.4 nor to v4.7 (and isn't marked stable ???).
> > > 
> > > I don't understand what you mean here.  It did apply, and it was marked
> > > for stable inclusion.  It is commit
> > > 6f38a8b9a45833495dc878c335c5431cd98a16ed in Linus's tree.  Does it break
> > > the build?
> > > 
> > 
> > drivers/misc/cxl/vphb.c: In function 'cxl_pci_vphb_add':
> > drivers/misc/cxl/vphb.c:263:9: error: 'pcibios_free_controller_deferred' undeclared
> > 
> > Yes, it does break the build, by calling a function which does not exist in 4.4 or 4.7.
> > 
> > Sorry, the Cc: stable was dropped in the 4.4/4.7 versions, so I didn't see it.
> > I meant to say "it doesn't build".
> > 
> > You will either have to drop e5767a13d7cb. or you'll also need commit 2dd9c11b9d4
> > ("powerpc/pseries: use pci_host_bridge.release_fn() to kfree(phb)") from upstream.
> > I didn't check though if that applies (or works) with the older kernels.
> 
> I'm going to drop it, thanks for pointing this out, I should have caught
> it earlier too...

Should be removed, hopefully all will build properly...

[toc] | [prev] | [next] | [standalone]

#1492343

On 24/09/16 01:30, Greg Kroah-Hartman wrote:
> On Fri, Sep 23, 2016 at 05:11:48PM +0200, Greg Kroah-Hartman wrote:
>> On Fri, Sep 23, 2016 at 06:25:33AM -0700, Guenter Roeck wrote:
>>> On 09/23/2016 01:08 AM, Greg Kroah-Hartman wrote:
>>>> On Thu, Sep 22, 2016 at 08:01:35PM -0700, Guenter Roeck wrote:
>>>>> e5767a13d7cb ("cxl: use pcibios_free_controller_deferred() when removing vPHBs")
>>>>> 	does not apply to v4.4 nor to v4.7 (and isn't marked stable ???).
>>>>
>>>> I don't understand what you mean here.  It did apply, and it was marked
>>>> for stable inclusion.  It is commit
>>>> 6f38a8b9a45833495dc878c335c5431cd98a16ed in Linus's tree.  Does it break
>>>> the build?
>>>>
>>>
>>> drivers/misc/cxl/vphb.c: In function 'cxl_pci_vphb_add':
>>> drivers/misc/cxl/vphb.c:263:9: error: 'pcibios_free_controller_deferred' undeclared
>>>
>>> Yes, it does break the build, by calling a function which does not exist in 4.4 or 4.7.
>>>
>>> Sorry, the Cc: stable was dropped in the 4.4/4.7 versions, so I didn't see it.
>>> I meant to say "it doesn't build".
>>>
>>> You will either have to drop e5767a13d7cb. or you'll also need commit 2dd9c11b9d4
>>> ("powerpc/pseries: use pci_host_bridge.release_fn() to kfree(phb)") from upstream.
>>> I didn't check though if that applies (or works) with the older kernels.
>>
>> I'm going to drop it, thanks for pointing this out, I should have caught
>> it earlier too...
>
> Should be removed, hopefully all will build properly...
>

It would've been helpful if Mauricio and I were Cc'd on this, but in any 
case I was away for most of last week :)

Looks like I suggested that 2dd9c11b9d4 be Cc: stable on the list but 
that didn't quite make it in to the final commit. Probably didn't help 
that our patches were then applied to powerpc#fixes in the wrong order...

2dd9c11b9d4 applies cleanly on top of 4.4 and works for me in the cxl 
case. Mauricio - any objections from the pseries/dlpar side?


Andrew


-- 
Andrew Donnellan              OzLabs, ADL Canberra
andrew.donnellan@au1.ibm.com  IBM Australia Limited

[toc] | [prev] | [next] | [standalone]

#1492595

On 09/28/2016 05:45 AM, Andrew Donnellan wrote:
> 2dd9c11b9d4 applies cleanly on top of 4.4 and works for me in the cxl
> case. Mauricio - any objections from the pseries/dlpar side?

No objections.


-- 
Mauricio Faria de Oliveira
IBM Linux Technology Center

[toc] | [prev] | [next] | [standalone]

#1498172

On Wed, Sep 28, 2016 at 10:29:23AM -0300, Mauricio Faria de Oliveira wrote:
> On 09/28/2016 05:45 AM, Andrew Donnellan wrote:
> > 2dd9c11b9d4 applies cleanly on top of 4.4 and works for me in the cxl
> > case. Mauricio - any objections from the pseries/dlpar side?
> 
> No objections.

Thanks, have queued them up now.

greg k-h

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web