Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1496695 > unrolled thread
| Started by | Javier Martinez Canillas <javier@osg.samsung.com> |
|---|---|
| First post | 2016-10-06 17:10 +0200 |
| Last post | 2016-10-07 03:10 +0200 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] clk: max77686: fix number of clocks setup for clk_hw based registration Javier Martinez Canillas <javier@osg.samsung.com> - 2016-10-06 17:10 +0200
Re: [PATCH] clk: max77686: fix number of clocks setup for clk_hw based registration Krzysztof Kozlowski <krzk@kernel.org> - 2016-10-06 19:30 +0200
Re: [PATCH] clk: max77686: fix number of clocks setup for clk_hw based registration Chanwoo Choi <cw00.choi@samsung.com> - 2016-10-07 03:10 +0200
| From | Javier Martinez Canillas <javier@osg.samsung.com> |
|---|---|
| Date | 2016-10-06 17:10 +0200 |
| Subject | [PATCH] clk: max77686: fix number of clocks setup for clk_hw based registration |
| Message-ID | <spit4-1Pe-21@gated-at.bofh.it> |
The commit 9b4cac33adc7 ("clk: max77686: Migrate to clk_hw based OF and
registration APIs") converted the driver to use the new provider API to
register clocks using clk_hw.
But unfortunately, in the conversion it missed to set the num_clks value
which lead to the following error when trying to register a clk provider:
[ 1.963782] of_clk_max77686_get: invalid index 0
[ 1.967460] ERROR: could not get clock /rtc@10070000:rtc_src(1)
[ 1.973638] s3c-rtc 10070000.rtc: failed to find rtc source clock
Fix it by correctly set the max77686_clk_driver_data num_clks member.
Fixes: 9b4cac33adc7 ("clk: max77686: Migrate to clk_hw based OF and registration APIs")
Reported-by: Markus Reichl <m.reichl@fivetechno.de>
Suggested-by: Tobias Jakobi <tjakobi@math.uni-bielefeld.de>
Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
Tested-by: Markus Reichl <m.reichl@fivetechno.de>
---
drivers/clk/clk-max77686.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/clk/clk-max77686.c b/drivers/clk/clk-max77686.c
index b637f5979023..eb953d3b0b69 100644
--- a/drivers/clk/clk-max77686.c
+++ b/drivers/clk/clk-max77686.c
@@ -216,6 +216,7 @@ static int max77686_clk_probe(struct platform_device *pdev)
return -EINVAL;
}
+ drv_data->num_clks = num_clks;
drv_data->max_clk_data = devm_kcalloc(dev, num_clks,
sizeof(*drv_data->max_clk_data),
GFP_KERNEL);
--
2.7.4
[toc] | [next] | [standalone]
| From | Krzysztof Kozlowski <krzk@kernel.org> |
|---|---|
| Date | 2016-10-06 19:30 +0200 |
| Subject | Re: [PATCH] clk: max77686: fix number of clocks setup for clk_hw based registration |
| Message-ID | <spkEy-3Bo-25@gated-at.bofh.it> |
| In reply to | #1496695 |
On Thu, Oct 06, 2016 at 11:59:59AM -0300, Javier Martinez Canillas wrote:
> The commit 9b4cac33adc7 ("clk: max77686: Migrate to clk_hw based OF and
> registration APIs") converted the driver to use the new provider API to
> register clocks using clk_hw.
>
> But unfortunately, in the conversion it missed to set the num_clks value
> which lead to the following error when trying to register a clk provider:
>
> [ 1.963782] of_clk_max77686_get: invalid index 0
> [ 1.967460] ERROR: could not get clock /rtc@10070000:rtc_src(1)
> [ 1.973638] s3c-rtc 10070000.rtc: failed to find rtc source clock
>
> Fix it by correctly set the max77686_clk_driver_data num_clks member.
>
> Fixes: 9b4cac33adc7 ("clk: max77686: Migrate to clk_hw based OF and registration APIs")
> Reported-by: Markus Reichl <m.reichl@fivetechno.de>
> Suggested-by: Tobias Jakobi <tjakobi@math.uni-bielefeld.de>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
> Tested-by: Markus Reichl <m.reichl@fivetechno.de>
>
> ---
>
> drivers/clk/clk-max77686.c | 1 +
> 1 file changed, 1 insertion(+)
Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
Best regards,
Krzysztof
[toc] | [prev] | [next] | [standalone]
| From | Chanwoo Choi <cw00.choi@samsung.com> |
|---|---|
| Date | 2016-10-07 03:10 +0200 |
| Subject | Re: [PATCH] clk: max77686: fix number of clocks setup for clk_hw based registration |
| Message-ID | <sprPH-Dr-1@gated-at.bofh.it> |
| In reply to | #1496695 |
Hi Javier,
On 2016년 10월 06일 23:59, Javier Martinez Canillas wrote:
> The commit 9b4cac33adc7 ("clk: max77686: Migrate to clk_hw based OF and
> registration APIs") converted the driver to use the new provider API to
> register clocks using clk_hw.
>
> But unfortunately, in the conversion it missed to set the num_clks value
> which lead to the following error when trying to register a clk provider:
>
> [ 1.963782] of_clk_max77686_get: invalid index 0
> [ 1.967460] ERROR: could not get clock /rtc@10070000:rtc_src(1)
> [ 1.973638] s3c-rtc 10070000.rtc: failed to find rtc source clock
>
> Fix it by correctly set the max77686_clk_driver_data num_clks member.
>
> Fixes: 9b4cac33adc7 ("clk: max77686: Migrate to clk_hw based OF and registration APIs")
> Reported-by: Markus Reichl <m.reichl@fivetechno.de>
> Suggested-by: Tobias Jakobi <tjakobi@math.uni-bielefeld.de>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
> Tested-by: Markus Reichl <m.reichl@fivetechno.de>
>
> ---
>
> drivers/clk/clk-max77686.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/clk/clk-max77686.c b/drivers/clk/clk-max77686.c
> index b637f5979023..eb953d3b0b69 100644
> --- a/drivers/clk/clk-max77686.c
> +++ b/drivers/clk/clk-max77686.c
> @@ -216,6 +216,7 @@ static int max77686_clk_probe(struct platform_device *pdev)
> return -EINVAL;
> }
>
> + drv_data->num_clks = num_clks;
> drv_data->max_clk_data = devm_kcalloc(dev, num_clks,
> sizeof(*drv_data->max_clk_data),
> GFP_KERNEL);
>
Looks good to me.
Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>
--
Best Regards,
Chanwoo Choi
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web