Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1496797 > unrolled thread
| Started by | Colin King <colin.king@canonical.com> |
|---|---|
| First post | 2016-10-06 20:30 +0200 |
| Last post | 2016-10-06 20:30 +0200 |
| Articles | 1 — 1 participant |
Back to article view | Back to linux.kernel
[PATCH] scsi: fcoe: fix off-by-one array size comparison Colin King <colin.king@canonical.com> - 2016-10-06 20:30 +0200
| From | Colin King <colin.king@canonical.com> |
|---|---|
| Date | 2016-10-06 20:30 +0200 |
| Subject | [PATCH] scsi: fcoe: fix off-by-one array size comparison |
| Message-ID | <splAB-4sH-7@gated-at.bofh.it> |
From: Colin Ian King <colin.king@canonical.com>
Fix an off-by-one array size comparison that is comparing one too many
items in an array and hence will causing an out-of-bounds array read
on array fcoe_port_speed_mapping.
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/scsi/fcoe/fcoe_transport.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/fcoe/fcoe_transport.c b/drivers/scsi/fcoe/fcoe_transport.c
index c164eec..375c536 100644
--- a/drivers/scsi/fcoe/fcoe_transport.c
+++ b/drivers/scsi/fcoe/fcoe_transport.c
@@ -110,7 +110,7 @@ static inline u32 eth2fc_speed(u32 eth_port_speed)
{
int i;
- for (i = 0; i <= ARRAY_SIZE(fcoe_port_speed_mapping); i++) {
+ for (i = 0; i < ARRAY_SIZE(fcoe_port_speed_mapping); i++) {
if (fcoe_port_speed_mapping[i].eth_port_speed == eth_port_speed)
return fcoe_port_speed_mapping[i].fc_port_speed;
}
--
2.9.3
Back to top | Article view | linux.kernel
csiph-web