Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1496179 > unrolled thread
| Started by | John Stultz <john.stultz@linaro.org> |
|---|---|
| First post | 2016-10-06 08:40 +0200 |
| Last post | 2016-10-06 20:30 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[REGRESSION] "dwc2: gadget: fix TX FIFO size and address initialization" breaks "adb logcat" on hikey John Stultz <john.stultz@linaro.org> - 2016-10-06 08:40 +0200
Re: [REGRESSION] "dwc2: gadget: fix TX FIFO size and address initialization" breaks "adb logcat" on hikey John Youn <John.Youn@synopsys.com> - 2016-10-06 20:30 +0200
| From | John Stultz <john.stultz@linaro.org> |
|---|---|
| Date | 2016-10-06 08:40 +0200 |
| Subject | [REGRESSION] "dwc2: gadget: fix TX FIFO size and address initialization" breaks "adb logcat" on hikey |
| Message-ID | <spavw-4OT-9@gated-at.bofh.it> |
Hey folks,
So I've run into some trouble that I've narrowed down to commit
aa381a7259c3 ("usb: dwc2: gadget: fix TX FIFO size and address
initialization").
After booting up android on HiKey, if I run "adb logcat", I get about
a page of logs and then I get disconnected. On the device side, I see
the following in dmesg:
[ 35.652076] dwc2 f72c0000.usb: dwc2_hsotg_ep_sethalt(ep
ffffffc078a4c218 ep1in, 0)
[ 35.660334] dwc2 f72c0000.usb: dwc2_hsotg_ep_sethalt(ep
ffffffc078a4c018 ep1out, 0)
After which if I stop adbd I see:
[ 99.471363] dwc2 f72c0000.usb: dwc2_hsotg_ep_stop_xfr: timeout flushing fifos
and if I then restart adbd on the device it will sometimes work, but not always.
Reverting
ba48eab8866c ("usb: dwc2: gadget: change variable name to more meaningful")
and
aa381a7259c3 ("usb: dwc2: gadget: fix TX FIFO size and address initialization")
makes things work again.
Any thoughts as to what might be going wrong here? I'd be happy to
help debug things.
thanks
-john
[toc] | [next] | [standalone]
| From | John Youn <John.Youn@synopsys.com> |
|---|---|
| Date | 2016-10-06 20:30 +0200 |
| Message-ID | <splAB-4sH-3@gated-at.bofh.it> |
| In reply to | #1496179 |
On 10/5/2016 11:33 PM, John Stultz wrote:
> Hey folks,
> So I've run into some trouble that I've narrowed down to commit
> aa381a7259c3 ("usb: dwc2: gadget: fix TX FIFO size and address
> initialization").
>
> After booting up android on HiKey, if I run "adb logcat", I get about
> a page of logs and then I get disconnected. On the device side, I see
> the following in dmesg:
>
> [ 35.652076] dwc2 f72c0000.usb: dwc2_hsotg_ep_sethalt(ep
> ffffffc078a4c218 ep1in, 0)
> [ 35.660334] dwc2 f72c0000.usb: dwc2_hsotg_ep_sethalt(ep
> ffffffc078a4c018 ep1out, 0)
>
> After which if I stop adbd I see:
>
> [ 99.471363] dwc2 f72c0000.usb: dwc2_hsotg_ep_stop_xfr: timeout flushing fifos
>
> and if I then restart adbd on the device it will sometimes work, but not always.
>
> Reverting
> ba48eab8866c ("usb: dwc2: gadget: change variable name to more meaningful")
> and
> aa381a7259c3 ("usb: dwc2: gadget: fix TX FIFO size and address initialization")
>
> makes things work again.
>
> Any thoughts as to what might be going wrong here? I'd be happy to
> help debug things.
>
> thanks
> -john
>
Hi John,
Yup. I've already submitted patches to revert these last week, to be
applied sometime during the 4.9-rc cycle. We're working on a more
robust fix for the FIFOs too.
Regards,
John
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web