Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1497526 > unrolled thread

[PATCH v2 1/2] Staging:greybus:arche-apb-ctrl: fix trailing */ Block comments and 80 character line limit coding style issue

Started byNadim Almas <nadim.902@gmail.com>
First post2016-10-07 23:10 +0200
Last post2016-10-09 16:20 +0200
Articles 2 — 2 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH v2 1/2] Staging:greybus:arche-apb-ctrl: fix trailing */ Block  comments and 80 character line limit coding style issue Nadim Almas <nadim.902@gmail.com> - 2016-10-07 23:10 +0200
    Re: [PATCH v2 1/2] Staging:greybus:arche-apb-ctrl: fix trailing */  Block comments and 80 character line limit coding style issue Greg KH <gregkh@linuxfoundation.org> - 2016-10-09 16:20 +0200

#1497526 — [PATCH v2 1/2] Staging:greybus:arche-apb-ctrl: fix trailing */ Block comments and 80 character line limit coding style issue

FromNadim Almas <nadim.902@gmail.com>
Date2016-10-07 23:10 +0200
Subject[PATCH v2 1/2] Staging:greybus:arche-apb-ctrl: fix trailing */ Block comments and 80 character line limit coding style issue
Message-ID<spKyZ-65z-7@gated-at.bofh.it>
Fixed coding style issue

Signed-off-by: Nadim Almas <nadim.902@gmail.com>
---
Changes in v2:
  - Used space after leading * in block comments.

 drivers/staging/greybus/arche-apb-ctrl.c | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/greybus/arche-apb-ctrl.c b/drivers/staging/greybus/arche-apb-ctrl.c
index 70323aa..eeba912 100644
--- a/drivers/staging/greybus/arche-apb-ctrl.c
+++ b/drivers/staging/greybus/arche-apb-ctrl.c
@@ -168,7 +168,10 @@ static int standby_boot_seq(struct platform_device *pdev)
 	if (apb->init_disabled)
 		return 0;
 
-	/* Even if it is in OFF state, then we do not want to change the state */
+	/*
+	 * Even if it is in OFF state,
+	 * then we do not want to change the state
+	 */
 	if (apb->state == ARCHE_PLATFORM_STATE_STANDBY ||
 			apb->state == ARCHE_PLATFORM_STATE_OFF)
 		return 0;
@@ -183,7 +186,7 @@ static int standby_boot_seq(struct platform_device *pdev)
 	 * Pasted from WDM spec,
 	 *  - A falling edge on POWEROFF_L is detected (a)
 	 *  - WDM enters standby mode, but no output signals are changed
-	 * */
+	 */
 
 	/* TODO: POWEROFF_L is input to WDM module  */
 	apb->state = ARCHE_PLATFORM_STATE_STANDBY;
@@ -286,7 +289,8 @@ static ssize_t state_store(struct device *dev,
 			return count;
 
 		/* First we want to make sure we power off everything
-		 * and then enter FW flashing state */
+		 * and then enter FW flashing state
+		 */
 		poweroff_seq(pdev);
 		ret = fw_flashing_seq(pdev);
 	} else {
-- 
2.7.4

[toc] | [next] | [standalone]


#1497906 — Re: [PATCH v2 1/2] Staging:greybus:arche-apb-ctrl: fix trailing */ Block comments and 80 character line limit coding style issue

FromGreg KH <gregkh@linuxfoundation.org>
Date2016-10-09 16:20 +0200
SubjectRe: [PATCH v2 1/2] Staging:greybus:arche-apb-ctrl: fix trailing */ Block comments and 80 character line limit coding style issue
Message-ID<sqn7j-5hX-5@gated-at.bofh.it>
In reply to#1497526
On Fri, Oct 07, 2016 at 02:05:13PM -0700, Nadim Almas wrote:
> Fixed coding style issue

Your subject is huge, please don't make it so long.

thanks,

greg k-h

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web