Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1495369 > unrolled thread

[PATCH] net: axienet: Add missing \n to end of dev_err messages

Started byColin King <colin.king@canonical.com>
First post2016-10-04 13:20 +0200
Last post2016-10-07 02:50 +0200
Articles 2 — 2 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH] net: axienet: Add missing \n to end of dev_err messages Colin King <colin.king@canonical.com> - 2016-10-04 13:20 +0200
    Re: [PATCH] net: axienet: Add missing \n to end of dev_err messages David Miller <davem@davemloft.net> - 2016-10-07 02:50 +0200

#1495369 — [PATCH] net: axienet: Add missing \n to end of dev_err messages

FromColin King <colin.king@canonical.com>
Date2016-10-04 13:20 +0200
Subject[PATCH] net: axienet: Add missing \n to end of dev_err messages
Message-ID<sovVo-1WQ-17@gated-at.bofh.it>
From: Colin Ian King <colin.king@canonical.com>

Trival fix, dev_err messages are missing a \n, so add it.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/net/ethernet/xilinx/xilinx_axienet_main.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
index 69e2a83..35f9f97 100644
--- a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
+++ b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
@@ -818,7 +818,7 @@ static irqreturn_t axienet_tx_irq(int irq, void *_ndev)
 		goto out;
 	}
 	if (!(status & XAXIDMA_IRQ_ALL_MASK))
-		dev_err(&ndev->dev, "No interrupts asserted in Tx path");
+		dev_err(&ndev->dev, "No interrupts asserted in Tx path\n");
 	if (status & XAXIDMA_IRQ_ERROR_MASK) {
 		dev_err(&ndev->dev, "DMA Tx error 0x%x\n", status);
 		dev_err(&ndev->dev, "Current BD is at: 0x%x\n",
@@ -867,7 +867,7 @@ static irqreturn_t axienet_rx_irq(int irq, void *_ndev)
 		goto out;
 	}
 	if (!(status & XAXIDMA_IRQ_ALL_MASK))
-		dev_err(&ndev->dev, "No interrupts asserted in Rx path");
+		dev_err(&ndev->dev, "No interrupts asserted in Rx path\n");
 	if (status & XAXIDMA_IRQ_ERROR_MASK) {
 		dev_err(&ndev->dev, "DMA Rx error 0x%x\n", status);
 		dev_err(&ndev->dev, "Current BD is at: 0x%x\n",
-- 
2.9.3

[toc] | [next] | [standalone]


#1496953

FromDavid Miller <davem@davemloft.net>
Date2016-10-07 02:50 +0200
Message-ID<sprwl-fG-1@gated-at.bofh.it>
In reply to#1495369
From: Colin King <colin.king@canonical.com>
Date: Tue,  4 Oct 2016 12:11:41 +0100

> From: Colin Ian King <colin.king@canonical.com>
> 
> Trival fix, dev_err messages are missing a \n, so add it.
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Applied.

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web