Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1492625 > unrolled thread
| Started by | Benjamin Tissoires <benjamin.tissoires@redhat.com> |
|---|---|
| First post | 2016-09-28 16:40 +0200 |
| Last post | 2016-10-01 02:00 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH 2/4] Input: elan_i2c - always output the device information Benjamin Tissoires <benjamin.tissoires@redhat.com> - 2016-09-28 16:40 +0200
Re: [PATCH 2/4] Input: elan_i2c - always output the device information Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2016-10-01 02:00 +0200
| From | Benjamin Tissoires <benjamin.tissoires@redhat.com> |
|---|---|
| Date | 2016-09-28 16:40 +0200 |
| Subject | [PATCH 2/4] Input: elan_i2c - always output the device information |
| Message-ID | <smobD-7Vs-9@gated-at.bofh.it> |
it's always easier to retrieve these information in bug reports when it is always printed in the dmesg. Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com> --- drivers/input/mouse/elan_i2c_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/input/mouse/elan_i2c_core.c b/drivers/input/mouse/elan_i2c_core.c index d15b338..2de1f75 100644 --- a/drivers/input/mouse/elan_i2c_core.c +++ b/drivers/input/mouse/elan_i2c_core.c @@ -1093,7 +1093,7 @@ static int elan_probe(struct i2c_client *client, if (error) return error; - dev_dbg(&client->dev, + dev_info(&client->dev, "Elan Touchpad Information:\n" " Module product ID: 0x%04x\n" " Firmware Version: 0x%04x\n" -- 2.7.4
[toc] | [next] | [standalone]
| From | Dmitry Torokhov <dmitry.torokhov@gmail.com> |
|---|---|
| Date | 2016-10-01 02:00 +0200 |
| Subject | Re: [PATCH 2/4] Input: elan_i2c - always output the device information |
| Message-ID | <snfSF-or-5@gated-at.bofh.it> |
| In reply to | #1492625 |
On Wed, Sep 28, 2016 at 04:34:02PM +0200, Benjamin Tissoires wrote: > it's always easier to retrieve these information in bug reports when > it is always printed in the dmesg. > > Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com> > --- > drivers/input/mouse/elan_i2c_core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/input/mouse/elan_i2c_core.c b/drivers/input/mouse/elan_i2c_core.c > index d15b338..2de1f75 100644 > --- a/drivers/input/mouse/elan_i2c_core.c > +++ b/drivers/input/mouse/elan_i2c_core.c > @@ -1093,7 +1093,7 @@ static int elan_probe(struct i2c_client *client, > if (error) > return error; > > - dev_dbg(&client->dev, > + dev_info(&client->dev, > "Elan Touchpad Information:\n" > " Module product ID: 0x%04x\n" > " Firmware Version: 0x%04x\n" The format is acceptable for dev_dbg, but this multi-line output is not too nice for normal logging, especially as we probe the device asynchronously so there can easily be more output from other kernel threads. Thanks. -- Dmitry
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web