Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1493592 > unrolled thread

[PATCH RT 0/2] Warning fixes for 3.2-rt (and other branches)

Back to article view | Back to linux.kernel

Contents

  [PATCH RT 0/2] Warning fixes for 3.2-rt (and other branches) Ben Hutchings <ben@decadent.org.uk> - 2016-09-29 19:00 +0200
    [PATCH RT 1/2] genirq: Fix pointer cast warning for randomness on  32-bit architectures Ben Hutchings <ben@decadent.org.uk> - 2016-09-29 19:10 +0200
    [PATCH RT 2/2] work-simple: Add missing #include <linux/export.h> Ben Hutchings <ben@decadent.org.uk> - 2016-09-30 11:10 +0200

#1493592 — [PATCH RT 0/2] Warning fixes for 3.2-rt (and other branches)

[Multipart message — attachments visible in raw view] — view raw

These patches fix longstanding warnings seen when building 3.2-rt.

Ben.

Ben Hutchings (2):
  genirq: Fix pointer cast warning for randomness on 32-bit
    architectures
  work-simple: Add missing #include <linux/export.h>

 kernel/irq/manage.c  | 3 ++-
 kernel/work-simple.c | 1 +
 2 files changed, 3 insertions(+), 1 deletion(-)

[toc] | [next] | [standalone]

#1493597 — [PATCH RT 1/2] genirq: Fix pointer cast warning for randomness on 32-bit architectures

[Multipart message — attachments visible in raw view] — view raw

gcc warns about casting directly from a 32-bit pointer to u64.  In the
current rt patch series we cast to unsigned long to avoid the warning,
but this fix hasn't been backported to all versions.

Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Cc: <stable-rt@vger.kernel.org> # 3.2
---
 kernel/irq/manage.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/kernel/irq/manage.c b/kernel/irq/manage.c
index c4677795d7c8..b1683ba80c88 100644
--- a/kernel/irq/manage.c
+++ b/kernel/irq/manage.c
@@ -897,7 +897,8 @@ static int irq_thread(void *data)
 #ifdef CONFIG_PREEMPT_RT_FULL
 			migrate_disable();
 			add_interrupt_randomness(action->irq, 0,
-						 desc->random_ip ^ (u64) action);
+						 desc->random_ip ^
+						 (unsigned long) action);
 			migrate_enable();
 #endif
 		}

[toc] | [prev] | [next] | [standalone]

#1493971 — [PATCH RT 2/2] work-simple: Add missing #include <linux/export.h>

[Multipart message — attachments visible in raw view] — view raw

work-simple.c uses EXPORT_SYMBOL_GPL(), defined in <linux/export.h>.

Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Cc: stable-rt@vger.kernel.org # 3.2
---
I'm not sure there's any need for these exports so the correct fix
might be to remove them.

Ben.

 kernel/work-simple.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/kernel/work-simple.c b/kernel/work-simple.c
index c996f755dba6..e57a0522573f 100644
--- a/kernel/work-simple.c
+++ b/kernel/work-simple.c
@@ -10,6 +10,7 @@
 #include <linux/kthread.h>
 #include <linux/slab.h>
 #include <linux/spinlock.h>
+#include <linux/export.h>
 
 #define SWORK_EVENT_PENDING     (1 << 0)
 

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web