Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1492100 > unrolled thread
| Started by | Colin King <colin.king@canonical.com> |
|---|---|
| First post | 2016-09-27 21:00 +0200 |
| Last post | 2016-09-28 21:10 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] HID: add missing \n to end of dev_warn messages Colin King <colin.king@canonical.com> - 2016-09-27 21:00 +0200
Re: [PATCH] HID: add missing \n to end of dev_warn messages Benjamin Tissoires <benjamin.tissoires@redhat.com> - 2016-09-28 21:10 +0200
| From | Colin King <colin.king@canonical.com> |
|---|---|
| Date | 2016-09-27 21:00 +0200 |
| Subject | [PATCH] HID: add missing \n to end of dev_warn messages |
| Message-ID | <sm5LI-4GC-15@gated-at.bofh.it> |
From: Colin Ian King <colin.king@canonical.com>
Trival fix, dev_warn messages are missing a \n, so add it.
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
include/linux/hid.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/linux/hid.h b/include/linux/hid.h
index 75b66ec..b2ec827 100644
--- a/include/linux/hid.h
+++ b/include/linux/hid.h
@@ -837,7 +837,7 @@ __u32 hid_field_extract(const struct hid_device *hid, __u8 *report,
*/
static inline void hid_device_io_start(struct hid_device *hid) {
if (hid->io_started) {
- dev_warn(&hid->dev, "io already started");
+ dev_warn(&hid->dev, "io already started\n");
return;
}
hid->io_started = true;
@@ -857,7 +857,7 @@ static inline void hid_device_io_start(struct hid_device *hid) {
*/
static inline void hid_device_io_stop(struct hid_device *hid) {
if (!hid->io_started) {
- dev_warn(&hid->dev, "io already stopped");
+ dev_warn(&hid->dev, "io already stopped\n");
return;
}
hid->io_started = false;
--
2.9.3
[toc] | [next] | [standalone]
| From | Benjamin Tissoires <benjamin.tissoires@redhat.com> |
|---|---|
| Date | 2016-09-28 21:10 +0200 |
| Message-ID | <smsoV-2j9-9@gated-at.bofh.it> |
| In reply to | #1492100 |
On Sep 27 2016 or thereabouts, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Trival fix, dev_warn messages are missing a \n, so add it.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
> ---
> include/linux/hid.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/linux/hid.h b/include/linux/hid.h
> index 75b66ec..b2ec827 100644
> --- a/include/linux/hid.h
> +++ b/include/linux/hid.h
> @@ -837,7 +837,7 @@ __u32 hid_field_extract(const struct hid_device *hid, __u8 *report,
> */
> static inline void hid_device_io_start(struct hid_device *hid) {
> if (hid->io_started) {
> - dev_warn(&hid->dev, "io already started");
> + dev_warn(&hid->dev, "io already started\n");
> return;
> }
> hid->io_started = true;
> @@ -857,7 +857,7 @@ static inline void hid_device_io_start(struct hid_device *hid) {
> */
> static inline void hid_device_io_stop(struct hid_device *hid) {
> if (!hid->io_started) {
> - dev_warn(&hid->dev, "io already stopped");
> + dev_warn(&hid->dev, "io already stopped\n");
> return;
> }
> hid->io_started = false;
> --
> 2.9.3
>
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web