Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1492594 > unrolled thread
| Started by | Ramiro Oliveira <Ramiro.Oliveira@synopsys.com> |
|---|---|
| First post | 2016-09-28 15:30 +0200 |
| Last post | 2016-09-28 15:30 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH v2] Staging: android: fix permissions style Ramiro Oliveira <Ramiro.Oliveira@synopsys.com> - 2016-09-28 15:30 +0200
Re: [PATCH v2] Staging: android: fix permissions style Greg KH <gregkh@linuxfoundation.org> - 2016-09-28 15:30 +0200
| From | Ramiro Oliveira <Ramiro.Oliveira@synopsys.com> |
|---|---|
| Date | 2016-09-28 15:30 +0200 |
| Subject | [PATCH v2] Staging: android: fix permissions style |
| Message-ID | <smn5T-7hG-5@gated-at.bofh.it> |
Change permissions from symbolic to octal. V2: Fix all the permissions, previous patch was missing some. Signed-off-by: Ramiro Oliveira <roliveir@synopsys.com> --- drivers/staging/android/lowmemorykiller.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/android/lowmemorykiller.c b/drivers/staging/android/lowmemorykiller.c index 80d7adf..553a3ee 100644 --- a/drivers/staging/android/lowmemorykiller.c +++ b/drivers/staging/android/lowmemorykiller.c @@ -204,10 +204,10 @@ device_initcall(lowmem_init); * not really modular, but the easiest way to keep compat with existing * bootargs behaviour is to continue using module_param here. */ -module_param_named(cost, lowmem_shrinker.seeks, int, S_IRUGO | S_IWUSR); +module_param_named(cost, lowmem_shrinker.seeks, int, 0644); module_param_array_named(adj, lowmem_adj, short, &lowmem_adj_size, - S_IRUGO | S_IWUSR); + 0644); module_param_array_named(minfree, lowmem_minfree, uint, &lowmem_minfree_size, - S_IRUGO | S_IWUSR); -module_param_named(debug_level, lowmem_debug_level, uint, S_IRUGO | S_IWUSR); + 0644); +module_param_named(debug_level, lowmem_debug_level, uint, 0644); -- 2.9.3
[toc] | [next] | [standalone]
| From | Greg KH <gregkh@linuxfoundation.org> |
|---|---|
| Date | 2016-09-28 15:30 +0200 |
| Message-ID | <smn5U-7hG-39@gated-at.bofh.it> |
| In reply to | #1492594 |
On Wed, Sep 28, 2016 at 02:23:00PM +0100, Ramiro Oliveira wrote: > Change permissions from symbolic to octal. > > V2: Fix all the permissions, previous patch was missing some. > Signed-off-by: Ramiro Oliveira <roliveir@synopsys.com> > --- > drivers/staging/android/lowmemorykiller.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/staging/android/lowmemorykiller.c b/drivers/staging/android/lowmemorykiller.c > index 80d7adf..553a3ee 100644 > --- a/drivers/staging/android/lowmemorykiller.c > +++ b/drivers/staging/android/lowmemorykiller.c > @@ -204,10 +204,10 @@ device_initcall(lowmem_init); > * not really modular, but the easiest way to keep compat with existing > * bootargs behaviour is to continue using module_param here. > */ > -module_param_named(cost, lowmem_shrinker.seeks, int, S_IRUGO | S_IWUSR); > +module_param_named(cost, lowmem_shrinker.seeks, int, 0644); > module_param_array_named(adj, lowmem_adj, short, &lowmem_adj_size, > - S_IRUGO | S_IWUSR); > + 0644); > module_param_array_named(minfree, lowmem_minfree, uint, &lowmem_minfree_size, > - S_IRUGO | S_IWUSR); > -module_param_named(debug_level, lowmem_debug_level, uint, S_IRUGO | S_IWUSR); > + 0644); > +module_param_named(debug_level, lowmem_debug_level, uint, 0644); > Still doesn't apply, make sure you always work against linux-next... thanks, greg k-h
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web