Groups > linux.kernel > #1493876 > unrolled thread

linux-next: build failure after merge of the tty tree

Started by	Stephen Rothwell <sfr@canb.auug.org.au>
First post	2016-09-30 06:00 +0200
Last post	2016-09-30 08:00 +0200
Articles	2 — 2 participants

Back to article view | Back to linux.kernel

  linux-next: build failure after merge of the tty tree Stephen Rothwell <sfr@canb.auug.org.au> - 2016-09-30 06:00 +0200
    Re: linux-next: build failure after merge of the tty tree Greg KH <greg@kroah.com> - 2016-09-30 08:00 +0200

#1493876 — linux-next: build failure after merge of the tty tree

From	Stephen Rothwell <sfr@canb.auug.org.au>
Date	2016-09-30 06:00 +0200
Subject	linux-next: build failure after merge of the tty tree
Message-ID	<smX9n-4UQ-5@gated-at.bofh.it>

Hi Greg,

After merging the tty tree, today's linux-next build (arm
multi_v7_defconfig) failed like this:

drivers/tty/serial/amba-pl011.c: In function 'pl011_console_match':
drivers/tty/serial/amba-pl011.c:2346:44: error: passing argument 3 of 'uart_parse_earlycon' from incompatible pointer type [-Werror=incompatible-pointer-types]
  if (uart_parse_earlycon(options, &iotype, &addr, &options))
                                            ^
In file included from drivers/tty/serial/amba-pl011.c:45:0:
include/linux/serial_core.h:384:5: note: expected 'resource_size_t * {aka unsigned int *}' but argument is of type 'long unsigned int *'
 int uart_parse_earlycon(char *p, unsigned char *iotype, resource_size_t *addr,
     ^

Caused by commit

  8b8f347d3a48 ("serial: pl011: add console matching function")

interacting with commit

  46e36683f433 ("serial: earlycon: Extend earlycon command line option to support 64-bit addresses")

I have reverted commit 8b8f347d3a48 for today.

-- 
Cheers,
Stephen Rothwell

[toc] | [next] | [standalone]

#1493898

From	Greg KH <greg@kroah.com>
Date	2016-09-30 08:00 +0200
Message-ID	<smZ1v-6b5-11@gated-at.bofh.it>
In reply to	#1493876

On Fri, Sep 30, 2016 at 01:54:37PM +1000, Stephen Rothwell wrote:
> Hi Greg,
> 
> After merging the tty tree, today's linux-next build (arm
> multi_v7_defconfig) failed like this:
> 
> drivers/tty/serial/amba-pl011.c: In function 'pl011_console_match':
> drivers/tty/serial/amba-pl011.c:2346:44: error: passing argument 3 of 'uart_parse_earlycon' from incompatible pointer type [-Werror=incompatible-pointer-types]
>   if (uart_parse_earlycon(options, &iotype, &addr, &options))
>                                             ^
> In file included from drivers/tty/serial/amba-pl011.c:45:0:
> include/linux/serial_core.h:384:5: note: expected 'resource_size_t * {aka unsigned int *}' but argument is of type 'long unsigned int *'
>  int uart_parse_earlycon(char *p, unsigned char *iotype, resource_size_t *addr,
>      ^
> 
> Caused by commit
> 
>   8b8f347d3a48 ("serial: pl011: add console matching function")
> 
> interacting with commit
> 
>   46e36683f433 ("serial: earlycon: Extend earlycon command line option to support 64-bit addresses")
> 
> I have reverted commit 8b8f347d3a48 for today.

Ick, sorry about that.  I wonder why I'm not seeing that same build
failure here, odd.  I'll go revert the same patch in my tree now as
well.

thanks,

greg k-h

[toc] | [prev] | [standalone]

csiph-web

linux-next: build failure after merge of the tty tree

Contents

#1493876 — linux-next: build failure after merge of the tty tree

#1493898