Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1493479 > unrolled thread

Re: [PATCH 2/6] ipr: use pci_irq_allocate_vectors

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH 2/6] ipr: use pci_irq_allocate_vectors Brian King <brking@linux.vnet.ibm.com> - 2016-09-29 16:10 +0200
    Re: [PATCH 2/6] ipr: use pci_irq_allocate_vectors Christoph Hellwig <hch@lst.de> - 2016-09-29 17:40 +0200

#1493479 — Re: [PATCH 2/6] ipr: use pci_irq_allocate_vectors

Thanks Christoph. Very nice. As I was reviewing the patch, I noticed
the additional PCI_IRQ_AFFINITY flag, which is currently not being set
in this patch. Is the intention to set that globally by default, or
should I follow up with a one liner to add that to the ipr driver
in the next patch set I send out?

Acked-by: Brian King <brking@linux.vnet.ibm.com>

Thanks,

Brian


-- 
Brian King
Power Linux I/O
IBM Linux Technology Center

[toc] | [next] | [standalone]

#1493536

On Thu, Sep 29, 2016 at 09:01:44AM -0500, Brian King wrote:
> Thanks Christoph. Very nice. As I was reviewing the patch, I noticed
> the additional PCI_IRQ_AFFINITY flag, which is currently not being set
> in this patch. Is the intention to set that globally by default, or
> should I follow up with a one liner to add that to the ipr driver
> in the next patch set I send out?

Hi Brian,

PCI_IRQ_AFFINITY seems useful for ipr, especially if you also increase
the number of vectors above the current default 2.  And yes, please
make it a separate patch.

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web