Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1492110 > unrolled thread
| Started by | Colin King <colin.king@canonical.com> |
|---|---|
| First post | 2016-09-27 21:20 +0200 |
| Last post | 2016-09-28 09:10 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] s390/dasd: add missing \n to end of dev_err messages Colin King <colin.king@canonical.com> - 2016-09-27 21:20 +0200
Re: [PATCH] s390/dasd: add missing \n to end of dev_err messages Martin Schwidefsky <schwidefsky@de.ibm.com> - 2016-09-28 09:10 +0200
| From | Colin King <colin.king@canonical.com> |
|---|---|
| Date | 2016-09-27 21:20 +0200 |
| Subject | [PATCH] s390/dasd: add missing \n to end of dev_err messages |
| Message-ID | <sm653-526-1@gated-at.bofh.it> |
From: Colin Ian King <colin.king@canonical.com>
Trival fix, dev_err messages are missing a \n, so add it.
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/s390/block/dasd_erp.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/s390/block/dasd_erp.c b/drivers/s390/block/dasd_erp.c
index e1e8848..d138d01 100644
--- a/drivers/s390/block/dasd_erp.c
+++ b/drivers/s390/block/dasd_erp.c
@@ -169,12 +169,12 @@ dasd_log_sense(struct dasd_ccw_req *cqr, struct irb *irb)
device = cqr->startdev;
if (cqr->intrc == -ETIMEDOUT) {
dev_err(&device->cdev->dev,
- "A timeout error occurred for cqr %p", cqr);
+ "A timeout error occurred for cqr %p\n", cqr);
return;
}
if (cqr->intrc == -ENOLINK) {
dev_err(&device->cdev->dev,
- "A transport error occurred for cqr %p", cqr);
+ "A transport error occurred for cqr %p\n", cqr);
return;
}
/* dump sense data */
--
2.9.3
[toc] | [next] | [standalone]
| From | Martin Schwidefsky <schwidefsky@de.ibm.com> |
|---|---|
| Date | 2016-09-28 09:10 +0200 |
| Message-ID | <smha9-3F9-1@gated-at.bofh.it> |
| In reply to | #1492110 |
On Tue, 27 Sep 2016 12:13:18 -0700 Colin King <colin.king@canonical.com> wrote: > From: Colin Ian King <colin.king@canonical.com> > > Trival fix, dev_err messages are missing a \n, so add it. > > Signed-off-by: Colin Ian King <colin.king@canonical.com> > --- > drivers/s390/block/dasd_erp.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Applied, thanks. -- blue skies, Martin. "Reality continues to ruin my life." - Calvin.
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web