Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1491954 > unrolled thread

[PATCH] uapi: add missing install of sync_file.h

Back to article view | Back to linux.kernel

Contents

  [PATCH] uapi: add missing install of sync_file.h Emilio López <emilio.lopez@collabora.co.uk> - 2016-09-27 16:40 +0200
    Re: [PATCH] uapi: add missing install of sync_file.h Gustavo Padovan <gustavo.padovan@collabora.com> - 2016-09-27 18:10 +0200
      Re: [PATCH] uapi: add missing install of sync_file.h Sean Paul <seanpaul@chromium.org> - 2016-09-29 15:40 +0200

#1491954 — [PATCH] uapi: add missing install of sync_file.h

As part of the sync framework destaging, the sync_file.h header
was moved, but an entry was not added on Kbuild to install it.
This patch resolves this omission so that "make headers_install"
installs this header.

Fixes: 460bfc41fd52 ("dma-buf/sync_file: de-stage sync_file headers")
Reported-by: Michael Ellerman <mpe@ellerman.id.au>
Signed-off-by: Emilio López <emilio.lopez@collabora.co.uk>
---

I don't know if this is worth cc'ing stable, the patch has been
there since v4.7. I spotted this while reflecting on Michael's
review[0] on my kselftest series, and he later independently
confirmed so[1].

[0] http://www.spinics.net/lists/linux-kselftest/msg00444.html
[1] http://www.spinics.net/lists/linux-kselftest/msg00457.html

 include/uapi/linux/Kbuild | 1 +
 1 file changed, 1 insertion(+)

diff --git a/include/uapi/linux/Kbuild b/include/uapi/linux/Kbuild
index 185f8ea..407ca0d 100644
--- a/include/uapi/linux/Kbuild
+++ b/include/uapi/linux/Kbuild
@@ -396,6 +396,7 @@ header-y += string.h
 header-y += suspend_ioctls.h
 header-y += swab.h
 header-y += synclink.h
+header-y += sync_file.h
 header-y += sysctl.h
 header-y += sysinfo.h
 header-y += target_core_user.h
-- 
2.9.3

[toc] | [next] | [standalone]

#1492005

2016-09-27 Emilio López <emilio.lopez@collabora.co.uk>:

> As part of the sync framework destaging, the sync_file.h header
> was moved, but an entry was not added on Kbuild to install it.
> This patch resolves this omission so that "make headers_install"
> installs this header.
> 
> Fixes: 460bfc41fd52 ("dma-buf/sync_file: de-stage sync_file headers")
> Reported-by: Michael Ellerman <mpe@ellerman.id.au>
> Signed-off-by: Emilio López <emilio.lopez@collabora.co.uk>
> ---
> 
> I don't know if this is worth cc'ing stable, the patch has been
> there since v4.7. I spotted this while reflecting on Michael's
> review[0] on my kselftest series, and he later independently
> confirmed so[1].

We still don't have any drivers in the kernel using this, no need
to send this stable or 4.8. drm-misc should be fine. 

> 
> [0] http://www.spinics.net/lists/linux-kselftest/msg00444.html
> [1] http://www.spinics.net/lists/linux-kselftest/msg00457.html
> 
>  include/uapi/linux/Kbuild | 1 +
>  1 file changed, 1 insertion(+)

Reviewed-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk>

Gustavo

[toc] | [prev] | [next] | [standalone]

#1493467

On Tue, Sep 27, 2016 at 12:06 PM, Gustavo Padovan
<gustavo.padovan@collabora.com> wrote:
> 2016-09-27 Emilio López <emilio.lopez@collabora.co.uk>:
>
>> As part of the sync framework destaging, the sync_file.h header
>> was moved, but an entry was not added on Kbuild to install it.
>> This patch resolves this omission so that "make headers_install"
>> installs this header.
>>
>> Fixes: 460bfc41fd52 ("dma-buf/sync_file: de-stage sync_file headers")
>> Reported-by: Michael Ellerman <mpe@ellerman.id.au>
>> Signed-off-by: Emilio López <emilio.lopez@collabora.co.uk>
>> ---
>>
>> I don't know if this is worth cc'ing stable, the patch has been
>> there since v4.7. I spotted this while reflecting on Michael's
>> review[0] on my kselftest series, and he later independently
>> confirmed so[1].
>
> We still don't have any drivers in the kernel using this, no need
> to send this stable or 4.8. drm-misc should be fine.
>

Applied to -misc, thanks

Sean

>>
>> [0] http://www.spinics.net/lists/linux-kselftest/msg00444.html
>> [1] http://www.spinics.net/lists/linux-kselftest/msg00457.html
>>
>>  include/uapi/linux/Kbuild | 1 +
>>  1 file changed, 1 insertion(+)
>
> Reviewed-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
>
> Gustavo

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web