Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1491802 > unrolled thread
| Started by | Rafał Miłecki <zajec5@gmail.com> |
|---|---|
| First post | 2016-09-27 12:20 +0200 |
| Last post | 2016-09-27 17:50 +0200 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] brcmfmac: replace WARNING on timeout with a simple error message Rafał Miłecki <zajec5@gmail.com> - 2016-09-27 12:20 +0200
Re: [PATCH] brcmfmac: replace WARNING on timeout with a simple error message Arend Van Spriel <arend.vanspriel@broadcom.com> - 2016-09-27 13:30 +0200
Re: brcmfmac: replace WARNING on timeout with a simple error message Kalle Valo <kvalo@codeaurora.org> - 2016-09-27 17:50 +0200
| From | Rafał Miłecki <zajec5@gmail.com> |
|---|---|
| Date | 2016-09-27 12:20 +0200 |
| Subject | [PATCH] brcmfmac: replace WARNING on timeout with a simple error message |
| Message-ID | <slXEt-8j4-7@gated-at.bofh.it> |
From: Rafał Miłecki <rafal@milecki.pl>
Even with timeout increased to 950 ms we get WARNINGs from time to time.
It mostly happens on A-MPDU stalls (e.g. when station goes out of
range). It may take up to 5-10 secods for the firmware to recover and
for that time it doesn't process packets.
It's still useful to have a message on time out as it may indicate some
firmware problem and incorrect key update. Raising a WARNING however
wasn't really that necessary, it doesn't point to any driver bug anymore
and backtrace wasn't much useful.
Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
---
drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c
index 6d046ba..9e6f60a 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c
@@ -1161,7 +1161,8 @@ int brcmf_netdev_wait_pend8021x(struct brcmf_if *ifp)
!brcmf_get_pend_8021x_cnt(ifp),
MAX_WAIT_FOR_8021X_TX);
- WARN_ON(!err);
+ if (!err)
+ brcmf_err("Timed out waiting for no pending 802.1x packets\n");
return !err;
}
--
2.9.3
[toc] | [next] | [standalone]
| From | Arend Van Spriel <arend.vanspriel@broadcom.com> |
|---|---|
| Date | 2016-09-27 13:30 +0200 |
| Subject | Re: [PATCH] brcmfmac: replace WARNING on timeout with a simple error message |
| Message-ID | <slYKe-tC-19@gated-at.bofh.it> |
| In reply to | #1491802 |
On 27-9-2016 12:12, Rafał Miłecki wrote:
> From: Rafał Miłecki <rafal@milecki.pl>
>
> Even with timeout increased to 950 ms we get WARNINGs from time to time.
> It mostly happens on A-MPDU stalls (e.g. when station goes out of
> range). It may take up to 5-10 secods for the firmware to recover and
> for that time it doesn't process packets.
>
> It's still useful to have a message on time out as it may indicate some
> firmware problem and incorrect key update. Raising a WARNING however
> wasn't really that necessary, it doesn't point to any driver bug anymore
> and backtrace wasn't much useful.
Indeed the interesting part would be in another context. So:
Acked-by: Arend van Spriel <arend.vanspriel@broadcom.com>
> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
> ---
> drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c
> index 6d046ba..9e6f60a 100644
> --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c
> +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c
> @@ -1161,7 +1161,8 @@ int brcmf_netdev_wait_pend8021x(struct brcmf_if *ifp)
> !brcmf_get_pend_8021x_cnt(ifp),
> MAX_WAIT_FOR_8021X_TX);
>
> - WARN_ON(!err);
> + if (!err)
> + brcmf_err("Timed out waiting for no pending 802.1x packets\n");
>
> return !err;
> }
>
[toc] | [prev] | [next] | [standalone]
| From | Kalle Valo <kvalo@codeaurora.org> |
|---|---|
| Date | 2016-09-27 17:50 +0200 |
| Subject | Re: brcmfmac: replace WARNING on timeout with a simple error message |
| Message-ID | <sm2NP-2OB-23@gated-at.bofh.it> |
| In reply to | #1491802 |
Rafał Miłecki wrote: > From: Rafał Miłecki <rafal@milecki.pl> > > Even with timeout increased to 950 ms we get WARNINGs from time to time. > It mostly happens on A-MPDU stalls (e.g. when station goes out of > range). It may take up to 5-10 secods for the firmware to recover and > for that time it doesn't process packets. > > It's still useful to have a message on time out as it may indicate some > firmware problem and incorrect key update. Raising a WARNING however > wasn't really that necessary, it doesn't point to any driver bug anymore > and backtrace wasn't much useful. > > Signed-off-by: Rafał Miłecki <rafal@milecki.pl> > Acked-by: Arend van Spriel <arend.vanspriel@broadcom.com> Patch applied to wireless-drivers-next.git, thanks. 2f0e56fa37cc brcmfmac: replace WARNING on timeout with a simple error message -- https://patchwork.kernel.org/patch/9351657/ Documentation about submitting wireless patches and checking status from patchwork: https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web