Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1490986 > unrolled thread
| Started by | Colin King <colin.king@canonical.com> |
|---|---|
| First post | 2016-09-26 00:10 +0200 |
| Last post | 2016-09-27 00:00 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] nvme-rdma: add missing \n to end of dev_err message Colin King <colin.king@canonical.com> - 2016-09-26 00:10 +0200
Re: [PATCH] nvme-rdma: add missing \n to end of dev_err message J Freyensee <james_p_freyensee@linux.intel.com> - 2016-09-27 00:00 +0200
| From | Colin King <colin.king@canonical.com> |
|---|---|
| Date | 2016-09-26 00:10 +0200 |
| Subject | [PATCH] nvme-rdma: add missing \n to end of dev_err message |
| Message-ID | <slpMt-3LD-11@gated-at.bofh.it> |
From: Colin Ian King <colin.king@canonical.com>
Trival fix, dev_err message is missing a \n, so add it. Also
break line as it was over 80 chars wide.
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/nvme/host/rdma.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/nvme/host/rdma.c b/drivers/nvme/host/rdma.c
index 69e1fb7..3f32995 100644
--- a/drivers/nvme/host/rdma.c
+++ b/drivers/nvme/host/rdma.c
@@ -1227,7 +1227,8 @@ static int nvme_rdma_conn_rejected(struct nvme_rdma_queue *queue,
(struct nvme_rdma_cm_rej *)ev->param.conn.private_data;
dev_err(queue->ctrl->ctrl.device,
- "Connect rejected, status %d.", le16_to_cpu(rej->sts));
+ "Connect rejected, status %d.\n",
+ le16_to_cpu(rej->sts));
/* XXX: Think of something clever to do here... */
} else {
dev_err(queue->ctrl->ctrl.device,
--
2.9.3
[toc] | [next] | [standalone]
| From | J Freyensee <james_p_freyensee@linux.intel.com> |
|---|---|
| Date | 2016-09-27 00:00 +0200 |
| Message-ID | <slM6l-JE-29@gated-at.bofh.it> |
| In reply to | #1490986 |
On Sun, 2016-09-25 at 15:01 -0700, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Trival fix, dev_err message is missing a \n, so add it. Also
> break line as it was over 80 chars wide.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Jay Freyensee <james_p_freyensee@linux.intel.com>
> ---
> drivers/nvme/host/rdma.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/nvme/host/rdma.c b/drivers/nvme/host/rdma.c
> index 69e1fb7..3f32995 100644
> --- a/drivers/nvme/host/rdma.c
> +++ b/drivers/nvme/host/rdma.c
> @@ -1227,7 +1227,8 @@ static int nvme_rdma_conn_rejected(struct
> nvme_rdma_queue *queue,
> (struct nvme_rdma_cm_rej *)ev-
> >param.conn.private_data;
>
> dev_err(queue->ctrl->ctrl.device,
> - "Connect rejected, status %d.",
> le16_to_cpu(rej->sts));
> + "Connect rejected, status %d.\n",
> + le16_to_cpu(rej->sts));
> /* XXX: Think of something clever to do here... */
> } else {
> dev_err(queue->ctrl->ctrl.device,
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web