Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1490974 > unrolled thread

[PATCH, TRIVIAL] Fixed block comment coding style

Started byGonçalo Salazar <glbsalazar@gmail.com>
First post2016-09-25 23:20 +0200
Last post2016-09-26 01:00 +0200
Articles 2 — 2 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH, TRIVIAL] Fixed block comment coding style Gonçalo Salazar <glbsalazar@gmail.com> - 2016-09-25 23:20 +0200
    Re: [PATCH, TRIVIAL] Fixed block comment coding style Larry Finger <Larry.Finger@lwfinger.net> - 2016-09-26 01:00 +0200

#1490974 — [PATCH, TRIVIAL] Fixed block comment coding style

FromGonçalo Salazar <glbsalazar@gmail.com>
Date2016-09-25 23:20 +0200
Subject[PATCH, TRIVIAL] Fixed block comment coding style
Message-ID<slp06-3eH-1@gated-at.bofh.it>
Fixed a block comment indentation in the rtl8712 usb_intf.c file.
Made this as a first commit.

Please let me know of any feedback you have.

Thanks,
Gonçalo Salazar

Signed-off-by: Gonçalo Salazar <glbsalazar@gmail.com>
---
 drivers/staging/rtl8712/usb_intf.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8712/usb_intf.c b/drivers/staging/rtl8712/usb_intf.c
index 3fc65b2..897d462 100644
--- a/drivers/staging/rtl8712/usb_intf.c
+++ b/drivers/staging/rtl8712/usb_intf.c
@@ -369,7 +369,7 @@ static const struct device_type wlan_type = {
  *
  * notes: drv_init() is called when the bus driver has located a card for us
  * to support. We accept the new device by returning 0.
-*/
+ */
 static int r871xu_drv_init(struct usb_interface *pusb_intf,
 			   const struct usb_device_id *pdid)
 {
-- 
2.7.4

[toc] | [next] | [standalone]


#1490991

FromLarry Finger <Larry.Finger@lwfinger.net>
Date2016-09-26 01:00 +0200
Message-ID<slqyR-49T-1@gated-at.bofh.it>
In reply to#1490974
On 09/25/2016 04:18 PM, Gonçalo Salazar wrote:
> Fixed a block comment indentation in the rtl8712 usb_intf.c file.
> Made this as a first commit.
>
> Please let me know of any feedback you have.
>
> Thanks,
> Gonçalo Salazar

Your subject heeds to specify which driver is involved. In addition, fixes for 
staging drivers also need that indicated as well. Thus your subject should be 
"staging: rtl8172: Fix block...". When you resubmit, have it read "[PATCH V2}".
>
> Signed-off-by: Gonçalo Salazar <glbsalazar@gmail.com>
> ---
>  drivers/staging/rtl8712/usb_intf.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8712/usb_intf.c b/drivers/staging/rtl8712/usb_intf.c
> index 3fc65b2..897d462 100644
> --- a/drivers/staging/rtl8712/usb_intf.c
> +++ b/drivers/staging/rtl8712/usb_intf.c
> @@ -369,7 +369,7 @@ static const struct device_type wlan_type = {
>   *
>   * notes: drv_init() is called when the bus driver has located a card for us
>   * to support. We accept the new device by returning 0.
> -*/
> + */
>  static int r871xu_drv_init(struct usb_interface *pusb_intf,
>  			   const struct usb_device_id *pdid)
>  {
>

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web