Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1491777 > unrolled thread
| Started by | Quentin Lambert <lambert.quentin@gmail.com> |
|---|---|
| First post | 2016-09-27 11:30 +0200 |
| Last post | 2016-09-27 11:50 +0200 |
| Articles | 6 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] greybus: manifest: style fix missing space before '(' Quentin Lambert <lambert.quentin@gmail.com> - 2016-09-27 11:30 +0200
Re: [PATCH] greybus: manifest: style fix missing space before '(' Viresh Kumar <viresh.kumar@linaro.org> - 2016-09-27 11:40 +0200
Re: [PATCH] greybus: manifest: style fix missing space before '(' Viresh Kumar <viresh.kumar@linaro.org> - 2016-09-27 11:40 +0200
Re: [PATCH] greybus: manifest: style fix missing space before '(' Quentin Lambert <lambert.quentin@gmail.com> - 2016-09-27 11:40 +0200
Re: [PATCH] greybus: manifest: style fix missing space before '(' Dan Carpenter <dan.carpenter@oracle.com> - 2016-09-27 11:50 +0200
[PATCH v2] greybus: manifest: style fix missing space before '(' Quentin Lambert <lambert.quentin@gmail.com> - 2016-09-27 11:50 +0200
| From | Quentin Lambert <lambert.quentin@gmail.com> |
|---|---|
| Date | 2016-09-27 11:30 +0200 |
| Subject | [PATCH] greybus: manifest: style fix missing space before '(' |
| Message-ID | <slWS6-7Jg-11@gated-at.bofh.it> |
Checkpatch printed a style ERROR concerning a missing space befire '('.
This patch fix this issue.
Signed-off-by: Quentin Lambert <lambert.quentin@gmail.com>
---
drivers/staging/greybus/manifest.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/staging/greybus/manifest.c
+++ b/drivers/staging/greybus/manifest.c
@@ -11,7 +11,7 @@
static const char *get_descriptor_type_string(u8 type)
{
- switch(type) {
+ switch (type) {
case GREYBUS_TYPE_INVALID:
return "invalid";
case GREYBUS_TYPE_STRING:
[toc] | [next] | [standalone]
| From | Viresh Kumar <viresh.kumar@linaro.org> |
|---|---|
| Date | 2016-09-27 11:40 +0200 |
| Message-ID | <slX1M-7Mm-3@gated-at.bofh.it> |
| In reply to | #1491777 |
On 27 September 2016 at 15:03, Quentin Lambert
<lambert.quentin@gmail.com> wrote:
>
>
> On 27/09/2016 11:31, Viresh Kumar wrote:
>>
>> On Tue, Sep 27, 2016 at 2:50 PM, Quentin Lambert
>> <lambert.quentin@gmail.com> wrote:
>>>
>>> Checkpatch printed a style ERROR concerning a missing space befire '('.
>>> This patch fix this issue.
>>>
>>> Signed-off-by: Quentin Lambert <lambert.quentin@gmail.com>
>>> ---
>>> drivers/staging/greybus/manifest.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> --- a/drivers/staging/greybus/manifest.c
>>> +++ b/drivers/staging/greybus/manifest.c
>>> @@ -11,7 +11,7 @@
>>>
>>> static const char *get_descriptor_type_string(u8 type)
>>> {
>>> - switch(type) {
>>> + switch (type) {
>>> case GREYBUS_TYPE_INVALID:
>>> return "invalid";
>>> case GREYBUS_TYPE_STRING:
>>
>> Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
>
> Wow I just noticed the typo: "befire" do you want me to resend ?
Oops, sorry for missing that.
Yes, please resend the patch as V2 and feel free to add my Ack to it.
--
viresh
[toc] | [prev] | [next] | [standalone]
| From | Viresh Kumar <viresh.kumar@linaro.org> |
|---|---|
| Date | 2016-09-27 11:40 +0200 |
| Message-ID | <slX1M-7Mm-5@gated-at.bofh.it> |
| In reply to | #1491777 |
On Tue, Sep 27, 2016 at 2:50 PM, Quentin Lambert
<lambert.quentin@gmail.com> wrote:
> Checkpatch printed a style ERROR concerning a missing space befire '('.
> This patch fix this issue.
>
> Signed-off-by: Quentin Lambert <lambert.quentin@gmail.com>
> ---
> drivers/staging/greybus/manifest.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- a/drivers/staging/greybus/manifest.c
> +++ b/drivers/staging/greybus/manifest.c
> @@ -11,7 +11,7 @@
>
> static const char *get_descriptor_type_string(u8 type)
> {
> - switch(type) {
> + switch (type) {
> case GREYBUS_TYPE_INVALID:
> return "invalid";
> case GREYBUS_TYPE_STRING:
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
[toc] | [prev] | [next] | [standalone]
| From | Quentin Lambert <lambert.quentin@gmail.com> |
|---|---|
| Date | 2016-09-27 11:40 +0200 |
| Message-ID | <slX1M-7Mm-7@gated-at.bofh.it> |
| In reply to | #1491780 |
On 27/09/2016 11:31, Viresh Kumar wrote:
> On Tue, Sep 27, 2016 at 2:50 PM, Quentin Lambert
> <lambert.quentin@gmail.com> wrote:
>> Checkpatch printed a style ERROR concerning a missing space befire '('.
>> This patch fix this issue.
>>
>> Signed-off-by: Quentin Lambert <lambert.quentin@gmail.com>
>> ---
>> drivers/staging/greybus/manifest.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> --- a/drivers/staging/greybus/manifest.c
>> +++ b/drivers/staging/greybus/manifest.c
>> @@ -11,7 +11,7 @@
>>
>> static const char *get_descriptor_type_string(u8 type)
>> {
>> - switch(type) {
>> + switch (type) {
>> case GREYBUS_TYPE_INVALID:
>> return "invalid";
>> case GREYBUS_TYPE_STRING:
> Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Wow I just noticed the typo: "befire" do you want me to resend ?
Quentin
[toc] | [prev] | [next] | [standalone]
| From | Dan Carpenter <dan.carpenter@oracle.com> |
|---|---|
| Date | 2016-09-27 11:50 +0200 |
| Message-ID | <slXbw-7Px-5@gated-at.bofh.it> |
| In reply to | #1491783 |
On Tue, Sep 27, 2016 at 11:33:49AM +0200, Quentin Lambert wrote:
>
>
> On 27/09/2016 11:31, Viresh Kumar wrote:
> >On Tue, Sep 27, 2016 at 2:50 PM, Quentin Lambert
> ><lambert.quentin@gmail.com> wrote:
> >>Checkpatch printed a style ERROR concerning a missing space befire '('.
> >>This patch fix this issue.
> >>
> >>Signed-off-by: Quentin Lambert <lambert.quentin@gmail.com>
> >>---
> >> drivers/staging/greybus/manifest.c | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >>--- a/drivers/staging/greybus/manifest.c
> >>+++ b/drivers/staging/greybus/manifest.c
> >>@@ -11,7 +11,7 @@
> >>
> >> static const char *get_descriptor_type_string(u8 type)
> >> {
> >>- switch(type) {
> >>+ switch (type) {
> >> case GREYBUS_TYPE_INVALID:
> >> return "invalid";
> >> case GREYBUS_TYPE_STRING:
> >Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
> Wow I just noticed the typo: "befire" do you want me to resend ?
No one cares about tiny typos in the patch description, but resend if
you want.
regards,
dan carpenter
[toc] | [prev] | [next] | [standalone]
| From | Quentin Lambert <lambert.quentin@gmail.com> |
|---|---|
| Date | 2016-09-27 11:50 +0200 |
| Subject | [PATCH v2] greybus: manifest: style fix missing space before '(' |
| Message-ID | <slXbw-7Px-7@gated-at.bofh.it> |
| In reply to | #1491777 |
Checkpatch printed a style ERROR concerning a missing space before '('.
This patch fixes this issue.
Signed-off-by: Quentin Lambert <lambert.quentin@gmail.com>
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
---
v2: fixes typos in commit message
drivers/staging/greybus/manifest.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/staging/greybus/manifest.c
+++ b/drivers/staging/greybus/manifest.c
@@ -11,7 +11,7 @@
static const char *get_descriptor_type_string(u8 type)
{
- switch(type) {
+ switch (type) {
case GREYBUS_TYPE_INVALID:
return "invalid";
case GREYBUS_TYPE_STRING:
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web