Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1491568 > unrolled thread

[PATCH v2] raid6/test/test.c: bug fix: Specify aligned(alignment) attributes to the char arrays

Back to article view | Back to linux.kernel

Contents

  [PATCH v2] raid6/test/test.c: bug fix: Specify aligned(alignment) attributes to the char arrays Gayatri Kammela <gayatri.kammela@intel.com> - 2016-09-26 23:50 +0200
    Re: [PATCH v2] raid6/test/test.c: bug fix: Specify  aligned(alignment) attributes to the char arrays Shaohua Li <shli@kernel.org> - 2016-09-27 01:20 +0200

#1491568 — [PATCH v2] raid6/test/test.c: bug fix: Specify aligned(alignment) attributes to the char arrays

Specifying the aligned attributes to the char data[NDISKS][PAGE_SIZE],
char recovi[PAGE_SIZE] and char recovi[PAGE_SIZE] arrays, so that all
malloc memory is page boundary aligned.

Without these alignment attributes, the test causes a segfault in
userspace when the NDISKS are changed to 4 from 16.

The RAID stripes will be page aligned anyway, so we want to test what
the kernel actually will execute.

Cc: H. Peter Anvin <hpa@zytor.com>
Cc: Yu-cheng Yu <yu-cheng.yu@intel.com>
Signed-off-by: Gayatri Kammela <gayatri.kammela@intel.com>
Reviewed-by: H. Peter Anvin <hpa@linux.intel.com>
---
 lib/raid6/test/test.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/lib/raid6/test/test.c b/lib/raid6/test/test.c
index 3bebbabdb510..b07f4d8e6b03 100644
--- a/lib/raid6/test/test.c
+++ b/lib/raid6/test/test.c
@@ -21,12 +21,13 @@
 
 #define NDISKS		16	/* Including P and Q */
 
-const char raid6_empty_zero_page[PAGE_SIZE] __attribute__((aligned(256)));
+const char raid6_empty_zero_page[PAGE_SIZE] __attribute__((aligned(PAGE_SIZE)));
 struct raid6_calls raid6_call;
 
 char *dataptrs[NDISKS];
-char data[NDISKS][PAGE_SIZE];
-char recovi[PAGE_SIZE], recovj[PAGE_SIZE];
+char data[NDISKS][PAGE_SIZE] __attribute__((aligned(PAGE_SIZE)));
+char recovi[PAGE_SIZE] __attribute__((aligned(PAGE_SIZE)));
+char recovj[PAGE_SIZE] __attribute__((aligned(PAGE_SIZE)));
 
 static void makedata(int start, int stop)
 {
-- 
2.7.4

[toc] | [next] | [standalone]

#1491599 — Re: [PATCH v2] raid6/test/test.c: bug fix: Specify aligned(alignment) attributes to the char arrays

On Mon, Sep 26, 2016 at 02:37:38PM -0700, Gayatri Kammela wrote:
> Specifying the aligned attributes to the char data[NDISKS][PAGE_SIZE],
> char recovi[PAGE_SIZE] and char recovi[PAGE_SIZE] arrays, so that all
> malloc memory is page boundary aligned.
> 
> Without these alignment attributes, the test causes a segfault in
> userspace when the NDISKS are changed to 4 from 16.
> 
> The RAID stripes will be page aligned anyway, so we want to test what
> the kernel actually will execute.

Applied, thanks!

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web