Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1491390 > unrolled thread
| Started by | SF Markus Elfring <elfring@users.sourceforge.net> |
|---|---|
| First post | 2016-09-26 18:10 +0200 |
| Last post | 2016-09-26 20:50 +0200 |
| Articles | 6 — 3 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: hostap: Delete an unnecessary jump label in prism2_ioctl_priv_hostapd() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-26 18:10 +0200
Re: hostap: Delete an unnecessary jump label in prism2_ioctl_priv_hostapd() Kalle Valo <kvalo@codeaurora.org> - 2016-09-26 20:10 +0200
Re: hostap: Delete an unnecessary jump label in prism2_ioctl_priv_hostapd() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-26 20:10 +0200
Re: hostap: Delete an unnecessary jump label in prism2_ioctl_priv_hostapd() Joe Perches <joe@perches.com> - 2016-09-26 20:20 +0200
Re: hostap: Delete an unnecessary jump label in prism2_ioctl_priv_hostapd() Kalle Valo <kvalo@codeaurora.org> - 2016-09-26 20:40 +0200
Re: hostap: Delete an unnecessary jump label in prism2_ioctl_priv_hostapd() Joe Perches <joe@perches.com> - 2016-09-26 20:50 +0200
| From | SF Markus Elfring <elfring@users.sourceforge.net> |
|---|---|
| Date | 2016-09-26 18:10 +0200 |
| Subject | Re: hostap: Delete an unnecessary jump label in prism2_ioctl_priv_hostapd() |
| Message-ID | <slGDD-5XZ-1@gated-at.bofh.it> |
> 9291771 [2/3] hostap: Delete an unnecessary jump label in prism2_ioctl_priv_hostapd() > 9291775 [3/3] hostap: Delete unnecessary initialisations for the variable "ret" > > Reason: The benefit is not clear. How do you think about to reduce the source code a bit at these places? Regards, Markus
[toc] | [next] | [standalone]
| From | Kalle Valo <kvalo@codeaurora.org> |
|---|---|
| Date | 2016-09-26 20:10 +0200 |
| Subject | Re: hostap: Delete an unnecessary jump label in prism2_ioctl_priv_hostapd() |
| Message-ID | <slIvM-79b-13@gated-at.bofh.it> |
| In reply to | #1491390 |
SF Markus Elfring <elfring@users.sourceforge.net> writes: >> 9291771 [2/3] hostap: Delete an unnecessary jump label in prism2_ioctl_priv_hostapd() >> 9291775 [3/3] hostap: Delete unnecessary initialisations for the variable "ret" >> >> Reason: The benefit is not clear. > > How do you think about to reduce the source code a bit at these places? hostap is an obsolete driver, it's waste of time doing style fixes to it as nobody maintains it anymore. -- Kalle Valo
[toc] | [prev] | [next] | [standalone]
| From | SF Markus Elfring <elfring@users.sourceforge.net> |
|---|---|
| Date | 2016-09-26 20:10 +0200 |
| Message-ID | <slIvM-79b-53@gated-at.bofh.it> |
| In reply to | #1491487 |
> hostap is an obsolete driver, it's waste of time doing style fixes to it > as nobody maintains it anymore. Thanks for another bit of your software development attention and this information. Is it easier to understand than the previous response "Reason: The benefit is not clear."? Regards, Markus
[toc] | [prev] | [next] | [standalone]
| From | Joe Perches <joe@perches.com> |
|---|---|
| Date | 2016-09-26 20:20 +0200 |
| Message-ID | <slIFr-7fo-1@gated-at.bofh.it> |
| In reply to | #1491487 |
On Mon, 2016-09-26 at 21:01 +0300, Kalle Valo wrote: > hostap is an obsolete driver, it's waste of time doing style fixes to it > as nobody maintains it anymore. Dunno know if Jouni is still maintaining this at all but maybe a MAINTAINERS update to mark it obsolete so checkpatch warns on unnecessary changes. --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 6e0a912c3b13..ff293e70fae6 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -5722,7 +5722,7 @@ M: Jouni Malinen L: hostap@shmoo.com (subscribers-only) L: linux-wireless@vger.kernel.org W: http://hostap.epitest.fi/ -S: Maintained +S: Maintained / Obsolete F: drivers/net/wireless/intersil/hostap/ HP COMPAQ TC1100 TABLET WMI EXTRAS DRIVER
[toc] | [prev] | [next] | [standalone]
| From | Kalle Valo <kvalo@codeaurora.org> |
|---|---|
| Date | 2016-09-26 20:40 +0200 |
| Subject | Re: hostap: Delete an unnecessary jump label in prism2_ioctl_priv_hostapd() |
| Message-ID | <slIYN-7lv-7@gated-at.bofh.it> |
| In reply to | #1491492 |
Joe Perches <joe@perches.com> writes: > On Mon, 2016-09-26 at 21:01 +0300, Kalle Valo wrote: >> hostap is an obsolete driver, it's waste of time doing style fixes to it >> as nobody maintains it anymore. > > Dunno know if Jouni is still maintaining this at all > but maybe a MAINTAINERS update to mark it obsolete so > checkpatch warns on unnecessary changes. > --- > MAINTAINERS | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 6e0a912c3b13..ff293e70fae6 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -5722,7 +5722,7 @@ M: Jouni Malinen > L: hostap@shmoo.com (subscribers-only) > L: linux-wireless@vger.kernel.org > W: http://hostap.epitest.fi/ > -S: Maintained > +S: Maintained / Obsolete > F: drivers/net/wireless/intersil/hostap/ I talked with Jouni and we concluded marking this fully obsolete is the best (so removing the "Maintained" part completely). Also the shmoo list is not used anymore, that can be removed. -- Kalle Valo
[toc] | [prev] | [next] | [standalone]
| From | Joe Perches <joe@perches.com> |
|---|---|
| Date | 2016-09-26 20:50 +0200 |
| Message-ID | <slJ8t-7oT-3@gated-at.bofh.it> |
| In reply to | #1491503 |
On Mon, 2016-09-26 at 21:37 +0300, Kalle Valo wrote: > I talked with Jouni and we concluded marking this fully obsolete is the > best (so removing the "Maintained" part completelo the shmoo list > is not used anymore, that can be removed. Well, it would be best if Jouni submitted something.
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web