Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1490975 > unrolled thread
| Started by | Wolfgang Wiedmeyer <wolfgit@wiedmeyer.de> |
|---|---|
| First post | 2016-09-25 23:20 +0200 |
| Last post | 2016-09-26 18:40 +0200 |
| Articles | 4 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH 2/2] power: supply: max17042_battery: add technology property support Wolfgang Wiedmeyer <wolfgit@wiedmeyer.de> - 2016-09-25 23:20 +0200
Re: [PATCH 2/2] power: supply: max17042_battery: add technology property support Krzysztof Kozlowski <krzk@kernel.org> - 2016-09-26 13:00 +0200
Re: [PATCH 2/2] power: supply: max17042_battery: add technology property support Wolfgang Wiedmeyer <wolfgit@wiedmeyer.de> - 2016-09-26 15:00 +0200
Re: [PATCH 2/2] power: supply: max17042_battery: add technology property support Krzysztof Kozlowski <krzk@kernel.org> - 2016-09-26 18:40 +0200
| From | Wolfgang Wiedmeyer <wolfgit@wiedmeyer.de> |
|---|---|
| Date | 2016-09-25 23:20 +0200 |
| Subject | [PATCH 2/2] power: supply: max17042_battery: add technology property support |
| Message-ID | <slp06-3eH-25@gated-at.bofh.it> |
This patch reports the battery technology as Li-ion.
Signed-off-by: Wolfgang Wiedmeyer <wolfgit@wiedmeyer.de>
---
drivers/power/max17042_battery.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/power/max17042_battery.c b/drivers/power/max17042_battery.c
index 20cb1fd..43cb5df 100644
--- a/drivers/power/max17042_battery.c
+++ b/drivers/power/max17042_battery.c
@@ -92,6 +92,7 @@ static enum power_supply_property max17042_battery_props[] = {
POWER_SUPPLY_PROP_TEMP_MIN,
POWER_SUPPLY_PROP_TEMP_MAX,
POWER_SUPPLY_PROP_HEALTH,
+ POWER_SUPPLY_PROP_TECHNOLOGY,
POWER_SUPPLY_PROP_CURRENT_NOW,
POWER_SUPPLY_PROP_CURRENT_AVG,
};
@@ -296,6 +297,9 @@ static int max17042_get_property(struct power_supply *psy,
if (ret < 0)
return ret;
break;
+ case POWER_SUPPLY_PROP_TECHNOLOGY:
+ val->intval = POWER_SUPPLY_TECHNOLOGY_LION;
+ break;
case POWER_SUPPLY_PROP_CURRENT_NOW:
if (chip->pdata->enable_current_sense) {
ret = regmap_read(map, MAX17042_Current, &data);
--
Website: https://fossencdi.org
OpenPGP: 0F30 D1A0 2F73 F70A 6FEE 048E 5816 A24C 1075 7FC4
Key download: https://wiedmeyer.de/keys/ww.asc
[toc] | [next] | [standalone]
| From | Krzysztof Kozlowski <krzk@kernel.org> |
|---|---|
| Date | 2016-09-26 13:00 +0200 |
| Subject | Re: [PATCH 2/2] power: supply: max17042_battery: add technology property support |
| Message-ID | <slBNE-2PA-9@gated-at.bofh.it> |
| In reply to | #1490975 |
On Sun, Sep 25, 2016 at 11:10:11PM +0200, Wolfgang Wiedmeyer wrote:
> This patch reports the battery technology as Li-ion.
>
> Signed-off-by: Wolfgang Wiedmeyer <wolfgit@wiedmeyer.de>
> ---
> drivers/power/max17042_battery.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/power/max17042_battery.c b/drivers/power/max17042_battery.c
> index 20cb1fd..43cb5df 100644
> --- a/drivers/power/max17042_battery.c
> +++ b/drivers/power/max17042_battery.c
> @@ -92,6 +92,7 @@ static enum power_supply_property max17042_battery_props[] = {
> POWER_SUPPLY_PROP_TEMP_MIN,
> POWER_SUPPLY_PROP_TEMP_MAX,
> POWER_SUPPLY_PROP_HEALTH,
> + POWER_SUPPLY_PROP_TECHNOLOGY,
> POWER_SUPPLY_PROP_CURRENT_NOW,
> POWER_SUPPLY_PROP_CURRENT_AVG,
> };
> @@ -296,6 +297,9 @@ static int max17042_get_property(struct power_supply *psy,
> if (ret < 0)
> return ret;
> break;
> + case POWER_SUPPLY_PROP_TECHNOLOGY:
> + val->intval = POWER_SUPPLY_TECHNOLOGY_LION;
How can you be sure it is always Li-Ion? For wearables and mobiles, rather yes, but
the driver is also used in other devices. Technically, specs are saying
it might be used also with Li-Poly applications.
Best regards,
Krzysztof
[toc] | [prev] | [next] | [standalone]
| From | Wolfgang Wiedmeyer <wolfgit@wiedmeyer.de> |
|---|---|
| Date | 2016-09-26 15:00 +0200 |
| Message-ID | <slDFL-3W3-15@gated-at.bofh.it> |
| In reply to | #1491211 |
[Multipart message — attachments visible in raw view] — view raw
Krzysztof Kozlowski writes:
> On Sun, Sep 25, 2016 at 11:10:11PM +0200, Wolfgang Wiedmeyer wrote:
>> This patch reports the battery technology as Li-ion.
>>
>> Signed-off-by: Wolfgang Wiedmeyer <wolfgit@wiedmeyer.de>
>> ---
>> drivers/power/max17042_battery.c | 4 ++++
>> 1 file changed, 4 insertions(+)
>>
>> diff --git a/drivers/power/max17042_battery.c b/drivers/power/max17042_battery.c
>> index 20cb1fd..43cb5df 100644
>> --- a/drivers/power/max17042_battery.c
>> +++ b/drivers/power/max17042_battery.c
>> @@ -92,6 +92,7 @@ static enum power_supply_property max17042_battery_props[] = {
>> POWER_SUPPLY_PROP_TEMP_MIN,
>> POWER_SUPPLY_PROP_TEMP_MAX,
>> POWER_SUPPLY_PROP_HEALTH,
>> + POWER_SUPPLY_PROP_TECHNOLOGY,
>> POWER_SUPPLY_PROP_CURRENT_NOW,
>> POWER_SUPPLY_PROP_CURRENT_AVG,
>> };
>> @@ -296,6 +297,9 @@ static int max17042_get_property(struct power_supply *psy,
>> if (ret < 0)
>> return ret;
>> break;
>> + case POWER_SUPPLY_PROP_TECHNOLOGY:
>> + val->intval = POWER_SUPPLY_TECHNOLOGY_LION;
>
> How can you be sure it is always Li-Ion? For wearables and mobiles, rather yes, but
> the driver is also used in other devices. Technically, specs are saying
> it might be used also with Li-Poly applications.
I suppose that there is no way to detect this. Would it be ok if I add
an optional Device Tree property that allows to specify if it's Li-Ion
or Li-Poly? If the property is not supplied, then "unknown" is returned.
Thanks,
Wolfgang
--
Website: https://fossencdi.org
Jabber: wolfgang@wiedmeyer.de
OpenPGP: 0F30 D1A0 2F73 F70A 6FEE 048E 5816 A24C 1075 7FC4
Key download: https://wiedmeyer.de/keys/ww.asc
[toc] | [prev] | [next] | [standalone]
| From | Krzysztof Kozlowski <krzk@kernel.org> |
|---|---|
| Date | 2016-09-26 18:40 +0200 |
| Subject | Re: [PATCH 2/2] power: supply: max17042_battery: add technology property support |
| Message-ID | <slH6F-6aE-1@gated-at.bofh.it> |
| In reply to | #1491290 |
On Mon, Sep 26, 2016 at 02:56:44PM +0200, Wolfgang Wiedmeyer wrote:
>
> Krzysztof Kozlowski writes:
>
> > On Sun, Sep 25, 2016 at 11:10:11PM +0200, Wolfgang Wiedmeyer wrote:
> >> This patch reports the battery technology as Li-ion.
> >>
> >> Signed-off-by: Wolfgang Wiedmeyer <wolfgit@wiedmeyer.de>
> >> ---
> >> drivers/power/max17042_battery.c | 4 ++++
> >> 1 file changed, 4 insertions(+)
> >>
> >> diff --git a/drivers/power/max17042_battery.c b/drivers/power/max17042_battery.c
> >> index 20cb1fd..43cb5df 100644
> >> --- a/drivers/power/max17042_battery.c
> >> +++ b/drivers/power/max17042_battery.c
> >> @@ -92,6 +92,7 @@ static enum power_supply_property max17042_battery_props[] = {
> >> POWER_SUPPLY_PROP_TEMP_MIN,
> >> POWER_SUPPLY_PROP_TEMP_MAX,
> >> POWER_SUPPLY_PROP_HEALTH,
> >> + POWER_SUPPLY_PROP_TECHNOLOGY,
> >> POWER_SUPPLY_PROP_CURRENT_NOW,
> >> POWER_SUPPLY_PROP_CURRENT_AVG,
> >> };
> >> @@ -296,6 +297,9 @@ static int max17042_get_property(struct power_supply *psy,
> >> if (ret < 0)
> >> return ret;
> >> break;
> >> + case POWER_SUPPLY_PROP_TECHNOLOGY:
> >> + val->intval = POWER_SUPPLY_TECHNOLOGY_LION;
> >
> > How can you be sure it is always Li-Ion? For wearables and mobiles, rather yes, but
> > the driver is also used in other devices. Technically, specs are saying
> > it might be used also with Li-Poly applications.
>
> I suppose that there is no way to detect this. Would it be ok if I add
> an optional Device Tree property that allows to specify if it's Li-Ion
> or Li-Poly? If the property is not supplied, then "unknown" is returned.
I am not sure in such case what will be the benefit of exposing this to
user-space... but it won't harm neither and sounds like a valid usage of
DT properties. Fine with me.
Best regards,
Krzysztof
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web