Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1490380 > unrolled thread

Re: [PATCH 1/3] devicetree: bindings: scsi: hisi_sas hip07 support

Started byRob Herring <robh@kernel.org>
First post2016-09-23 20:40 +0200
Last post2016-09-24 21:00 +0200
Articles 2 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [PATCH 1/3] devicetree: bindings: scsi: hisi_sas hip07 support Rob Herring <robh@kernel.org> - 2016-09-23 20:40 +0200
    Re: [PATCH 1/3] devicetree: bindings: scsi: hisi_sas hip07 support John Garry <john.garry@huawei.com> - 2016-09-24 21:00 +0200

#1490380 — Re: [PATCH 1/3] devicetree: bindings: scsi: hisi_sas hip07 support

FromRob Herring <robh@kernel.org>
Date2016-09-23 20:40 +0200
SubjectRe: [PATCH 1/3] devicetree: bindings: scsi: hisi_sas hip07 support
Message-ID<skDy9-7oK-3@gated-at.bofh.it>
On Tue, Sep 20, 2016 at 06:48:58PM +0800, John Garry wrote:
> Add support for hip07 chipset to bindings.
> 
> Chipset hip07 has v2 hw.
> 
> The sas-v2 quirk amt is expanded to cover hip07.
> 
> Signed-off-by: John Garry <john.garry@huawei.com>
> Signed-off-by: Xiang Chen <chenxiang66@hisilicon.com>
> ---
>  Documentation/devicetree/bindings/scsi/hisilicon-sas.txt | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/scsi/hisilicon-sas.txt b/Documentation/devicetree/bindings/scsi/hisilicon-sas.txt
> index bf2411f..e604527 100644
> --- a/Documentation/devicetree/bindings/scsi/hisilicon-sas.txt
> +++ b/Documentation/devicetree/bindings/scsi/hisilicon-sas.txt
> @@ -6,6 +6,7 @@ Main node required properties:
>    - compatible : value should be as follows:
>  	(a) "hisilicon,hip05-sas-v1" for v1 hw in hip05 chipset
>  	(b) "hisilicon,hip06-sas-v2" for v2 hw in hip06 chipset
> +	(c) "hisilicon,hip07-sas-v2" for v2 hw in hip07 chipset
>    - sas-addr : array of 8 bytes for host SAS address
>    - reg : Address and length of the SAS register
>    - hisilicon,sas-syscon: phandle of syscon used for sas control
> @@ -47,7 +48,7 @@ Main node required properties:
>  			increasing order.
>  
>  Optional main node properties:
> - - hip06-sas-v2-quirk-amt : when set, indicates that the v2 controller has the
> + - hip06/7-sas-v2-quirk-amt : when set, indicates that the v2 controller has the

Just use the existing property name for hip07.

>  			    "am-max-transmissions" limitation.
>  
>  Example:
> -- 
> 1.9.1
> 

[toc] | [next] | [standalone]


#1490717

FromJohn Garry <john.garry@huawei.com>
Date2016-09-24 21:00 +0200
Message-ID<sl0l3-4Bt-7@gated-at.bofh.it>
In reply to#1490380
On 23/09/2016 19:36, Rob Herring wrote:
> On Tue, Sep 20, 2016 at 06:48:58PM +0800, John Garry wrote:
>> Add support for hip07 chipset to bindings.
>>
>> Chipset hip07 has v2 hw.
>>
>> The sas-v2 quirk amt is expanded to cover hip07.
>>
>> Signed-off-by: John Garry <john.garry@huawei.com>
>> Signed-off-by: Xiang Chen <chenxiang66@hisilicon.com>
>> ---
>>  Documentation/devicetree/bindings/scsi/hisilicon-sas.txt | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/scsi/hisilicon-sas.txt b/Documentation/devicetree/bindings/scsi/hisilicon-sas.txt
>> index bf2411f..e604527 100644
>> --- a/Documentation/devicetree/bindings/scsi/hisilicon-sas.txt
>> +++ b/Documentation/devicetree/bindings/scsi/hisilicon-sas.txt
>> @@ -6,6 +6,7 @@ Main node required properties:
>>    - compatible : value should be as follows:
>>  	(a) "hisilicon,hip05-sas-v1" for v1 hw in hip05 chipset
>>  	(b) "hisilicon,hip06-sas-v2" for v2 hw in hip06 chipset
>> +	(c) "hisilicon,hip07-sas-v2" for v2 hw in hip07 chipset
>>    - sas-addr : array of 8 bytes for host SAS address
>>    - reg : Address and length of the SAS register
>>    - hisilicon,sas-syscon: phandle of syscon used for sas control
>> @@ -47,7 +48,7 @@ Main node required properties:
>>  			increasing order.
>>
>>  Optional main node properties:
>> - - hip06-sas-v2-quirk-amt : when set, indicates that the v2 controller has the
>> + - hip06/7-sas-v2-quirk-amt : when set, indicates that the v2 controller has the
>
> Just use the existing property name for hip07.

OK, but you mean existing hip06 property (hip06-sas-v2-quirk-amt), right?

>
>>  			    "am-max-transmissions" limitation.
>>
>>  Example:
>> --
>> 1.9.1
>>
>
> .
>

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web