Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1483563 > unrolled thread

[PATCH tty-next 0/6] Minor devpts cleanups, fixes and enhancments

Started byebiederm@xmission.com (Eric W. Biederman)
First post2016-09-14 21:10 +0200
Last post2016-09-23 11:40 +0200
Articles 3 — 2 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH tty-next 0/6] Minor devpts cleanups, fixes and enhancments ebiederm@xmission.com (Eric W. Biederman) - 2016-09-14 21:10 +0200
    Re: [PATCH tty-next 0/6] Minor devpts cleanups, fixes and enhancments ebiederm@xmission.com (Eric W. Biederman) - 2016-09-22 20:50 +0200
      Re: [PATCH tty-next 0/6] Minor devpts cleanups, fixes and enhancments Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-09-23 11:40 +0200

#1483563 — [PATCH tty-next 0/6] Minor devpts cleanups, fixes and enhancments

Fromebiederm@xmission.com (Eric W. Biederman)
Date2016-09-14 21:10 +0200
Subject[PATCH tty-next 0/6] Minor devpts cleanups, fixes and enhancments
Message-ID<shnJg-4KO-5@gated-at.bofh.it>
Greg please apply the following patches to tty-next.  If tty-next is not
the proper tree please let me know and I will take these patches through
my user namespace tree.

The follow patches perform a few small cleanups and one enhancement to
devpts, with a net decrease in code size.

The big achievement from a code maintenance point of view is being able
to use mount_nodev in devpts_mount.

The only really significant bug fix is handling the very unlikely case
when kzalloc fails in new_pts_fs_info called from devpts_fill_super and
s_fs_info is NULL when devpts_kill_sb is called from deactivate_locked
super.

The final patch is an enhancment to use the fsuid and fsgid of the mounter
of devpts as the owner of /dev/pts/ptmx.  This is a feature that has
been asked for by users of user namespaces a couple of times, so that
they are not required to have uid 0 mapped into a user namespace to use
devpts.

Eric

fs/devpts/inode.c | 71 ++++++++++++++++++++-----------------------------------
 1 file changed, 26 insertions(+), 45 deletions(-)

Eric W. Biederman (6):
      devpts: Move parse_mount_options into fill_super
      devpts: Move the creation of /dev/pts/ptmx into fill_super
      devpts: Simplify devpts_mount by using mount_nodev
      devpts: Make devpts_kill_sb safe if fsi is NULL
      devpts: Remove sync_filesystems
      devpts: Change the owner of /dev/pts/ptmx to the mounter of /dev/pts

[toc] | [next] | [standalone]


#1489365

Fromebiederm@xmission.com (Eric W. Biederman)
Date2016-09-22 20:50 +0200
Message-ID<skhei-1xN-13@gated-at.bofh.it>
In reply to#1483563
ebiederm@xmission.com (Eric W. Biederman) writes:

> Greg please apply the following patches to tty-next.  If tty-next is not
> the proper tree please let me know and I will take these patches through
> my user namespace tree.

I have not heard anything so I am taking these patches through my tree.

Eric

[toc] | [prev] | [next] | [standalone]


#1489893

FromGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Date2016-09-23 11:40 +0200
Message-ID<skv7z-1Uk-15@gated-at.bofh.it>
In reply to#1489365
On Thu, Sep 22, 2016 at 01:33:59PM -0500, Eric W. Biederman wrote:
> 
> ebiederm@xmission.com (Eric W. Biederman) writes:
> 
> > Greg please apply the following patches to tty-next.  If tty-next is not
> > the proper tree please let me know and I will take these patches through
> > my user namespace tree.
> 
> I have not heard anything so I am taking these patches through my tree.

Ugh, sorry about that, they missed my filters.  I'll be glad to queue
them up today, my fault.

greg k-h

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web