Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1489066 > unrolled thread

[PATCH v3 2/2] staging: ion: Fix a coding style issue

Started byAntti Keränen <detegr@gmail.com>
First post2016-09-22 18:10 +0200
Last post2016-09-22 22:30 +0200
Articles 2 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  [PATCH v3 2/2] staging: ion: Fix a coding style issue Antti Keränen <detegr@gmail.com> - 2016-09-22 18:10 +0200
    Re: [PATCH v3 2/2] staging: ion: Fix a coding style issue Laura Abbott <labbott@redhat.com> - 2016-09-22 22:30 +0200

#1489066 — [PATCH v3 2/2] staging: ion: Fix a coding style issue

FromAntti Keränen <detegr@gmail.com>
Date2016-09-22 18:10 +0200
Subject[PATCH v3 2/2] staging: ion: Fix a coding style issue
Message-ID<skeJr-7S-3@gated-at.bofh.it>
Correctly align an unaligned block comment

Signed-off-by: Antti Keränen <detegr@gmail.com>
---
 drivers/staging/android/uapi/ion.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/android/uapi/ion.h b/drivers/staging/android/uapi/ion.h
index 647f130..e629394 100644
--- a/drivers/staging/android/uapi/ion.h
+++ b/drivers/staging/android/uapi/ion.h
@@ -57,7 +57,7 @@ enum ion_heap_type {
 					 * cached, ion will do cache
 					 * maintenance when the buffer is
 					 * mapped for dma
-					*/
+					 */
 #define ION_FLAG_CACHED_NEEDS_SYNC 2	/*
 					 * mappings of this buffer will created
 					 * at mmap time, if this is set
-- 
2.9.3

[toc] | [next] | [standalone]


#1489525

FromLaura Abbott <labbott@redhat.com>
Date2016-09-22 22:30 +0200
Message-ID<skiN3-2zX-21@gated-at.bofh.it>
In reply to#1489066
On 09/22/2016 08:59 AM, Antti Keränen wrote:
> Correctly align an unaligned block comment
>
> Signed-off-by: Antti Keränen <detegr@gmail.com>
> ---
>  drivers/staging/android/uapi/ion.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/android/uapi/ion.h b/drivers/staging/android/uapi/ion.h
> index 647f130..e629394 100644
> --- a/drivers/staging/android/uapi/ion.h
> +++ b/drivers/staging/android/uapi/ion.h
> @@ -57,7 +57,7 @@ enum ion_heap_type {
>  					 * cached, ion will do cache
>  					 * maintenance when the buffer is
>  					 * mapped for dma
> -					*/
> +					 */
>  #define ION_FLAG_CACHED_NEEDS_SYNC 2	/*
>  					 * mappings of this buffer will created
>  					 * at mmap time, if this is set
>

I've always hated these comments. Can you fix them to be regular
looking right above each #define?

Thanks,
Laura

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web