Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1488967 > unrolled thread

cifs mount regression in 4.8 and 4.4 stable

Back to article view | Back to linux.kernel

Contents

  cifs mount regression in 4.8 and 4.4 stable Seth Forshee <seth.forshee@canonical.com> - 2016-09-22 17:10 +0200
    Re: cifs mount regression in 4.8 and 4.4 stable Sachin Prabhu <sprabhu@redhat.com> - 2016-09-22 17:20 +0200
      Re: cifs mount regression in 4.8 and 4.4 stable Seth Forshee <seth.forshee@canonical.com> - 2016-09-22 17:30 +0200
        Re: cifs mount regression in 4.8 and 4.4 stable Seth Forshee <seth.forshee@canonical.com> - 2016-09-23 14:10 +0200
    Re: cifs mount regression in 4.8 and 4.4 stable Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-09-22 17:20 +0200

#1488967 — cifs mount regression in 4.8 and 4.4 stable

We've received reports from users of a cifs mount regression in our
4.4-based kernel, e.g. [1]. It is fixed by reverting the follwing commit
from 4.8 which was applied to 4.4 stable:

 a6b5058 fs/cifs: make share unaccessible at root level mountable

Testing against 4.8-rc7 shows that the problem is present there as well.

Thanks,
Seth

[1] http://bugs.launchpad.net/bugs/1626112

[toc] | [next] | [standalone]

#1488973

On Thu, 2016-09-22 at 10:09 -0500, Seth Forshee wrote:
> We've received reports from users of a cifs mount regression in our
> 4.4-based kernel, e.g. [1]. It is fixed by reverting the follwing
> commit
> from 4.8 which was applied to 4.4 stable:
> 
>  a6b5058 fs/cifs: make share unaccessible at root level mountable
> 
> Testing against 4.8-rc7 shows that the problem is present there as
> well.
> 
> Thanks,
> Seth
> 
> [1] http://bugs.launchpad.net/bugs/1626112

Hello Seth, 

We have identified some regressions introduced by the mentioned patch
These include

a) mounting of DFS shares breaks. The fix is included in Steve's tree
at
https://git.samba.org/?p=sfrench/cifs-2.6.git;a=commit;h=de5233745cd59c
f5853d963ad216067788a87594

b) mounting of the same share with different paths breaks. Fixed by
upstream commit	c1d8b24d18192764fe82067ec6aa8d4c3bf094e0

c) memory leaks in mounting fixed by upstream 	4214ebf4654798309
364d0c678b799e402f38288

Can you please share any other reports not mentioned above?

Sachin Prabhu

[toc] | [prev] | [next] | [standalone]

#1488984

On Thu, Sep 22, 2016 at 04:17:09PM +0100, Sachin Prabhu wrote:
> On Thu, 2016-09-22 at 10:09 -0500, Seth Forshee wrote:
> > We've received reports from users of a cifs mount regression in our
> > 4.4-based kernel, e.g. [1]. It is fixed by reverting the follwing
> > commit
> > from 4.8 which was applied to 4.4 stable:
> > 
> >  a6b5058 fs/cifs: make share unaccessible at root level mountable
> > 
> > Testing against 4.8-rc7 shows that the problem is present there as
> > well.
> > 
> > Thanks,
> > Seth
> > 
> > [1] http://bugs.launchpad.net/bugs/1626112
> 
> Hello Seth, 
> 
> We have identified some regressions introduced by the mentioned patch
> These include

I saw those, but none of the ones already in Linus's tree fix the
problem.

> a) mounting of DFS shares breaks. The fix is included in Steve's tree
> at
> https://git.samba.org/?p=sfrench/cifs-2.6.git;a=commit;h=de5233745cd59c
> f5853d963ad216067788a87594

However this one isn't in Linus's tree yet.

I'm not certain what circumstances cause the failure, but based on what
I see in dmesg it looks likely that this one is the fix. I'll get some
testing with this applied.

Since the broken patch was applied to stable kernels, all of these
kernels need to receive those fixes as well.

Thanks,
Seth

[toc] | [prev] | [next] | [standalone]

#1489980

On Thu, Sep 22, 2016 at 10:27:56AM -0500, Seth Forshee wrote:
> On Thu, Sep 22, 2016 at 04:17:09PM +0100, Sachin Prabhu wrote:
> > On Thu, 2016-09-22 at 10:09 -0500, Seth Forshee wrote:
> > > We've received reports from users of a cifs mount regression in our
> > > 4.4-based kernel, e.g. [1]. It is fixed by reverting the follwing
> > > commit
> > > from 4.8 which was applied to 4.4 stable:
> > > 
> > >  a6b5058 fs/cifs: make share unaccessible at root level mountable
> > > 
> > > Testing against 4.8-rc7 shows that the problem is present there as
> > > well.
> > > 
> > > Thanks,
> > > Seth
> > > 
> > > [1] http://bugs.launchpad.net/bugs/1626112
> > 
> > Hello Seth, 
> > 
> > We have identified some regressions introduced by the mentioned patch
> > These include
> 
> I saw those, but none of the ones already in Linus's tree fix the
> problem.
> 
> > a) mounting of DFS shares breaks. The fix is included in Steve's tree
> > at
> > https://git.samba.org/?p=sfrench/cifs-2.6.git;a=commit;h=de5233745cd59c
> > f5853d963ad216067788a87594
> 
> However this one isn't in Linus's tree yet.
> 
> I'm not certain what circumstances cause the failure, but based on what
> I see in dmesg it looks likely that this one is the fix. I'll get some
> testing with this applied.

Looks like this is is the fix we need. Thanks for your help.

Seth

[toc] | [prev] | [next] | [standalone]

#1488976

On Thu, Sep 22, 2016 at 10:09:18AM -0500, Seth Forshee wrote:
> We've received reports from users of a cifs mount regression in our
> 4.4-based kernel, e.g. [1]. It is fixed by reverting the follwing commit
> from 4.8 which was applied to 4.4 stable:
> 
>  a6b5058 fs/cifs: make share unaccessible at root level mountable
> 
> Testing against 4.8-rc7 shows that the problem is present there as well.
> 
> Thanks,
> Seth
> 
> [1] http://bugs.launchpad.net/bugs/1626112

Thanks, I'll wait for the fix to land in Linus's tree before doing
anything in the stable trees.

greg k-h

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web