Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1488359 > unrolled thread
| Started by | Harman Kalra <harman4linux@gmail.com> |
|---|---|
| First post | 2016-09-21 21:50 +0200 |
| Last post | 2016-09-22 17:50 +0200 |
| Articles | 4 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR. Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR. Harman Kalra <harman4linux@gmail.com> - 2016-09-21 21:50 +0200
Re: [PATCH] Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR. Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR. Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2016-09-22 12:50 +0200
Re: [PATCH] Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR. Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR. Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2016-09-22 16:00 +0200
Re: [PATCH] Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR. Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR. Tejun Heo <tj@kernel.org> - 2016-09-22 17:50 +0200
| From | Harman Kalra <harman4linux@gmail.com> |
|---|---|
| Date | 2016-09-21 21:50 +0200 |
| Subject | [PATCH] Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR. Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR. |
| Message-ID | <sjVGN-4HZ-17@gated-at.bofh.it> |
Signed-off-by: Harman Kalra <harman4linux@gmail.com> --- drivers/ata/pata_at91.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/ata/pata_at91.c b/drivers/ata/pata_at91.c index 9f27b14..1611e0e 100644 --- a/drivers/ata/pata_at91.c +++ b/drivers/ata/pata_at91.c @@ -347,10 +347,8 @@ static int at91sam9_smc_fields_init(struct device *dev) field.reg = AT91SAM9_SMC_MODE(AT91SAM9_SMC_GENERIC); fields.mode = devm_regmap_field_alloc(dev, smc, field); - if (IS_ERR(fields.mode)) - return PTR_ERR(fields.mode); - return 0; + return PTR_ERR_OR_ZERO(fields.mode); } static int pata_at91_probe(struct platform_device *pdev) -- 1.7.9.5
[toc] | [next] | [standalone]
| From | Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> |
|---|---|
| Date | 2016-09-22 12:50 +0200 |
| Subject | Re: [PATCH] Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR. Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR. |
| Message-ID | <sk9JM-5c6-5@gated-at.bofh.it> |
| In reply to | #1488359 |
Hello.
On 9/21/2016 10:48 PM, Harman Kalra wrote:
Looks like your patch summary and description got merged together in the
subject.
> Signed-off-by: Harman Kalra <harman4linux@gmail.com>
[...]
MBR, Sergei
[toc] | [prev] | [next] | [standalone]
| From | Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> |
|---|---|
| Date | 2016-09-22 16:00 +0200 |
| Subject | Re: [PATCH] Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR. Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR. |
| Message-ID | <skcHE-74T-9@gated-at.bofh.it> |
| In reply to | #1488750 |
On 09/22/2016 01:44 PM, Sergei Shtylyov wrote:
> Looks like your patch summary and description got merged together in the
> subject.
Also, the subject (summary) should contain driver name as a prefix:
"pata_at91: Use ..."
>> Signed-off-by: Harman Kalra <harman4linux@gmail.com>
> [...]
MBR, Sergei
[toc] | [prev] | [next] | [standalone]
| From | Tejun Heo <tj@kernel.org> |
|---|---|
| Date | 2016-09-22 17:50 +0200 |
| Subject | Re: [PATCH] Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR. Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR. |
| Message-ID | <skeq7-8dN-63@gated-at.bofh.it> |
| In reply to | #1488359 |
On Thu, Sep 22, 2016 at 01:18:31AM +0530, Harman Kalra wrote: > Signed-off-by: Harman Kalra <harman4linux@gmail.com> Fixed up subject and applied to libata/for-4.9. Thanks. -- tejun
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web