Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1490492 > unrolled thread

Re: [PATCH v2] ASoC: simple-card: add support for aux devices

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH v2] ASoC: simple-card: add support for aux devices Rob Herring <robh@kernel.org> - 2016-09-24 00:30 +0200
    Re: [PATCH v2] ASoC: simple-card: add support for aux devices Nikita Yushchenko <nikita.yoush@cogentembedded.com> - 2016-09-24 08:10 +0200
    Re: [PATCH v2] ASoC: simple-card: add support for aux devices Mark Brown <broonie@kernel.org> - 2016-09-25 08:10 +0200
    Re: [PATCH v2] ASoC: simple-card: add support for aux devices Mark Brown <broonie@kernel.org> - 2016-09-25 08:10 +0200

#1490492 — Re: [PATCH v2] ASoC: simple-card: add support for aux devices

On Fri, Sep 23, 2016 at 10:11:12AM +0300, Nikita Yushchenko wrote:
> This patch makes it possible to use simple-card in setups where separate
> amplifier chip is connected to codec's output.
> 
> Changes from v1:
> - moved example usage from commit message to Documentation/, as
>   suggested by Kuninori Morimoto,
> - fixed typo in example usage.

Ah, one more property to the "simple" card. At what point in adding 
properties is it not simple?

> 
> Signed-off-by: Nikita Yushchenko <nikita.yoush@cogentembedded.com>
> ---
>  .../devicetree/bindings/sound/simple-card.txt      | 37 ++++++++++++++++++++++
>  sound/soc/generic/simple-card.c                    | 34 ++++++++++++++++++++
>  2 files changed, 71 insertions(+)


> 
> diff --git a/Documentation/devicetree/bindings/sound/simple-card.txt b/Documentation/devicetree/bindings/sound/simple-card.txt
> index 59d8628..c7a9393 100644
> --- a/Documentation/devicetree/bindings/sound/simple-card.txt
> +++ b/Documentation/devicetree/bindings/sound/simple-card.txt
> @@ -22,6 +22,8 @@ Optional properties:
>  					  headphones are attached.
>  - simple-audio-card,mic-det-gpio	: Reference to GPIO that signals when
>  					  a microphone is attached.
> +- simple-audio-card,aux-devs		: List of phandles pointing to auxiliary devices, such
> +					  as amplifiers, to be added to the sound card.

I think the property should be specific as to the type of device. What 
if you have 2 amps? Maybe simple-card can't have 2 outputs. What if you 
have a chain of devices and need to know the order of them?

Rob

[toc] | [next] | [standalone]

#1490565

>> Changes from v1:
>> - moved example usage from commit message to Documentation/, as
>>   suggested by Kuninori Morimoto,
>> - fixed typo in example usage.
> 
> Ah, one more property to the "simple" card. At what point in adding 
> properties is it not simple?

AFAIU, idea is to have a pure-device-tree-controlled audio device (i.e.
without dedicated machine driver).

Perhaps it should be just renamed at some point.

>> +- simple-audio-card,aux-devs		: List of phandles pointing to auxiliary devices, such
>> +					  as amplifiers, to be added to the sound card.
> 
> I think the property should be specific as to the type of device. What 
> if you have 2 amps? Maybe simple-card can't have 2 outputs. What if you 
> have a chain of devices and need to know the order of them?

snd_soc_card has unordered list of aux devices. Things you mention are
controlled are configured via routing.

Nikita

[toc] | [prev] | [next] | [standalone]

#1490807

[Multipart message — attachments visible in raw view] — view raw

On Fri, Sep 23, 2016 at 05:25:41PM -0500, Rob Herring wrote:
> On Fri, Sep 23, 2016 at 10:11:12AM +0300, Nikita Yushchenko wrote:

> > +- simple-audio-card,aux-devs		: List of phandles pointing to auxiliary devices, such
> > +					  as amplifiers, to be added to the sound card.

> I think the property should be specific as to the type of device. What 
> if you have 2 amps? Maybe simple-card can't have 2 outputs. What if you 
> have a chain of devices and need to know the order of them?

Sorry, missed this bit...  We already have the audio routing properties
which define how things are interconnected, this exists to get pure
analogue components into the set of things that can be routed to.  The
abstraction we're using hides what the device is well enough.

[toc] | [prev] | [next] | [standalone]

#1490809

[Multipart message — attachments visible in raw view] — view raw

On Fri, Sep 23, 2016 at 05:25:41PM -0500, Rob Herring wrote:

> Ah, one more property to the "simple" card. At what point in adding 
> properties is it not simple?

There are a *lot* of tunables for audio subsystems and a lot of ways
they can be designed, this is why complaining at the less realistic DT
advocates who object to having a card at all.  Probably most cards won't
use anything like all the properties but simple-card does cover a large
proportion of common place cards and keeps those DT advocates who object
to having a card object at all happier.

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web