Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1490542 > unrolled thread

[PATCH] clk: versatile: add missing header dependencies

Back to article view | Back to linux.kernel

Contents

  [PATCH] clk: versatile: add missing header dependencies Baoyou Xie <baoyou.xie@linaro.org> - 2016-09-24 06:40 +0200
    Re: [PATCH] clk: versatile: add missing header dependencies Arnd Bergmann <arnd@arndb.de> - 2016-09-24 11:10 +0200

#1490542 — [PATCH] clk: versatile: add missing header dependencies

We get 1 warning when building kernel with W=1:
drivers/clk/versatile/clk-realview.c:54:13: warning: no previous prototype for 'realview_clk_init' [-Wmissing-prototypes]

In fact, this function is declared in
include/linux/platform_data/clk-realview.h,
so this patch adds missing header dependencies.

Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
---
 drivers/clk/versatile/clk-realview.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/clk/versatile/clk-realview.c b/drivers/clk/versatile/clk-realview.c
index c56efc7..f662fd1 100644
--- a/drivers/clk/versatile/clk-realview.c
+++ b/drivers/clk/versatile/clk-realview.c
@@ -10,6 +10,7 @@
 #include <linux/err.h>
 #include <linux/io.h>
 #include <linux/clk-provider.h>
+#include <linux/platform_data/clk-realview.h>
 
 #include "clk-icst.h"
 
-- 
2.7.4

[toc] | [next] | [standalone]

#1490602

On Saturday, September 24, 2016 12:31:40 PM CEST Baoyou Xie wrote:
> We get 1 warning when building kernel with W=1:
> drivers/clk/versatile/clk-realview.c:54:13: warning: no previous prototype for 'realview_clk_init' [-Wmissing-prototypes]
> 
> In fact, this function is declared in
> include/linux/platform_data/clk-realview.h,
> so this patch adds missing header dependencies.
> 
> Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
> 

I think I commented on this one already: the only caller of the
function is getting removed in v4.9, so we should remove the
definition of the function subsequently in the next release.

We could in theory try to remove this at the same time, but
the effort to synchronize the git trees is not worth the benefit.

	Arnd

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web