Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1484422 > unrolled thread
| Started by | Sinan Kaya <okaya@codeaurora.org> |
|---|---|
| First post | 2016-09-15 19:30 +0200 |
| Last post | 2016-09-23 21:00 +0200 |
| Articles | 5 — 3 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH V3 01/10] Documentation: DT: qcom_hidma: update binding for MSI Sinan Kaya <okaya@codeaurora.org> - 2016-09-15 19:30 +0200
Re: [PATCH V3 01/10] Documentation: DT: qcom_hidma: update binding for MSI Rob Herring <robh@kernel.org> - 2016-09-23 17:40 +0200
Re: [PATCH V3 01/10] Documentation: DT: qcom_hidma: update binding for MSI Sinan Kaya <okaya@codeaurora.org> - 2016-09-23 19:30 +0200
Re: [PATCH V3 01/10] Documentation: DT: qcom_hidma: update binding for MSI Mark Rutland <mark.rutland@arm.com> - 2016-09-23 20:10 +0200
Re: [PATCH V3 01/10] Documentation: DT: qcom_hidma: update binding for MSI Sinan Kaya <okaya@codeaurora.org> - 2016-09-23 21:00 +0200
| From | Sinan Kaya <okaya@codeaurora.org> |
|---|---|
| Date | 2016-09-15 19:30 +0200 |
| Subject | [PATCH V3 01/10] Documentation: DT: qcom_hidma: update binding for MSI |
| Message-ID | <shIE2-1vO-19@gated-at.bofh.it> |
Adding a new binding for qcom,hidma-1.1 to distinguish HW supporting MSI interrupts from the older revision. Signed-off-by: Sinan Kaya <okaya@codeaurora.org> --- Documentation/devicetree/bindings/dma/qcom_hidma_mgmt.txt | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/dma/qcom_hidma_mgmt.txt b/Documentation/devicetree/bindings/dma/qcom_hidma_mgmt.txt index fd5618b..47bfb5a 100644 --- a/Documentation/devicetree/bindings/dma/qcom_hidma_mgmt.txt +++ b/Documentation/devicetree/bindings/dma/qcom_hidma_mgmt.txt @@ -47,12 +47,23 @@ When the OS is not in control of the management interface (i.e. it's a guest), the channel nodes appear on their own, not under a management node. Required properties: -- compatible: must contain "qcom,hidma-1.0" +- compatible: must contain "qcom,hidma-1.0" for initial HW or "qcom,hidma-1.1" +for MSI capable HW. - reg: Addresses for the transfer and event channel - interrupts: Should contain the event interrupt - desc-count: Number of asynchronous requests this channel can handle - iommus: required a iommu node +Optional properties for MSI: +- msi-parent: pointer to the MSI controller object with the DeviceID in use. + +Example: + msi_parent: <&msi0 0x80024> + +msi0 is the MSI controller in the system. Bits 0-5 is the channel ID. 4 +is the channel ID. Bits 5-8 is the instance number. This is for the HIDMA +instance 1. + Example: Hypervisor OS configuration: -- 1.9.1
[toc] | [next] | [standalone]
| From | Rob Herring <robh@kernel.org> |
|---|---|
| Date | 2016-09-23 17:40 +0200 |
| Subject | Re: [PATCH V3 01/10] Documentation: DT: qcom_hidma: update binding for MSI |
| Message-ID | <skAJX-5CZ-15@gated-at.bofh.it> |
| In reply to | #1484422 |
On Thu, Sep 15, 2016 at 01:22:37PM -0400, Sinan Kaya wrote: > Adding a new binding for qcom,hidma-1.1 to distinguish HW supporting > MSI interrupts from the older revision. > > Signed-off-by: Sinan Kaya <okaya@codeaurora.org> > --- > Documentation/devicetree/bindings/dma/qcom_hidma_mgmt.txt | 13 ++++++++++++- > 1 file changed, 12 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/dma/qcom_hidma_mgmt.txt b/Documentation/devicetree/bindings/dma/qcom_hidma_mgmt.txt > index fd5618b..47bfb5a 100644 > --- a/Documentation/devicetree/bindings/dma/qcom_hidma_mgmt.txt > +++ b/Documentation/devicetree/bindings/dma/qcom_hidma_mgmt.txt > @@ -47,12 +47,23 @@ When the OS is not in control of the management interface (i.e. it's a guest), > the channel nodes appear on their own, not under a management node. > > Required properties: > -- compatible: must contain "qcom,hidma-1.0" > +- compatible: must contain "qcom,hidma-1.0" for initial HW or "qcom,hidma-1.1" > +for MSI capable HW. Do you have an SoC part number yet? If so, please use that instead. > - reg: Addresses for the transfer and event channel > - interrupts: Should contain the event interrupt > - desc-count: Number of asynchronous requests this channel can handle > - iommus: required a iommu node > > +Optional properties for MSI: > +- msi-parent: pointer to the MSI controller object with the DeviceID in use. > + > +Example: > + msi_parent: <&msi0 0x80024> > + > +msi0 is the MSI controller in the system. Bits 0-5 is the channel ID. 4 > +is the channel ID. Bits 5-8 is the instance number. This is for the HIDMA > +instance 1. > + > Example: > > Hypervisor OS configuration: > -- > 1.9.1 >
[toc] | [prev] | [next] | [standalone]
| From | Sinan Kaya <okaya@codeaurora.org> |
|---|---|
| Date | 2016-09-23 19:30 +0200 |
| Subject | Re: [PATCH V3 01/10] Documentation: DT: qcom_hidma: update binding for MSI |
| Message-ID | <skCsp-6Lq-5@gated-at.bofh.it> |
| In reply to | #1490263 |
On 9/23/2016 11:39 AM, Rob Herring wrote: >> Required properties: >> > -- compatible: must contain "qcom,hidma-1.0" >> > +- compatible: must contain "qcom,hidma-1.0" for initial HW or "qcom,hidma-1.1" >> > +for MSI capable HW. > Do you have an SoC part number yet? If so, please use that instead. > Unfortunately, I have the same problem like "qcom, hidma-1.0". The SoC name is not settled yet and same IP gets used in multiple SoCs. Each IP reports its own version number. This is one of the reasons why I sticked to versioning instead of SoC name. -- Sinan Kaya Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.
[toc] | [prev] | [next] | [standalone]
| From | Mark Rutland <mark.rutland@arm.com> |
|---|---|
| Date | 2016-09-23 20:10 +0200 |
| Subject | Re: [PATCH V3 01/10] Documentation: DT: qcom_hidma: update binding for MSI |
| Message-ID | <skD57-7dw-3@gated-at.bofh.it> |
| In reply to | #1484422 |
On Thu, Sep 15, 2016 at 01:22:37PM -0400, Sinan Kaya wrote: > Adding a new binding for qcom,hidma-1.1 to distinguish HW supporting > MSI interrupts from the older revision. > > Signed-off-by: Sinan Kaya <okaya@codeaurora.org> > --- > Documentation/devicetree/bindings/dma/qcom_hidma_mgmt.txt | 13 ++++++++++++- > 1 file changed, 12 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/dma/qcom_hidma_mgmt.txt b/Documentation/devicetree/bindings/dma/qcom_hidma_mgmt.txt > index fd5618b..47bfb5a 100644 > --- a/Documentation/devicetree/bindings/dma/qcom_hidma_mgmt.txt > +++ b/Documentation/devicetree/bindings/dma/qcom_hidma_mgmt.txt > @@ -47,12 +47,23 @@ When the OS is not in control of the management interface (i.e. it's a guest), > the channel nodes appear on their own, not under a management node. > > Required properties: > -- compatible: must contain "qcom,hidma-1.0" > +- compatible: must contain "qcom,hidma-1.0" for initial HW or "qcom,hidma-1.1" > +for MSI capable HW. > - reg: Addresses for the transfer and event channel > - interrupts: Should contain the event interrupt > - desc-count: Number of asynchronous requests this channel can handle > - iommus: required a iommu node > > +Optional properties for MSI: > +- msi-parent: pointer to the MSI controller object with the DeviceID in use. The format of msi-cells depends on the particular msi-controller, so no need to mention DeviceID here. Please refer to Documentation/devicetree/bindings/interrupt-controller/msi.txt > +Example: > + msi_parent: <&msi0 0x80024> This doesn't match (s/_/-/). > +msi0 is the MSI controller in the system. Bits 0-5 is the channel ID. 4 > +is the channel ID. Bits 5-8 is the instance number. This is for the HIDMA > +instance 1. I don't think you need any of this text, so long as you refer to the generic MSI binding document, as above. Thanks, Mark.
[toc] | [prev] | [next] | [standalone]
| From | Sinan Kaya <okaya@codeaurora.org> |
|---|---|
| Date | 2016-09-23 21:00 +0200 |
| Subject | Re: [PATCH V3 01/10] Documentation: DT: qcom_hidma: update binding for MSI |
| Message-ID | <skDRv-7vd-5@gated-at.bofh.it> |
| In reply to | #1490360 |
On 9/23/2016 2:02 PM, Mark Rutland wrote: > On Thu, Sep 15, 2016 at 01:22:37PM -0400, Sinan Kaya wrote: >> Adding a new binding for qcom,hidma-1.1 to distinguish HW supporting >> MSI interrupts from the older revision. >> >> Signed-off-by: Sinan Kaya <okaya@codeaurora.org> >> --- >> Documentation/devicetree/bindings/dma/qcom_hidma_mgmt.txt | 13 ++++++++++++- >> 1 file changed, 12 insertions(+), 1 deletion(-) >> >> diff --git a/Documentation/devicetree/bindings/dma/qcom_hidma_mgmt.txt b/Documentation/devicetree/bindings/dma/qcom_hidma_mgmt.txt >> index fd5618b..47bfb5a 100644 >> --- a/Documentation/devicetree/bindings/dma/qcom_hidma_mgmt.txt >> +++ b/Documentation/devicetree/bindings/dma/qcom_hidma_mgmt.txt >> @@ -47,12 +47,23 @@ When the OS is not in control of the management interface (i.e. it's a guest), >> the channel nodes appear on their own, not under a management node. >> >> Required properties: >> -- compatible: must contain "qcom,hidma-1.0" >> +- compatible: must contain "qcom,hidma-1.0" for initial HW or "qcom,hidma-1.1" >> +for MSI capable HW. >> - reg: Addresses for the transfer and event channel >> - interrupts: Should contain the event interrupt >> - desc-count: Number of asynchronous requests this channel can handle >> - iommus: required a iommu node >> >> +Optional properties for MSI: >> +- msi-parent: pointer to the MSI controller object with the DeviceID in use. > > The format of msi-cells depends on the particular msi-controller, so no > need to mention DeviceID here. > > Please refer to > Documentation/devicetree/bindings/interrupt-controller/msi.txt Thanks, let me do some more research. > >> +Example: >> + msi_parent: <&msi0 0x80024> > > This doesn't match (s/_/-/). ok > >> +msi0 is the MSI controller in the system. Bits 0-5 is the channel ID. 4 >> +is the channel ID. Bits 5-8 is the instance number. This is for the HIDMA >> +instance 1. > > I don't think you need any of this text, so long as you refer to the > generic MSI binding document, as above. ok > > Thanks, > Mark. > -- Sinan Kaya Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web